test_preserve_preexisting_port failing against icehouse

proposed e-r query: https://review.openstack.org/164120

43 hits in the past ~7h

Fix proposed to branch: master
Review: https://review.openstack.org/164121

Reviewed: https://review.openstack.org/164121
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=8ec99feafebd5ee67a0f4c34bcd5a30d8d42ed97
Submitter: Jenkins
Branch: master

commit 8ec99feafebd5ee67a0f4c34bcd5a30d8d42ed97
Author: Andrea Frittoli <email address hidden>
Date: Fri Mar 13 09:22:56 2015 +0000

    Revert "Add scenario 'test_preserve_preexisting_port'"

    This reverts commit bedd9652206f0a33cd53a3ad51a14a22467b6604.

    The newly added test is causing failures against icehouse,
    reverting it for now until it's fixed.

    e-r query: https://review.openstack.org/#/c/164120/

    Closes-bug: #1431724
    Change-Id: I224b32df50e13f0f2902f3e3921180e72681ac54

The nova patch (https://review.openstack.org/#/c/126309/) does not seem backportable to me since it stands for change in behaviour that people may expect to be stable during single release cycle.

So the test can be introduced only if it's conditionalized to run in Kilo+ only.

It's odd that the change on master passed the neutron full icehouse job:

http://logs.openstack.org/24/160924/8/check/check-tempest-dsvm-neutron-icehouse/3d4b6d0/

The tests should have been skipped on icehouse: http://logs.openstack.org/24/160924/8/check/check-tempest-dsvm-neutron-icehouse/3d4b6d0/console.html#_2015-03-11_22_13_06_088

But apparently they aren't with this job that runs on icehouse:

http://logs.openstack.org/45/164045/1/gate/gate-tempest-dsvm-neutron/0fccaed/console.html#_2015-03-13_02_43_19_464

Related fix proposed to branch: master
Review: https://review.openstack.org/164190

Reviewed: https://review.openstack.org/164190
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=17940737daf172cbb428cef12e5f5765900d580b
Submitter: Jenkins
Branch: master

commit 17940737daf172cbb428cef12e5f5765900d580b
Author: Matt Riedemann <email address hidden>
Date: Fri Mar 13 14:18:19 2015 +0000

    Restore "Add scenario 'test_preserve_preexisting_port'"

    This reverts commit 8ec99feafebd5ee67a0f4c34bcd5a30d8d42ed97

    The neutron job on stable/icehouse was running more tests than what the
    neutron-icehouse compat job was running against tempest changes on
    master, that's why we didn't catch this when the change on master to add
    the test was under review.

    Note that stable/juno neutron jobs were not running these tests either
    because the router extension isn't enabled.

    The difference was we didn't have change
    I7c80e3bfe4962c3e8c94736af21ff215cd98f7f3 on stable/icehouse or
    stable/juno in devstack before the new test merged, which broke
    stable/icehouse.

    Now that devstack is fixed on stable and will run these scenario tests
    we add a 'preserve_ports' config flag to compute-feature-enabled so it
    can be toggled from devstack.
    For stable branches we won't run the test since the code doesn't work in
    Nova on stable (and won't be backported). For master devstack, we'll set
    preserve_ports=True so the test does get run. We can remove the option
    after juno-eol happens.

    Devstack change: I214baa3b861e29bedf6bb7b50534ac2286676dd1

    Related-Bug: #1431724

    Change-Id: I95469e4c2f4aa2bc4e6342860a9c222fb4fa7e16