Ubuntu
autopkgtest package

adt-run should log its command line invocation

Bug #1449413 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autopkgtest (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

I've been using adt-run with various options and missing the command-line invocation in the 'results/log' makes it harder to analyse/compare different runs.

It already does log its version number which is nice and should be kept ;)

Additional brownie points if the logged command line is copy/pastable but quoted arguments may make that tricky (so no big deal).

There may also be some security concerns about credentials in the adt-virt-XXX parameters but I care less about that part.

With all those disclaimers, the specific case that led me to file this bug was to track which run did use '-U' and which one didn't ;)

Martin Pitt (pitti)
Changed in autopkgtest (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in http://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/commit/?id=759f16e6c6 (with proper quoting).

Changed in autopkgtest (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package autopkgtest - 3.14

---------------
autopkgtest (3.14) unstable; urgency=medium

  Improvements:
  * adt-virt-ssh: Add --reboot option to indicate that testbed can be
    rebooted. This is useful when running without a setup script (which can
    already declare capabilities).
  * Simplify reboot implementation: Just call "reboot" as root in the testbed
    to trigger rebooting, and replace the former hook_reboot() in adt-virt-*
    with hook_wait_reboot() which merely waits for the testbed to go down and
    come back up. This also replaces the "reboot" command for ssh setup
    scripts to "wait-reboot" and in most cases it is not needed to implement
    this at all (except for the "adb" script).
  * Add /tmp/autopkgtest-reboot-prepare script for testbeds which support
    rebooting. This saves the current state but leaves the actual reboot to
    the test itself. This is useful if rebooting should happen with unusual
    means (e. g. kexec) or as part of testing something else (like a system
    upgrade). (LP: #1445819)
  * Log complete command line invocation, for easier local reproduction,
    comparison of log files, and clarifying which options were used.
    (LP: #1449413)

  Bug fixes:
  * Update Vcs-Git: field for anonscm.debian.org.
  * Drop obsolete XS-Testsuite: control field.
  * adt-setup-vm: Fix script error if $ADT_SETUP_VM_POST_COMMAND is not set.
  * README.click-tests.rst: Describe x-source manifest entry.
  * Mark test dependencies as manually installed, so that they don't go away
    if a test calls "apt-get autoremove".
  * Set DEBIAN_FRONTEND=noninteractive for tests. This avoids stderr messages
    about "unable to open stdin" and similar when tests call apt-get install.

 -- Martin Pitt <email address hidden> Tue, 05 May 2015 10:14:23 +0200

Changed in autopkgtest (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.