labyrinth malfunctions full report

Maybe related: https://bugs.launchpad.net/widelands/+bug/1251918

Almost perfect and complete bug report. Bug found.

If you would have included also a savegame, in addition to replay, saved just before the problem starts demonstrating, the bug report would have been perfect.

(no need to add attachments this time).

Setting this to In Progress, since you seem to be working on it Teppo :)

One hour of vigorous work, most of which was spent waiting for this antiquated PC to finish compiling. I guess there is no way to avoid a complete recompile when making a new branch? Now ready for a code review.

Yes, compiling from scratch can take a long time. There is a tool called ccache that you might try.

I usually do a full compile before I start working on a new branch, so I can go do something else.

There's also the poor man's version of caching (i.e what I do): keep a reasonably up-to-date branch around for when you need to do some work. That sorta works, assuming you remember to update it from time to time.

I also sometimes just commit patches directly on top of my local trunk. Then I can push it as another branch, create merge proposal, `bzr uncommit && bzr revert` locally and keep following trunk. The drawback is that if the change is not something absolutetly trivial I need to branch/get it in order to respond to code review comments. So I wouldn't necessarily recommend this strategy.

"If you would have included also a savegame, in addition to replay, saved just before the problem starts demonstrating, the bug report would have been perfect."

It does that all the time. It wasn't a problem of the saved game. All I did with the savegame was start and build an economy so I was sure I'd have resources accumulated for the labyrinth to work, because I wanted to dispel any doubt. If you want a savegame, you can just start on any map with atlanteans, save up some food, and make a labyrinth. It behaves consistently like that. You put all resources into it, it kicks out soldiers with evade 1 hp 1 def 1. you put only golden tabards into it,it consistently gives out soldiers with evade 1 and hp 1. If it only has soldiers lacking tthe defence 2 promotion, it will kkick them out most of the times instead of giving them the advanced shield. I wouldn't call it exactly a bug, more like the code being made poorly.
I experimented a lot with atlanteans micromanaging and I discovered that to have a soldier with evade 2 and hp 1 you have to put a soldier in the labyrinth with no shields or tabards until it gets the evade 2, then you can send in the golden tabard. I never found a reliable way to also get defence 2, except to just let all resources go in and wait.

Fix merged to trunk/7453.

Fixed in build19-rc1.