Use flush mount option for removable drives

Bug #149277 reported by Martin Pitt
4
Affects Status Importance Assigned to Milestone
gnome-mount (Ubuntu)
Fix Released
High
Martin Pitt

Bug Description

Binary package hint: gnome-mount

The flush mount option was added to kernel 2.6.19 eventually:

  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ae78bf9c4f5fde3c67e2829505f195d7347ce3e4

We should use it by default for removable drives if it turns out to do what we expect it to.

Related branches

Revision history for this message
Martin Pitt (pitti) wrote :

hal should do that by default preferably, so that we do not have to change it in every DE.

This change will be done early in Hardy, it is not appropriate for Gutsy.

Changed in gnome-mount:
assignee: nobody → pitti
importance: Undecided → High
status: New → In Progress
Revision history for this message
Jbg2 (jbg2) wrote :

How do I get Gusty?

Revision history for this message
Martin Pitt (pitti) wrote :

Unfortunately the flush mount option does not help at all, it seems quite broken in the current kernel.

Changed in hal:
milestone: later → none
status: In Progress → Confirmed
Revision history for this message
Adam Porter (alphapapa) wrote :

Indeed, after waiting for the light on my USB key to stop blinking after copying a file, running sync causes the file to finish writing. Removing it without running sync first results in fs corruption. This, even though mount shows that it's mounted with the flush option.

Revision history for this message
Martin Pitt (pitti) wrote :

hal git head now allows the 'flush' option, and that'll get uploaded soon. gnome-mount should use it once it actually works.

Changed in gnome-mount:
assignee: pitti → nobody
Revision history for this message
Adam Porter (alphapapa) wrote :

What about KDE? Why would this bug be specific to gnome-mount?

Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 149277] Re: Use flush mount option for removable drives

Adam Porter [2008-03-05 10:57 -0000]:
> What about KDE? Why would this bug be specific to gnome-mount?

Right, this should get a bug task for the KIO component, too
(kdelibs?). But anyway, as long as the kernel doesn't provide
something useful, it doesn't make sense.

--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

My 5 today: #198295 (hal), #191725 (hal), #181832 (jockey), #154214
(language-pack-ru), #193978 (gnome-control-center, jockey)
Do 5 a day - every day! https://wiki.ubuntu.com/5-A-Day

Revision history for this message
Adam Porter (alphapapa) wrote :

Well, forgive me, since I don't know exactly how all of the HAL stuff
works with the DE stuff, but using Kubuntu right now, opening my USB
chip and running "mount" in a shell shows that it's already mounted
with flush. The problem is that it doesn't seem to actually do
anything.

So since the flush option is already being used, I don't see how this
bug could really apply to gnome-mount or KIO slaves.

On Wed, Mar 5, 2008 at 5:17 AM, Martin Pitt <email address hidden> wrote:
> Adam Porter [2008-03-05 10:57 -0000]:
>
> > What about KDE? Why would this bug be specific to gnome-mount?
>
> Right, this should get a bug task for the KIO component, too
> (kdelibs?). But anyway, as long as the kernel doesn't provide
> something useful, it doesn't make sense.
>
> --
> Martin Pitt | http://www.piware.de
> Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
>
> My 5 today: #198295 (hal), #191725 (hal), #181832 (jockey), #154214
> (language-pack-ru), #193978 (gnome-control-center, jockey)
> Do 5 a day - every day! https://wiki.ubuntu.com/5-A-Day
>
>
>
> --
> Use flush mount option for removable drives
> https://bugs.launchpad.net/bugs/149277
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Martin Pitt (pitti) wrote :

Hi,

Adam Porter [2008-03-05 11:32 -0000]:
> Well, forgive me, since I don't know exactly how all of the HAL stuff
> works with the DE stuff, but using Kubuntu right now, opening my USB
> chip and running "mount" in a shell shows that it's already mounted
> with flush. The problem is that it doesn't seem to actually do
> anything.

Ah, if Kubuntu already uses the flush mount option, then it only needs
to be added to gnome-mount.

> So since the flush option is already being used, I don't see how this
> bug could really apply to gnome-mount or KIO slaves.

It doesn't apply to KIO then, just to gnome-mount. So current bug
tasks are correct.

--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)

My 5 today: #198295 (hal), #191725 (hal), #181832 (jockey), #154214
(language-pack-ru), #193978 (gnome-control-center, jockey)
Do 5 a day - every day! https://wiki.ubuntu.com/5-A-Day

Martin Pitt (pitti)
Changed in gnome-mount:
assignee: nobody → pitti
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-mount - 0.8~svn20080225-0ubuntu1

---------------
gnome-mount (0.8~svn20080225-0ubuntu1) hardy; urgency=low

  * Update to SVN snapshot:
    - Builds nautilus extension for new nautilus 2.0 ABI now, unbreaking the
      volume/drive properties tabs. (LP: #186196)
    - Applied debian/patches/02_msgbox_unref.patch upstream, removed patch.
    - No other changes.
  * debian/patches/ubuntu-default-mount-options.patch: Use 'flush' option for
    vfat. It does not actually work in the current kernel, but at least it's
    there once it will actually do something useful. (LP: #149277)

 -- Martin Pitt <email address hidden> Wed, 05 Mar 2008 15:30:46 +0100

Changed in gnome-mount:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.