Trusty multipath-tools suffering seg faults
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| multipath-tools (Ubuntu) |
Invalid
|
High
|
Unassigned | ||
| Trusty |
Fix Released
|
High
|
Louis Bouchard | ||
Bug Description
[Impact]
* multipath segfaults constantly on given circumstances
* multipath might make other tools relying on it to misbehave (openstack)
[Test Case]
* Core Dump given. No test case or reproducer.
* Will ask user in charge for the dump to verify fix.
[Regression Potential]
* Cherry-picked commit that EXACTLY fits seg fault and dump analysis.
* Minor change.
[Other Info]
####
Original BUG Description:
It was brought to my knowledge that multipath-tools is facing segfaults:
----
Core was generated by `/sbin/multipath -v0 /dev/sdab'. Program terminated with signal 11, Segmentation fault. #0 0x00007f2b5f6c8e88 in scsi_sysfs_pathinfo (pp=0xe5c0e0) at discovery.c:441
----
All core dumps I received - several - have IP at the same place:
----
#0 0x00007f2b5f6c8e88 in scsi_sysfs_pathinfo (pp=0xe5c0e0) at discovery.c:441
#1 0x00007f2b5f6c9c26 in sysfs_pathinfo (pp=0xe5c0e0) at discovery.c:689
#2 0x00007f2b5f6ca48b in pathinfo (pp=0xe5c0e0, hwtable=0xe222f0, mask=63) at discovery.c:823
#3 0x00007f2b5f6c7858 in store_pathinfo (pathvec=0xe2d8d0, hwtable=0xe222f0, udevice=0xe5bc60, flag=31, pp_ptr=0x0) at discovery.c:57
#4 0x00007f2b5f6c7953 in path_discover (pathvec=0xe2d8d0, conf=0xe22110, udevice=0xe5bc60, flag=31) at discovery.c:91
#5 0x00007f2b5f6c7ad3 in path_discovery (pathvec=0xe2d8d0, conf=0xe22110, flag=31) at discovery.c:127
#6 0x00000000004025e6 in configure () at main.c:322
----
From libmultipath/
if (!strncmp(
It is clear that strncmp is not taking care of cases when udev_device_
----
commit e546687e046b1eb
Author: Benjamin Marzinski <email address hidden>
Date: Sat Jan 12 00:04:54 2013 -0600
multipath: check for NULL from udev_device_get_*
The udev_device_get_* functions can return NULL, an occassionally do
so in the multipathd code. multipath needs to check if the result
is NULL before dereferencing it.
Signed-off-by: Benjamin Marzinski <email address hidden>
----
Takes care of exactly this situation. This commit is found in the following versions:
----
inaddy@
0.5.0
----
And, from rmadison, this fix should be backported to Trusty & Vivid (not at 0.5.0 yet).
| Changed in multipath-tools (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Rafael David Tinoco (inaddy) |
| description: | updated |
| Rafael David Tinoco (rafaeldtinoco) wrote | #1 |
| tags: | added: sts |
| Ubuntu Foundations Team Bug Bot (crichton) wrote | #3 |
| tags: | added: patch |
| Changed in multipath-tools (Ubuntu): | |
| importance: | Undecided → High |
| Rafael David Tinoco (rafaeldtinoco) wrote | #4 |
| Changed in multipath-tools (Ubuntu Trusty): | |
| importance: | Undecided → High |
| Changed in multipath-tools (Ubuntu Trusty): | |
| status: | New → Triaged |
| Changed in multipath-tools (Ubuntu): | |
| assignee: | Rafael David Tinoco (inaddy) → nobody |
| Changed in multipath-tools (Ubuntu Trusty): | |
| assignee: | nobody → Louis Bouchard (louis-bouchard) |
| tags: | added: sts-sru |
| Changed in multipath-tools (Ubuntu): | |
| status: | In Progress → Invalid |
| Changed in multipath-tools (Ubuntu Trusty): | |
| status: | Triaged → In Progress |
| Louis Bouchard (louis) wrote | #5 |
| Chris J Arges (arges) wrote | #6 |
| Louis Bouchard (louis) wrote | #7 |
| Brian Murray (brian-murray) wrote Please test proposed package | #8 |
| Changed in multipath-tools (Ubuntu Trusty): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed |
| Louis Bouchard (louis) wrote | #9 |
| tags: |
added: verification-done removed: verification-needed |
| tags: |
added: verification-needed removed: verification-done |
| Martin Pitt (pitti) wrote | #10 |
| Gábor Mészáros (gabor.meszaros) wrote | #11 |
| Louis Bouchard (louis) wrote | #12 |
| tags: |
added: verification-done removed: verification-needed |
| Launchpad Janitor (janitor) wrote | #13 |
| Changed in multipath-tools (Ubuntu Trusty): | |
| status: | Fix Committed → Fix Released |
| Martin Pitt (pitti) wrote Update Released | #14 |
Precise being fixed together with:
https:/
SRU proposal.