Pressing Enter in "Another e-mail address:" field applies for a mailing list

Release Critical me thinks.

There is some confusion abound here. This feature AFAIK is only disabled on production and edge.

If it doesn't affect a config with the protection flag disabled, then there's no bug here. That's the first thing I'll check.

This is not affecting any of the production systems, so it's not critical.

I don't think we can split out the forms like we did in 1348. The radio options and the text box are tied to the second button. Ideally the first button would be in a form by itself, but it's located between the first and second radio buttons, and you can't nest HTML forms.

I can think of a couple Javascript solutions. We can hack the text box's onKeyPress to prevent enter from submitting the form at all. I think we can hack it to submit the form with the second button.

Incidentally, I'm pretty sure form-submission-on-Enter is Mozilla-specific behavior.

> Incidentally, I'm pretty sure form-submission-on-Enter is Mozilla-
> specific behavior.

No, IE does it as well.

I'm not in favor of doing JS hacks to fix this.

I ran a test. Safari had the Mozilla behavior (submitted as though I clicked on the first button). IE submitted the form as though I'd called Javascript form.submit--no button at all.

A non-JS solution is to move the mailing list request form out of the contact method form. Put it at the top in a box. "Want to create a mailing list to use as the contact address? Request one here."

One question. The button has a name. Can you check if the button was pressed in the form data submitted? If not I agree, we need to change the form.

The mailing list request form has no input fields, so from an HTTP perspective it's easy. If no button name was submitted it's because someone hit enter within a field in the contact message.

From a Zope perspective I don't know. Zope routes an incoming request to an action based on the button name. There must be something making it decide to treat a request with no button name as one action rather than the other, but I don't know what.

In talking with flacoste I've started to like the idea of making the 'configure mailing list' screen I created for team-mailing-lists-membership-ui also responsible for the creation of the mailing list. Someone who wants a mailing list for their team is more likely to go to "Configure mailing list" than "Change contact address'. That would solve this problem as a side effect.

I misspoke--I was thinking of my IE test. Like I said, IE submits the form with no button, which (according to flacoste) Zope can't handle, though in theory it's handlable. Firefox submits the form exactly as though the user had clicked on the first button--"Request mailing list creation". There's no way to distinguish between the cases.

On Thu, Oct 25, 2007 at 07:43:25PM -0000, Leonard Richardson wrote:
> In talking with flacoste I've started to like the idea of making the
> 'configure mailing list' screen I created for team-mailing-lists-
> membership-ui also responsible for the creation of the mailing list.
> Someone who wants a mailing list for their team is more likely to go to
> "Configure mailing list" than "Change contact address'. That would solve
> this problem as a side effect.

Indeed, there should be a separate page for requesting
activation/deactivation of a team's mailing list, but when I discussed this
with Francis and Barry we agreed it'd be nice to make that possible from the
+contactaddress page as well, rather than just point people to another page.

On October 25, 2007, Guilherme Salgado wrote:
> Indeed, there should be a separate page for requesting
> activation/deactivation of a team's mailing list, but when I discussed this
> with Francis and Barry we agreed it'd be nice to make that possible from
> the +contactaddress page as well, rather than just point people to another
> page.
>

Indeed that was the original intent. But I think this will be an action that
will be done rarely enough that adding a click isn't that bad, if it makes
the implementation easier and cleaner.

I've got a branch that moves the whole mailing list creation form to the mailing list configuration screen. This makes the contact address screen much simpler. I also added a button on the mailing list configuration screen that makes it possible to set a mailing list as contact address with one click.

Fixed in revision 5183.