[SRU] Wrong installation path (0.16 instead of 0.17)

Bug #1556685 reported by neomilium
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oce (Debian)
Fix Released
Unknown
oce (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
Users building their own projects using OpenCASCADE Community Edition (OCE) and installing the development libraries liboce-*-dev and oce-draw will be surprised to find .cmake files in (e.g.) /usr/lib/x86_64-linux-gnu/oce-0.16 instead of /usr/lib/x86_64-linux-gnu/oce-0.17. The impact is purely visual as these files are only used during compilation and thus do not impact binaries that were built with the files in the wrong directory.

[Test Case]
The updated installation directories can easily be observed.

With liboce-visualization-dev 0.17-1-1:
$ sudo apt-get install liboce-visualization-dev
$ ls -d /usr/lib/x86_64-linux-gnu/oce-*
/usr/lib/x86_64-linux-gnu/oce-0.16

With liboce-visualization-dev 0.17-1-1ubuntu0.1:
$ sudo apt-get install liboce-visualization-dev
$ ls -d /usr/lib/x86_64-linux-gnu/oce-*
/usr/lib/x86_64-linux-gnu/oce-0.17

It should be verified that packages with build-dependencies on liboce-*-dev and oce-draw; namely freecad, gmsh and netgen, are able to build after upgrading. Take note that these packages FTBFS before upgrading due to LP: #1556680.

[Regression Potential]
Minimal, the packages liboce-*-dev and oce-draw that ship the files that were moved do not have any direct reverse-dependencies.

-----------------------------------------------------------------------------

System: Xenial (16.04)
Package: oce (0.17.1-1)

OCE package installs some data into "oce-0.16" directory instead of oce-0.17.

In debian/rules file at line #26, it should be:
        -DOCE_INSTALL_CMAKE_DATA_DIR:PATH=lib/$(DEB_HOST_MULTIARCH)/oce-0.17 \
instead of
        -DOCE_INSTALL_CMAKE_DATA_DIR:PATH=lib/$(DEB_HOST_MULTIARCH)/oce-0.16 \

Changed in oce (Debian):
status: Unknown → New
Changed in oce (Debian):
status: New → Fix Released
Graham Inggs (ginggs)
Changed in oce (Ubuntu):
status: New → Fix Released
Changed in oce (Ubuntu Xenial):
status: New → Confirmed
Graham Inggs (ginggs)
Changed in oce (Ubuntu Xenial):
status: Confirmed → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Can you please write a test case that demonstrates the observable effect on reverse dependencies? The changed installation path can certainly be observed, but that's not proof that the proposed one is actually "correct" in the sense of "works for consumers of oce". Thanks!

Martin Pitt (pitti)
Changed in oce (Ubuntu Xenial):
status: Fix Committed → Incomplete
Revision history for this message
Steve Langasek (vorlon) wrote :

rejected from queue while waiting for test case.

Revision history for this message
Graham Inggs (ginggs) wrote :

Sorry pitti, I missed your question as I wasn't automatically subscribed to this bug.

As far as I can determine, this change is cosmetic. The files that get installed into lib/$(DEB_HOST_MULTIARCH)/oce-0.17 are mostly .cmake files that end up in the liboce-*-dev packages.

Except for the files that end up in oce-draw, which has no reverse-dependencies but is a build dependency of freecad and gmsh.

Graham Inggs (ginggs)
description: updated
summary: - Wrong installation path (0.16 instead of 0.17)
+ [SRU] Wrong installation path (0.16 instead of 0.17)
Revision history for this message
Graham Inggs (ginggs) wrote :

Debdiff for Xenial SRU attached to LP: #1556680.

Graham Inggs (ginggs)
Changed in oce (Ubuntu Xenial):
status: Incomplete → New
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello neomilium, or anyone else affected,

Accepted oce into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oce/0.17.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in oce (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
neomilium (neomilium) wrote :

Hello Brian,

I confirm that I now can build and use HeeksCAD, with its module HeeksCNC, both depending on OCE.

I used liboce-visualization-dev/xenial-proposed package and regular building of HeeksCAD and HeeksCNC works as expected.

Thanks !

Graham Inggs (ginggs)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package oce - 0.17.1-1ubuntu0.1

---------------
oce (0.17.1-1ubuntu0.1) xenial; urgency=medium

  * Backport 0.17-1-2 from Yakkety as an SRU, including changes:
    + Build-Depend on libfreeimageplus-dev instead of libfreeimage-dev
      in order to build with freeimage >= 3.17.0.
    + Rebuild against freeimage >= 3.17.0 to pick up correct library path
      in OCE04_VisualizationTargets-relwithdebinfo.cmake. (LP: #1556680)
    + Install files in /usr/lib/$(DEB_HOST_MULTIARCH)/oce-0.17. (LP: #1556685)

 -- Graham Inggs <email address hidden> Sun, 22 May 2016 15:08:27 +0200

Changed in oce (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for oce has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.