please merge sbuild from Debian

Bug #1591674 reported by Gianfranco Costamagna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sbuild (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

I don't want to mess up with sbuild, so I prefer somebody else to sponsor it :)

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :
Mathew Hodson (mhodson)
Changed in sbuild (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the debdiff! Here are some comments:

- Please update the "Last-Update" tags on the patches you've updated
- do-not-install-debfoster-into-chroots.patch looks like it is still needed, please add it back
- Please add Ubuntu patches to the end of the series file, not the beginning

The remaining changes look good, but I haven't actually tested it on Yakkety.
Thanks!

Changed in sbuild (Ubuntu):
status: New → Incomplete
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

updated debdiff, thanks for the review!

Changed in sbuild (Ubuntu):
status: Incomplete → New
Revision history for this message
Martin Pitt (pitti) wrote :

Diff looks mostly good to me, however, this is completely busted: Installing the built package and trying to build anything with it crashes with:

$ sbuild -d yakkety sbuild_0.69.0-2ubuntu1.dsc
syntax error at /usr/share/perl5/Sbuild/ResolverBase.pm line 970, near "USER"
Global symbol "$self" requires explicit package name (did you forget to declare "my $self"?) at /usr/share/perl5/Sbuild/ResolverBase.pm line 973.
Global symbol "$self" requires explicit package name (did you forget to declare "my $self"?) at /usr/share/perl5/Sbuild/ResolverBase.pm line 974.
Global symbol "$session" requires explicit package name (did you forget to declare "my $session"?) at /usr/share/perl5/Sbuild/ResolverBase.pm line 979.
Global symbol "$dummy_dsc" requires explicit package name (did you forget to declare "my $dummy_dsc"?) at /usr/share/perl5/Sbuild/ResolverBase.pm line 979.
Global symbol "$self" requires explicit package name (did you forget to declare "my $self"?) at /usr/share/perl5/Sbuild/ResolverBase.pm line 981.
Global symbol "$dummy_dsc" requires explicit package name (did you forget to declare "my $dummy_dsc"?) at /usr/share/perl5/Sbuild/ResolverBase.pm line 981.
[...]
syntax error at /usr/share/perl5/Sbuild/ResolverBase.pm line 1213, near "}"
/usr/share/perl5/Sbuild/ResolverBase.pm has too many errors.
Compilation failed in require at /usr/share/perl5/Sbuild/AptResolver.pm line 29.
BEGIN failed--compilation aborted at /usr/share/perl5/Sbuild/AptResolver.pm line 29.
Compilation failed in require at /usr/share/perl5/Sbuild/Resolver.pm line 23.
BEGIN failed--compilation aborted at /usr/share/perl5/Sbuild/Resolver.pm line 23.
Compilation failed in require at /usr/share/perl5/Sbuild/Build.pm line 56.
BEGIN failed--compilation aborted at /usr/share/perl5/Sbuild/Build.pm line 56.
Compilation failed in require at /usr/bin/sbuild line 40.
BEGIN failed--compilation aborted at /usr/bin/sbuild line 40.

Changed in sbuild (Ubuntu):
status: New → Incomplete
Revision history for this message
Martin Pitt (pitti) wrote :

Please re-subscribe sponsors when there is an updated patch. Thanks!

Revision history for this message
Martin Pitt (pitti) wrote :

Adding the missing comma fixes it, works fine now. Thanks!

Changed in sbuild (Ubuntu):
status: Incomplete → In Progress
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

self sponsored after adding a missing comma :)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sbuild - 0.69.0-2ubuntu1

---------------
sbuild (0.69.0-2ubuntu1) yakkety; urgency=low

  * Merge from Debian unstable (LP: #1591674). Remaining changes:
    - no-pkg-mangle-deps.patch: Set NO_PKG_MANGLE=1 when building dummy
      packages, as pkgbinarymangler's dpkg-deb expects to be run from a source
      package.
    - Set APT::Sandbox::User=root when running apt-get source in the
      build-procenv autopkgtest, to avoid stderr noise from current apt.
    - Silence a couple of warnings from sbuild-createchroot which caused some
      autopkgtest runs to fail.
    - utf-8-by-default.patch: Switch to C.UTF-8 by default (LP: #1566590)
    - abs-path-revert.patch: Revert upstream commit that breaks lp-buildd by
      causing symlinks to files not ending in .dsc to no longer be buildable.
  * Drop patches included/applied in Debian: apt-conf-quotes.patch,
    copy-dummy-archive.patch, dummy-archive-sha512.patch,
    fix-quoting-harder.patch

 -- Gianfranco Costamagna <email address hidden> Sun, 12 Jun 2016 12:48:21 +0200

Changed in sbuild (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.