Launchpad itself

lp-remove-package.py does not log removals to our standard place

Bug #159585 reported by Colin Watson
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Celso Providelo
Launchpad itself 2.2.1

Bug Description

Historically, all removals performed by Ubuntu archive administrators have been logged to /srv/launchpad.net/dak/removals.txt. It is very important for us that we have a single place where all of this information is logged, in order that we can easily look back to see when and why a package was removed. (Launchpad tells us when, but historically didn't save the reason. From now on lp-remove-package.py appears to save the reason in the Launchpad database, which is great, but I don't want us to have to look in two places.)

I think it will be best for us not to use lp-remove-package.py yet since it will break our historical logging. Please make it save this information in the old location as well for compatibility (or else import all the old data into Launchpad so that we only have to look in one place). See remove-package.py for the format, but it looks like this:

=========================================================================
[Date: Thu, 01 Nov 2007 18:03:57 +0000] [ftpmaster: Launchpad Archive Manager]
Removed the following packages from hardy:

 libpixman | 0.1.6-1 | source
libpixman1 | 0.1.6-1 | amd64, hppa, i386, ia64, lpia, powerpc, sparc
libpixman1-dev | 0.1.6-1 | amd64, hppa, i386, ia64, lpia, powerpc, sparc

------------------- Reason -------------------
(pitti) superseded by pixman, obsolete
----------------------------------------------
=========================================================================

Revision history for this message
Celso Providelo (cprov) wrote :

This information is stored in the launchpad database now, as part of the archive-removal-redesign implementation.

Any removal performed with `lp-remove-package.py` can be audited in the same way, it's just not there as a plain text file.

Would you be comfortable if we have a page under distroseries were you can browse/audit removals ?

Revision history for this message
Colin Watson (cjwatson) wrote :

In that case we need all of the old data, including reasons, to be imported into Launchpad so that we don't have to look in two places for it.

We don't need an additional page as far as I can see, just an import of the data.

Celso Providelo (cprov)
Changed in soyuz:
milestone: none → 1.1.11
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 1.1.11 → 1.2.1
Revision history for this message
Julian Edwards (julian-edwards) wrote :

The best way forward from the Soyuz point of view is that we parse the existing removals.txt and update the publishing records that are currently "incorrectly" marked as superseded instead of deleted.

However, this is a time consuming exercise for little benefit and since we're overloaded with work right now, I can't see this getting done too soon I'm afraid.

Having said that, if we get a third person on the team soon, this would be an ideal piece of work for them, so it could get done in a couple of months.

Changed in soyuz:
importance: Undecided → Low
milestone: 1.2.1 → 1.2.3
status: New → Confirmed
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 1.2.3 → none
Revision history for this message
Colin Watson (cjwatson) wrote :

I hear the Soyuz team is growing ...

Any news on assigning this task to somebody? It would be nice to get it over and done with so that we can stop being collectively confused every so often.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Colin, I'll see if we can do this in December. November is Full (tm).

Changed in soyuz:
importance: Low → Medium
milestone: none → 2.1.12
Celso Providelo (cprov)
Changed in soyuz:
assignee: nobody → cprov
Revision history for this message
Celso Providelo (cprov) wrote :

Based on the a quick IRC discussion with Colin, it was decided that for this task we should simply migrate the historical data from the file to the DB and the current UI (package-driven) will suffice for the current use-cases.

In the near future (next milestone, probably) we should invest some time in a UI & API to allow users to browse the full deletion log for a distroseries providing a similar experience than "looking at a logfile for a distroseries".

Celso Providelo (cprov)
Changed in soyuz:
milestone: 2.1.12 → 2.2.1
Celso Providelo (cprov)
Changed in soyuz:
status: Confirmed → In Progress
Revision history for this message
Celso Providelo (cprov) wrote :

Historical data from `removals.txt` was migrated to the Launchpad database and it's visible in the UI.

Changed in soyuz:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.