Pixelated icons for rotation, flight mode, about and reset items
Bug #1596529 reported by
Alberto Mardegan
This bug affects 7 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Low
|
Bill Filler | ||
| ubuntu-system-settings (Ubuntu) |
Fix Released
|
Medium
|
Alberto Mardegan | ||
Bug Description
While most of the icons in System Settings are nicely smoothed, those used in the listitem elements are not.
This is because the ListItem.Standard elements are not smoothing their icons. Given that these items are deprecated, it's better to migrate to the new ListItem element. I'll prepare a branch for this.
Related branches
lp:~mardy/ubuntu-system-settings/smoothed-1596529
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- PS Jenkins bot: Pending (continuous-integration) requested
- Ubuntu Touch System Settings: Pending requested
-
Diff: 178 lines (+81/-46)4 files modifiedplugins/about/EntryComponent.qml (+14/-6)
plugins/flight-mode/EntryComponent.qml (+25/-15)
plugins/orientation-lock/EntryComponent.qml (+28/-19)
plugins/reset/EntryComponent.qml (+14/-6)
lp:~ken-vandine/ubuntu-system-settings/slotsLayout
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Jonas G. Drange (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 4642 lines (+1262/-994)70 files modifiedplugins/about/EntryComponent.qml (+15/-7)
plugins/about/PageComponent.qml (+40/-43)
plugins/about/settings-about.svg (+136/-35)
plugins/battery/PageComponent.qml (+28/-16)
plugins/bluetooth/DevicePage.qml (+26/-50)
plugins/bluetooth/PageComponent.qml (+34/-61)
plugins/cellular/Components/MultiSim.qml (+9/-13)
plugins/cellular/Components/Sim.qml (+6/-2)
plugins/cellular/Components/SingleSim.qml (+20/-25)
plugins/cellular/PageCarrierAndApn.qml (+7/-7)
plugins/cellular/PageCarriersAndApns.qml (+36/-53)
plugins/cellular/PageChooseApn.qml (+17/-50)
plugins/cellular/PageComponent.qml (+1/-2)
plugins/flight-mode/EntryComponent.qml (+26/-16)
plugins/flight-mode/flight-mode.settings (+1/-1)
plugins/hotspot/HotspotSetup.qml (+19/-44)
plugins/hotspot/PageComponent.qml (+8/-5)
plugins/language/settings-language.svg (+112/-75)
plugins/mouse/PrimaryButtonSelector.qml (+1/-2)
plugins/orientation-lock/EntryComponent.qml (+29/-20)
plugins/orientation-lock/orientation-lock.settings (+1/-1)
plugins/phone/CallForwarding.qml (+1/-2)
plugins/reset/EntryComponent.qml (+15/-7)
plugins/reset/PageComponent.qml (+55/-20)
plugins/security-privacy/AppAccess.qml (+11/-10)
plugins/security-privacy/AppAccessControl.qml (+7/-6)
plugins/security-privacy/Location.qml (+9/-9)
plugins/security-privacy/LockSecurity.qml (+6/-5)
plugins/security-privacy/PageComponent.qml (+28/-23)
plugins/security-privacy/PhoneLocking.qml (+12/-13)
plugins/security-privacy/SimPin.qml (+15/-14)
plugins/security-privacy/diagnostics/DiagnosticsCheckEntry.qml (+3/-3)
plugins/security-privacy/diagnostics/PageComponent.qml (+10/-11)
plugins/sound/PageComponent.qml (+58/-50)
plugins/system-update/EntryComponent.qml (+18/-9)
plugins/time-date/ChooseTimeZone.qml (+4/-3)
plugins/time-date/PageComponent.qml (+8/-8)
plugins/time-date/Scroller.qml (+6/-7)
plugins/time-date/TimePicker.qml (+1/-2)
plugins/time-date/settings-time-date.svg (+139/-55)
plugins/wifi/AccessPoint.qml (+11/-22)
plugins/wifi/DivMenuItem.qml (+3/-3)
plugins/wifi/FramedMenuItem.qml (+7/-3)
plugins/wifi/MenuItemFactory.qml (+4/-4)
plugins/wifi/NetworkDetails.qml (+26/-29)
plugins/wifi/NetworkDetailsBrief.qml (+18/-17)
plugins/wifi/OtherNetwork.qml (+11/-11)
plugins/wifi/PageComponent.qml (+9/-13)
plugins/wifi/PreviousNetworks.qml (+3/-4)
plugins/wifi/SectionMenuItem.qml (+15/-30)
plugins/wifi/StandardMenuItem.qml (+6/-28)
plugins/wifi/SwitchMenuItem.qml (+2/-2)
src/CMakeLists.txt (+1/-0)
src/SystemSettings/ListItems/Icon.qml (+1/-1)
src/SystemSettings/ListItems/IconProgression.qml (+1/-1)
src/SystemSettings/ListItems/SingleControl.qml (+1/-1)
src/SystemSettings/ListItems/SingleValue.qml (+1/-1)
src/SystemSettings/ListItems/SingleValueProgression.qml (+1/-1)
src/SystemSettings/ListItems/Standard.qml (+1/-1)
src/SystemSettings/ListItems/StandardProgression.qml (+1/-1)
src/SystemSettings/SettingsItemTitle.qml (+1/-1)
src/SystemSettings/qmldir (+1/-0)
src/qml/CategoryGrid.qml (+90/-0)
src/qml/CategorySection.qml (+33/-24)
src/qml/MainWindow.qml (+18/-4)
src/ui.qrc (+1/-0)
tests/autopilot/ubuntu_system_settings/__init__.py (+9/-2)
tests/autopilot/ubuntu_system_settings/tests/test_cellular.py (+3/-1)
tests/autopilot/ubuntu_system_settings/tests/test_search.py (+2/-1)
tests/autopilot/ubuntu_system_settings/tests/test_security.py (+3/-3)
Revision history for this message
| Alberto Mardegan (mardy) wrote | #1 |
Revision history for this message
| Matthew Paul Thomas (mpt) wrote | #2 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | New → Confirmed |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #4 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| assignee: | nobody → Alberto Mardegan (mardy) |
| importance: | Undecided → Medium |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| importance: | Undecided → Low |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| milestone: | none → 13 |
| Changed in canonical-devices-system-image: | |
| assignee: | Alejandro J. Cura (alecu) → Bill Filler (bfiller) |
| tags: | added: visual-quality |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thank you!