[RFE] Allow setting {provisioning,cleaning}_network in node driver_info

Bug #1614876 reported by Dmitry Tantsur
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Dmitry Tantsur

Bug Description

There are several reasons users might want it:
1. Users of our API are not necessary the same people who install Ironic. They might not have rights to modify configuration files. This is even more important now that we have policy support.
2. Installers like TripleO install and configure all services before the first objects (like networks) are created by users. So a user has to set this configuration option manually on all Ironic nodes or run a long stack-update process just for this one option.
3. They actually have different provisioning/cleaning networks (e.g. because of network topology).
4. For consistency with deploy_{kernel,ramdisk} which are set on node.

I suggest accepting driver_info[cleaning_network] and falling back to the existing configuration if it's not present. The check on present {cleaning,provisioning}_network_uuid will move from __init__ to validate.

Tags: rfe-approved
Dmitry Tantsur (divius)
summary: - It is impossible to set cleaning_network_uuid per node
+ [RFE] Allow setting cleaning_network_uuid per node
Changed in ironic:
status: New → Confirmed
importance: Undecided → Wishlist
tags: added: rfe
description: updated
Dmitry Tantsur (divius)
description: updated
description: updated
summary: - [RFE] Allow setting cleaning_network_uuid per node
+ [RFE] Allow setting {provisioning,cleaning}_network_uuid in node
+ driver_info
description: updated
Dmitry Tantsur (divius)
Changed in ironic:
assignee: nobody → Dmitry Tantsur (divius)
Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote : Re: [RFE] Allow setting {provisioning,cleaning}_network_uuid in node driver_info

While I don't think this is very useful, and I think it's kind of silly, I'm okay with this if we fall back to config. Someone is going to come along eventually with a real use case for it anyway.

Let's be clear though: I don't think tripleo's architecture alone is ever a reason to do something like this in ironic.

Revision history for this message
Dmitry Tantsur (divius) wrote :

It's not "tripleo's architecture", it is at least shared by anything using puppet-openstack. I think there reasoning was kind of similar to our reasoning when we refuse to touch user instances: there can be way too many options to cover.

Dmitry Tantsur (divius)
Changed in ironic:
assignee: Dmitry Tantsur (divius) → nobody
Revision history for this message
Ruby Loo (rloo) wrote :

I'm fine with this.

tags: added: rfe-approved
removed: rfe
Dmitry Tantsur (divius)
summary: - [RFE] Allow setting {provisioning,cleaning}_network_uuid in node
- driver_info
+ [RFE] Allow setting {provisioning,cleaning}_network in node driver_info
M V P Nitesh (m-nitesh)
Changed in ironic:
assignee: nobody → M V P Nitesh (m-nitesh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/460564

Changed in ironic:
status: Confirmed → In Progress
Changed in ironic:
assignee: M V P Nitesh (m-nitesh) → Dmitry Tantsur (divius)
Changed in ironic:
assignee: Dmitry Tantsur (divius) → Harald Jensås (harald-jensas)
Changed in ironic:
assignee: Harald Jensås (harald-jensas) → Dmitry Tantsur (divius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/460564
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=95d7e602e51325725dc0a3ebeb603b14813acccd
Submitter: Zuul
Branch: master

commit 95d7e602e51325725dc0a3ebeb603b14813acccd
Author: M V P Nitesh <email address hidden>
Date: Thu Jul 6 12:29:33 2017 +0530

    Allow setting {provisioning,cleaning,rescuing}_network in driver_info

    These values have priority over ones defined in ironic.conf. Also modify
    validation code to only used network UUID cached on task.network if:
    1. the requested XXX_network is UUID, not name
    2. the requested XXX_network is the same as the cached one.

    Co-Authored-By: Dmitry Tantsur <email address hidden>
    Closes-Bug: #1614876
    Change-Id: I4caec34d85304fe887bcc28b7528cceceb3acfe8

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 10.1.0

This issue was fixed in the openstack/ironic 10.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.