OpenStack Compute (nova)

Live migration always fails when VNC/SPICE is listening at non-local, non-catch-all address

Bug #1615613 reported by Paulo Matias
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
John Garbutt

Bug Description

When VNC or SPICE is configured to listen only at a specific IP address (e.g. on the management network in an OpenStack-Ansible deploy), the check performed by check_can_live_migrate_source always fails, because check_can_live_migrate_destination does not return the attributes needed to retrieve listen_addrs using libvirt_migrate.graphics_listen_addrs.

Steps to reproduce:

 * Deploy OpenStack-Ansible from master.

 * Create an instance.

 * Try to live migrate the instance to another host.

Expected result: live migration should be carried.

Actual result (nova-compute.log):

ERROR oslo_messaging.rpc.server MigrationError: Migration error: Your libvirt version does not support the VIR_DOMAIN_XML_MIGRATABLE flag or your destination node does not support retrieving listen addresses. In order for live migration to work properly, you must configure the graphics (VNC and/or SPICE) listen addresses to be either the catch-all address (0.0.0.0 or ::) or the local address (127.0.0.1 or ::1).

Environment:

* Multi-node OpenStack-Ansible deploy.

* Nova from git (commit 32b7526b3cf40f40c5430034f75444fc64ac0e04).

* Libvirt + KVM

Paulo Matias (paulo-matias)
Changed in nova:
status: New → In Progress
assignee: nobody → Paulo Matias (paulo-matias)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/358599

Markus Zoeller (markus_z) (mzoeller)
Changed in nova:
importance: Undecided → High
Revision history for this message
Pawel Koniszewski (pawel-koniszewski) wrote :

This is regression introduced in Newton, corresponding patch - https://review.openstack.org/#/c/254709/. Mitaka is not affected.

Sahid Orentino (sahid-ferdjaoui)
tags: added: mitaka-backport-potential
Revision history for this message
Pawel Koniszewski (pawel-koniszewski) wrote :

Sahid, Mitaka is not affected by this. All the data is set in pre_live_migration step:
https://github.com/openstack/nova/blob/6404c4199fcac8c518a7750a06620b4cde97849b/nova/virt/libvirt/driver.py#L6727
All the checks are done after this step:
* in _update_xml which is called from live_migration_operation
https://github.com/openstack/nova/blob/6404c4199fcac8c518a7750a06620b4cde97849b/nova/virt/libvirt/driver.py#L5843
* in live_migration_operation
https://github.com/openstack/nova/blob/6404c4199fcac8c518a7750a06620b4cde97849b/nova/virt/libvirt/driver.py#L6018
https://github.com/openstack/nova/blob/6404c4199fcac8c518a7750a06620b4cde97849b/nova/virt/libvirt/driver.py#L6068

tags: removed: mitaka-backport-potential
Paul Murray (pmurray)
tags: added: newton-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/368732

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/368732
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2ba8fd42901c49a698b8f85f6d8058ce606380d8
Submitter: Jenkins
Branch: master

commit 2ba8fd42901c49a698b8f85f6d8058ce606380d8
Author: John Garbutt <email address hidden>
Date: Mon Sep 12 13:50:36 2016 +0100

    Revert "libvirt: move graphic/serial consoles check to pre_live_migration"

    This reverts the key bits of commit
    917afd2831be8107177f50f277e400e03f896f74.

    Change-Id: I0425b254595371eaa618b10d8c81520b0f6018a5
    Related-Bug: #1615613

Matt Riedemann (mriedem)
Changed in nova:
status: In Progress → Fix Released
assignee: Paulo Matias (paulo-matias) → John Garbutt (johngarbutt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/358599
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3ec1eca4ef1f4e3b23cf88ce9c3b845933a128ee
Submitter: Jenkins
Branch: master

commit 3ec1eca4ef1f4e3b23cf88ce9c3b845933a128ee
Author: Paulo Matias <email address hidden>
Date: Mon Aug 22 09:22:37 2016 -0300

    Fill destination check data with VNC/SPICE listen addresses

    We move were we populate the data around the listen addresses, so in a
    future release we can move the check into
    check_can_live_migrate_source

    Change-Id: I64aebdfc132d319be6fc04efe456cdc541f5b2e8
    Related-Bug: #1615613

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/newton)

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/388534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/newton)

Change abandoned by Lee Yarwood (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/388534
Reason: Apologies, I missed that the revert was the real bugfix here, already merged in stable/newton.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.