xymon-client and snaps, client report gets red in disk, inode, misc states

Bug #1798557 reported by Lenin
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
hobbit-plugins (Ubuntu)
Fix Released
Undecided
Unassigned
xymon (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When using snaps, xymon-client should ignore the
/var/lib/snapd/snaps/core_5662.snap on /snap/core/5662 type squashfs (ro,nodev,relatime,x-gdu.hide)
/var/lib/snapd/snaps/signal-desktop_93.snap on /snap/signal-desktop/93 type squashfs (ro,nodev,relatime,x-gdu.hide)

disk
Thu Oct 18 11:23:09 CEST 2018 - Filesystems NOT ok
red /snap/core/5662 (100% used) has reached the PANIC level (95%)
red /snap/signal-desktop/93 (100% used) has reached the PANIC level (95%)
-> /etc/xymon/analysis.cfg add to HOST=* the DISK %^/snap IGNORE

inode
Thu Oct 18 11:23:09 CEST 2018 - Filesystems NOT ok
red /snap/core/5662 (100% used) has reached the PANIC level (90%)
red /snap/signal-desktop/93 (100% used) has reached the PANIC level (90%)
-> /etc/xymon/analysis.cfg add to HOST=* the INODE /snap IGNORE

misc
Thu Oct 18 11:23:10 2018 - misc NOT ok
red mount-ro returned 2:
   /dev/loop0 /snap/core/5662 squashfs ro,nodev,relatime 0 0
   /dev/loop1 /snap/signal-desktop/93 squashfs ro,nodev,relatime 0 0
-> if egrep ' ro[, ]' /proc/mounts | egrep -v '/snap/' | egrep -v ' (iso9660|nfs4?|udf|cifs|smbfs|tmpfs) ' ; then # IN /etc/xymon/misc.d/mount-ro

Tags: patch
Lenin (gagarin)
affects: xymon (Ubuntu) → hobbit-plugins (Ubuntu)
Lenin (gagarin)
description: updated
description: updated
Revision history for this message
Axel Beckert (xtaran) wrote :

disk and inode checks are from the xymon package, the misc check is indeed from hobbit-plugins.

affects: hobbit-plugins (Ubuntu) → xymon (Ubuntu)
tags: added: patch
Axel Beckert (xtaran)
Changed in hobbit-plugins (Ubuntu):
status: New → Fix Committed
Revision history for this message
Axel Beckert (xtaran) wrote :

Instead of looking at parts of the mount-point path, I implemented the exclusion in both packages by completely ignoring squashfs mounts as these are always read-only since it's a read-only file system. That way we might also catch similar cases with other container formats which also use squashfs.

Thanks for the bug report!

Changed in xymon (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hobbit-plugins - 20181101

---------------
hobbit-plugins (20181101) unstable; urgency=medium

  * libs.yaml:
    - Whitelist "/memfd:" pseudo files (used by at least pulseaudio and
      Xorg) causing false positive. Thanks Alex Myczko for the report!
    - Whitelist "/var/lib/nfs/etab". Thanks Alex Myczko for the report!
  * Declare compliance with Debian Policy 4.2.1.
    + misc.d/zombies: Use "#!/usr/bin/perl", not "#!/usr/bin/env perl".
  * Ignore squashfs mounts for misc.d/mount-ro check. (LP: #1798557)
  * Add build-dependencies on libdate-parse-perl + liblist-moreutils-perl
    to fix failing tests and FTBFS. (Closes: #912104) Thanks Adrian Bunk!
  * backuppc:
    + Refactor code to make it more readable and use modern perl features.
    + Add options for hosts which should always cause a alert or always
      only cause a warning independent of the severity of the error.

 -- Axel Beckert <email address hidden> Thu, 01 Nov 2018 00:42:55 +0100

Changed in hobbit-plugins (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xymon - 4.3.28-4

---------------
xymon (4.3.28-4) unstable; urgency=medium

  [ Axel Beckert ]
  * Update Vcs-* headers for move to Salsa.
  * Override package-contains-documentation-outside-usr-share-doc lintian
    warning for multiple cases of documentation about a directory.
  * Declare compliance with Debian Policy 4.3.0.
    + Install RELEASENOTES file as /usr/share/doc/package/NEWS.gz.
  * Reintroduce MAKEFLAGS=-j1 again as I ran into issues with parallel
    building again, but restrict it to override_dh_auto_build and the
    server's install target in override_dh_auto_install.
  * Fix URL pointing upstream mailing list posting in
    debian/xymon.lintian-overrides. It was pointing to the wrong mail.
  * Make lintian overrides for package-contains-hardlink more generic:
    + Catches future CGI script hardlinks.
    + Independent of which file is regarded as file others are linked to.
    + Reduces amount of lines needed in debian/xymon.lintian-overrides.
  * Ignore squashfs mounts when checking for disk usage. (LP: #1798557)
  * Add patch to fix old spelling errors found by new lintian.
  * Add patch to switch example in analysis.cfg(5) from FSSTND to FHS.
    Fixes lintian warning FSSTND-dir-in-manual-page.
  * Fix existence of debian/docs together with debian/xymon.docs and
    debian/xymon-client.docs by adequately merging the former into the two
    latter files. Reintroduces some upstream documentation which was
    missing for a few years.
    + Install docs/TODO only into the server package "xymon".

  [ Ondřej Nový ]
  * debian/watch: Use HTTPS.

 -- Axel Beckert <email address hidden> Tue, 19 Feb 2019 18:50:07 +0100

Changed in xymon (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.