Crash with late join in LAN
Bug #1805325 reported by
GunChleoc
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Clients can try to join a still running game again after a desync, resulting in a server crash. We don't support late joins yet, so the client shouldn't join at all.
Related branches
lp:~widelands-dev/widelands/bug-1805325-joining-lan-games
- GunChleoc: Approve (code)
-
Diff: 86 lines (+24/-8)3 files modifiedsrc/network/gamehost.cc (+13/-1)
src/network/nethost.h (+5/-6)
src/ui_fsmenu/netsetup_lan.cc (+6/-1)
Revision history for this message
| Notabilis (notabilis27) wrote | #1 |
| Changed in widelands: | |
| assignee: | nobody → Notabilis (notabilis27) |
| status: | New → Confirmed |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| assignee: | Notabilis (notabilis27) → nobody |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I can confirm the crash even without a desync. Just starting a LAN game and trying to join the running game is enough to crash the server.