please add smbios module to the signed grub2 images

Alternative measures avoiding using this module, would be to attempt a kexec from initrd to the right kernel flavour. Which may increase boot time a little bit, but should otherwise allow similar levels of detection.

Note that signed kexec is available these days.

Hi,

I've given this module a quick review - it looks ok for including in the EFI image. I only have one small note on the while loop in grub_smbios_match_structure, which I made because I thought it looked a bit suspicious:

  while (ptr < table_end
         && ptr[1] >= 4 /* Valid structures include the 4-byte header. */
         && (structure_count++ < structures || structures == 0))
    {
      grub_uint16_t structure_handle = grub_get_unaligned16 (ptr + 2);

... the "ptr < table_end" condition isn't completely sufficient to prevent reads beyond table_end because it reads the size field (ptr[1] >= 4) and the handle (grub_get_unaligned (ptr + 2)) even when this condition is true. But I don't think there's a real issue here as it would require a broken smbios implementation to end up in the situation where ptr is close enough to table_end to cause a read beyond the end of it inside the loop.

This bug was fixed in the package grub2 - 2.04-1ubuntu20

---------------
grub2 (2.04-1ubuntu20) focal; urgency=medium

  * build-efi-images: do not produce -installer.efi.signed. LP: #1863994

grub2 (2.04-1ubuntu19) focal; urgency=medium

  * uefi-firmware: rename fwsetup menuentry to UEFI Firmware Settings
    (LP: #1864547)
  * build-efi-images: add smbios module to the prebuilt signed EFI images
    (LP: #1856424)

 -- Dimitri John Ledkov <email address hidden> Tue, 25 Feb 2020 01:11:31 +0000

Hi,

I'm a beginner in GRUB2 and for my use i need to have BIOS information to test the model of hardware i'm uses and fix kernel parameters.

I'm working on Debian Jessie. I have downloaded latest sources of GRUB (2.04) and install it correctly. But smbios module is not present, how can i include smbios.mod sources ?

Thanks for your help.

Greatings
F. TOURRET

On Thu, 4 Jun 2020, 10:21 Frédéric TOURRET, <email address hidden>
wrote:

> Hi,
>
> I'm a beginner in GRUB2 and for my use i need to have BIOS information
> to test the model of hardware i'm uses and fix kernel parameters.
>
> I'm working on Debian Jessie. I have downloaded latest sources of GRUB
> (2.04) and install it correctly. But smbios module is not present, how
> can i include smbios.mod sources ?
>
> Thanks for your help.
>

It is included in Ubuntu, so please switch and use Ubuntu.

This bug report is specific to Ubuntu distribution, and the grub that
ubuntu ships, with ubuntu patches. And it is not appropriate to enquire
about upstream grub development.

Grub upstream development is at https://www.gnu.org/software/grub/ you will
find mailing lists there that can help you with upstream grub sources.

For example, did you try building grub form upstream git master?

Please join grub upstream mailing lists to enquire about upstream grub
development or upstream support further.

Regards,

Dimitri.

Hi,

I am following the above thread. I applied the above patch to add the smbios module on grub 2.04. But even after patch is applied I am not able to get the module on my grub.

This exercise I did on yocto dunfell.

Can anyone suggest, DO/How we can install this on grub? or what extra we need to do to access this on my grub 2.04.

Thanks in advance.
Nikhil Sahu