lrmd crashes

Bug #1871166 reported by Dan Streetman
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pacemaker (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Fix Released
Medium
Dan Streetman

Bug Description

[impact]

lrmd crashes and dumps core.

[test case]

I can not reproduce, but it is reproducable in the specific setup of the person reporting the bug to me.

[regression potential]

this patches the cancel/cleanup part of the code, so regressions would likely involve possible memory leaks (instead of use-after-free segfaults), failure to correctly cancel or cleanup operations, or other failure during cancel action.

[scope]

this is fixed by commits:
933d46ef20591757301784773a37e06b78906584
94a4c58f675d163085a055f59fd6c3a2c9f57c43
dc36d4375c049024a6f9e4d2277a3e6444fad05b
deabcc5a6aa93dadf0b20364715b559a5b9848ac
b85037b75255061a41d0ec3fd9b64f271351b43e

which are all included starting with version 1.1.17, and Bionic includes version 1.1.18, so this is fixed already in Bionic and later.

This is needed only for Xenial.

[other info]

As mentioned in the test case section, I do not have a setup where I'm able to reproduce this, but I can ask the initial reporter to test and verify the fix, and they have verified a test build fixed the problem for them.

Also, the upstream commits removed two symbols, which I elided from the backported patches; those symbols are still available and, while it is unlikely there were any users of those symbols outside pacemaker itself, this change should not break any possible external users. See patch 0002 header in the upload for more detail.

Dan Streetman (ddstreet)
description: updated
Changed in pacemaker (Ubuntu Xenial):
status: New → In Progress
assignee: nobody → Dan Streetman (ddstreet)
importance: Undecided → Medium
Changed in pacemaker (Ubuntu):
status: New → Fix Released
Dan Streetman (ddstreet)
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This looks good, though this is quite a lot of code changes (and refactoring) for a bug without a clear reproduction scenario. Would it be possible to, along with the verification to be done by the reporting person, perform some sanity runs to make sure the cancel/cleanup parts of the code did not regress? Thanks!

Changed in pacemaker (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted pacemaker into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pacemaker/1.1.14-2ubuntu1.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Mathew Hodson (mhodson)
Changed in pacemaker (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Dan Streetman (ddstreet) wrote :

Status update - still waiting on original reporter to perform testing with -proposed package.

Revision history for this message
Dan Streetman (ddstreet) wrote :

The original reporter has performed testing and verified that the original crash no longer happens with the package in proposed, so I am marking this as verified.

Please note that a *new* crash has been reported, and is being worked in bug 1877280. It is *not* a regression caused by the patches from this bug; the fixes in this bug simply allowed the code to proceed further and, in some cases, crash at a later point, which is fixed by patches included in the new bug.

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pacemaker - 1.1.14-2ubuntu1.7

---------------
pacemaker (1.1.14-2ubuntu1.7) xenial; urgency=medium

  [ Victor Tapia ]
  * d/p/lp1871166/0001-Fix-libservices-prevent-use-after-free-when-freeing-.patch,
    d/p/lp1871166/0002-Fix-libservices-ensure-completed-ops-aren-t-on-block.patch,
    d/p/lp1871166/0003-Refactor-libservices-handle-in-flight-case-first-whe.patch,
    d/p/lp1871166/0004-Fix-libservices-properly-cancel-in-flight-systemd-up.patch,
    d/p/lp1871166/0005-Fix-libservices-properly-detect-in-flight-systemd-up.patch:
    - prevent use-after-free segfault (LP: #1871166)

 -- Dan Streetman <email address hidden> Mon, 06 Apr 2020 13:37:40 -0400

Changed in pacemaker (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for pacemaker has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.