SRU 3.36.6

Bug #1896334 reported by Marco Trevisan (Treviño)
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Focal
Fix Released
Medium
Marco Trevisan (Treviño)
yaru-theme (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Focal
Fix Released
Medium
Marco Trevisan (Treviño)

Bug Description

[ Impact ]

That's the current GNOME stable update, including some fixes and translation updates
https://gitlab.gnome.org/GNOME/gnome-shell/-/commits/3.36.6

Since the theme side of the project in ubuntu is shipped via Yaru theme, that project is included in the SRU.

The changes involving yaru here are ONLY gnome-shell upstream changes applied to the Yaru sources, as per this we can consider them also part of the GNOME release.
In fact:
- Ubuntu's GNOME shell uses a Yaru theme based on upstream
  gnome-shell This theme basically takes the shell's data/ directory,
  applies some diffs and generates a gresource file out of it, that it's
  then loaded on startup (in place of the upstream one).
- GNOME Shell applied some fixes to the theme (se its data/
  directory diffs)
- In order to get those fixes in Ubuntu main session we have to sync
  the upstream changes applied to such dir to yaru's src/gnome-shell
  path
- You can easily compare the diffs applied there to match the ones
  happening in its upstream counterpart.

The yaru-theme's `gnome-shell/upstream` directory is just for documentation and
to allow three way merges when updating to new versions of gnome-shell,
and it is not used for generating the final packages at all

[ Test case ]

The update is part of GNOME stable updates
https://wiki.ubuntu.com/StableReleaseUpdates/GNOME

GNOME Shell and its components should continue working

[ Regression potential ]

There have been fixes in popup-grab handling, gdm view fixes, lockscreen display changes in some hw, extensions updates

CVE References

summary: - Update to 3.36.6 and SRU it
+ SRU 3.36.6
Changed in yaru-theme (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in gnome-shell (Ubuntu Focal):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → Medium
status: New → In Progress
Changed in yaru-theme (Ubuntu Focal):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Undecided → Medium
status: New → In Progress
description: updated
description: updated
Revision history for this message
Robie Basak (racb) wrote :

On gnome-shell, we now understand there are complications with API breakage in microreleases, so we need a plan for reverse dependency shell extensions to mitigate potential regressions. Discussion at https://discourse.ubuntu.com/t/scope-of-gnome-mru/18041. I don't think we can proceed with the gnome-shell microrelease update until we have a plan for this.

I don't think it makes sense to proceed with yaru-theme either until this is resolved, since I understand that's based on the gnome-shell update that is not concluded yet.

I don't understand why yaru-theme needs to be updated, either. I see that this has been done for yaru-theme once before, but I've found no explanation as to why. The current queue diff has:

diff --git a/debian/README.source b/debian/README.source
new file mode 100644
index 0000000..84c9d3c
--- /dev/null
+++ b/debian/README.source
@@ -0,0 +1,3 @@
+The `gnome-shell/upstream` directory is just for documentation and
+to allow three way merges when updating to new versions of gnome-shell,
+and it is not used for generating the final packages at all

If this isn't used for generating the final packages at all, why do you propose to make users download an update?

Changed in yaru-theme (Ubuntu Focal):
status: In Progress → Incomplete
Changed in gnome-shell (Ubuntu Focal):
status: In Progress → Incomplete
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Re: [Bug 1896334] Re: SRU 3.36.6

> I don't understand why yaru-theme needs to be updated, either. I see
> that this has been done for yaru-theme once before, but I've found no
> explanation as to why.

I will make it clearer in the top post, but it should be quite easy to
spot looking at the shell's (data subdir) and yaru diffs:

- Ubuntu's GNOME shell uses a Yaru theme based on upstream
  gnome-shell This theme basically takes the shell's data/ directory,
  applies some diffs and generates a gresource file out of it, that it's
  then loaded on startup (in place of the upstream one).
- GNOME Shell applied some fixes to the theme (se its data/
  directory diffs)
- In order to get those fixes in Ubuntu main session we have to sync
  the upstream changes applied to such dir to yaru's src/gnome-shell
  path
- You can easily compare the diffs applied there to match the ones
  happening in its upstream counterpart.

description: updated
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ah about this:

> If this isn't used for generating the final packages at all, why do you propose to make users download an update?

Those files aren't included at all into the package, the README.sources there was included to explain why we have such files, even though they are not built.

It's just inside an orig file for diff purposes, nothing more.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

While the gnome-shell reverse dependency shell extensions regression mitigation discussion is still in progress, I think we can unblock the yaru-theme portion as it's unrelated to this. I have been told this update is safe to go in without the gnome-shell part, and is needed for some future fixes.

Changed in yaru-theme (Ubuntu Focal):
status: Incomplete → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Marco, or anyone else affected,

Accepted yaru-theme into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yaru-theme/20.04.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Sebastien Bacher (seb128) wrote :

The 20.04.10.1 theme update works without noticable issue on the shell while confirming the fixes from the other bug so marking as verified

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 20.04.10.1

---------------
yaru-theme (20.04.10.1) focal; urgency=medium

  [ Feichtmeier ]
  * Focal Gtk3: sync button shadows with groovy.
    Reduce button shadow in all states by 0.05

yaru-theme (20.04.10) focal; urgency=medium

  [ Feichtmeier ]
  * Sync gtk3 button metrics with upstream & groovy (LP: #1899731)
    - in groovy we moved away from altering the upstream button sizes, because
      those sizes are sometimes hardcoded in gtk apps, which ends in
      inconsistent button sizes in the desktop (slim beneath big, or vice versa)
      and because it can cause newer gtk3 apps to have a stretched headerbar
    - additionally because gtk-common-themes will receive the updated yaru
      version from groovy this change destroys the chance gtk3 snaps using
      yaru have different button sizes than gtk3 debs using yaru

yaru-theme (20.04.9) focal; urgency=medium

  * debian: Update gbp.conf and control references to ubuntu/focal branch
  * debian/README.sources: add documentation to explain gnome-shell/upstream
  * gnome-shell, Sync with 3.36.6 fixes (LP: #1896334):
    - Use proper path for upstream files
    - Sync with upstream 3.36 branch
    - Sync yaru theme with upstream 3.36.6
    - Sync yaru gresource with gnome 3.36.6
    - Make world clock times tabular

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 05 Nov 2020 16:08:58 +0100

Changed in yaru-theme (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for yaru-theme has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

Please proceed with the gnome-shell SRU, version 3.36.7 is already out LP: #1903764.

Changed in yaru-theme (Ubuntu):
status: In Progress → Fix Released
summary: - SRU 3.36.6
+ SRU 3.36.6/3.36.7
Changed in gnome-shell (Ubuntu Focal):
status: Incomplete → In Progress
Changed in gnome-shell (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Marco, or anyone else affected,

Accepted gnome-shell into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.36.7-0ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-shell (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
removed: verification-done verification-done-focal
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It seems bug 1903764 is tracking 3.36.7 now. And the changelog in proposed mentions this bug in the update to 3.36.6 that precedes it. But really they're both the same update now -- to 3.36.7.

summary: - SRU 3.36.6/3.36.7
+ SRU 3.36.6
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

I have gnome-shell 3.36.7-0ubuntu0.20.04.1 installed from focal-proposed for three weeks now and my two-monitor setup is working great.

I also have the gnome-shell-extensions-gpaste (from Ubuntu universe) and the gsconnect extension (from https://extensions.gnome.org/extension/1319/gsconnect/) installed and running without any problems.

tags: added: verification-done-focal
removed: verification-needed verification-needed-focal
Mathew Hodson (mhodson)
Changed in gnome-shell (Ubuntu):
status: Invalid → Fix Released
tags: added: upgrade-software-version
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.36.7-0ubuntu0.20.04.1

---------------
gnome-shell (3.36.7-0ubuntu0.20.04.1) focal; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * New upstream release (LP: #1903764)
    - Fix potential stack overflow in libcroco
    - Fix system action search regressions
    - Fix week number alignment when using font-scaling
    - Misc. bug fixes and cleanups
  * debian/patches:
    - Refresh
    - Handle screenshot failures gracefully (LP: #1908187)

  [ Matthew Ruffell ]
  * authPrompt-Properly-get-oVirt-service-name.patch,
    authPrompt-set-value-of-beginRequestType-to-DONT_PROVIDE_.patch,
    gdm-Introduce-vmware-credential-manager-for-pre-authentic.patch,
    gdm-Refactor-oVirt-to-a-generic-CredentialManager-interfa.patch:
    - Enable support for VMware Horizon SSO to ensure compatibility
      with the Horizon Agent (LP: #1886592)

gnome-shell (3.36.6-1ubuntu0.20.04.1) focal; urgency=medium

  * Merge with debian, containing new stable release (LP: #1896334)
  * debian/patches: Refresh, drop merged CVE-2020-17489.patch

gnome-shell (3.36.6-1) unstable; urgency=medium

  * Team upload

  * New upstream release

gnome-shell (3.36.5-1) unstable; urgency=medium

  * Team upload
  * New upstream release
    - Fix password briefly showing on login dialog during logout if it
      was previously made visible (CVE-2020-17489, Closes: #968311)
  * Drop most patches, applied upstream

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 15 Dec 2020 05:54:44 +0100

Changed in gnome-shell (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.