glib2.0 >=2.67.3 breaks include from an extern C context

Also caused FTBFS in ukui-control-center

https://launchpadlibrarian.net/524640709/buildlog_ubuntu-hirsute-amd64.ukui-control-center_3.0.2-2_BUILDING.txt.gz

I'm going to close this bug in the 2.67.5-1 upload which I'm just making to experimental. There will still be "some" projects still affected, but it's as fixed as it's going to get from glib2.0's side - we made the API break opt in for packages that have followed glib's longstanding advice and defined the MAX_ALLOWED/MIN_REQUIRED macros.

Affected projects can do either (but should do both) of these.

  - Define GLIB_VERSION_MAX_ALLOWED to something below GLIB_VERISON_2_66 to opt out or _2_68 to opt in to this new typesafe behaviour.
  - Not include glib's headers in an 'extern "C"' context. GLib has G_{BEGIN,END}_DECLS that might help with this.

glib2.0 (2.67.5-1) experimental; urgency=medium

This bug was fixed in the package glib2.0 - 2.67.5-2

---------------
glib2.0 (2.67.5-2) experimental; urgency=medium

  * debian/tests/control: Build-Depend on libc6-dev; the `pollable` test
    requires it. See [upstream MR !1977][0]. The upstream tests now rely on
    finding "libutil.so", which is in libc6-dev. Once that MR, or something
    like it, is merged, we can remove this test-dep as the runtime library
    will be being used.
    [0]: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1977

 -- Iain Lane <email address hidden> Tue, 02 Mar 2021 18:29:23 +0000

Thanks Iain for the Fixes in glib.
I need to sort out how to adopt that in qemu for now ...

Also open-vm-tools is also FTBFS by this, so I need to add a task and work on that as well.

This bug was fixed in the package qemu - 1:5.2+dfsg-6ubuntu2

---------------
qemu (1:5.2+dfsg-6ubuntu2) hirsute; urgency=medium

  * d/p/u/lp-1916705-disas-Fix-build-with-glib2.0-2.67.3.patch: Fix FTFBS due
    to glib2.0 >=2.67.3 (LP: #1916705)

qemu (1:5.2+dfsg-6ubuntu1) hirsute; urgency=medium

  * Merge with Debian unstable, includes fixes for
    - build operates differently if source is a git repo (LP: #1887535)
    Remaining changes:
    - qemu-kvm to systemd unit
      - d/qemu-kvm-init: script for QEMU KVM preparation modules, ksm,
        hugepages and architecture specifics
      - d/qemu-system-common.qemu-kvm.service: systemd unit to call
        qemu-kvm-init
      - d/qemu-system-common.install: install helper script
      - d/qemu-system-common.qemu-kvm.default: defaults for
        /etc/default/qemu-kvm
      - d/rules: call dh_installinit and dh_installsystemd for qemu-kvm
    - Distribution specific machine type (LP: 1304107 1621042)
      - d/p/ubuntu/define-ubuntu-machine-types.patch: distro machine types
      - d/qemu-system-x86.NEWS Info on fixed machine type definitions
        for host-phys-bits=true (LP: 1776189)
      - add an info about -hpb machine type in debian/qemu-system-x86.NEWS
      - provide pseries-bionic-2.11-sxxm type as convenience with all
        meltdown/spectre workarounds enabled by default. (LP: 1761372).
      - ubuntu-q35 alias added to auto-select the most recent q35 ubuntu type
    - Enable nesting by default
      - d/p/ubuntu/enable-svm-by-default.patch: Enable nested svm by default
        in qemu64 on amd
        [ No more strictly needed, but required for backward compatibility ]
    - improved dependencies
      - Make qemu-system-common depend on qemu-block-extra
      - Make qemu-utils depend on qemu-block-extra
      - let qemu-utils recommend sharutils
    - tolerate ipxe size change on migrations to >=18.04 (LP: 1713490)
      - d/p/ubuntu/pre-bionic-256k-ipxe-efi-roms.patch: old machine types
        reference 256k path
      - d/control-in: depend on ipxe-qemu-256k-compat-efi-roms to be able to
        handle incoming migrations from former releases.
    - d/control-in: Disable capstone disassembler library support (universe)
    - d/qemu-system-x86.README.Debian: add info about updated nesting changes
    - d/control*, d/rules: disable xen by default, but provide universe
      package qemu-system-x86-xen as alternative
      [includes compat links changes of 5.0-5ubuntu4]
    - allow qemu to load old modules post upgrade (LP 1847361)
      - Drop d/qemu-block-extra.*.in, d/qemu-system-gui.*.in
      - d/rules: Drop generating package version into maintainer scripts
      - d/qemu-system-gui.prerm: add no-op prerm to overcome upgrade issues on
        the bad old prerm (LP 1906245 1905377)
    - d/p/ubuntu/lp-1907789-build-no-pie-is-no-functional-liker-flag.patch: fix
      ld usage of -no-pie (LP 1907789)
  * Added changes
    - d/p/u/lp-1916230-hw-s390x-fix-build-for-virtio-9p-ccw.patch: fix
      virtio-9p-ccw being missing (LP: #1916230)

qemu (1:5.2+dfsg-6) unstable; urgency=medium

  * deprecate qemu-debootstrap. It is not needed anymore with
    binfmt F flag, since eve...

> Also open-vm-tools is also FTBFS by this, so I need to add a task and work on that as well.

You want this kind of thing minimally to get over the FTBFS:

--- open-vm-tools-11.2.5.orig/open-vm-tools/configure.ac
+++ open-vm-tools-11.2.5/open-vm-tools/configure.ac
@@ -503,6 +503,9 @@ AC_CHECK_PROG([have_genmarshal],
               [yes],
               [no])

+AC_DEFINE(GLIB_VERSION_MIN_REQUIRED, GLIB_VERSION_2_34, [Ignore post 2.34 deprecations])
+AC_DEFINE(GLIB_VERSION_MAX_ALLOWED, GLIB_VERSION_2_34, [Prevent post 2.34 APIs])
+
 if test "$have_genmarshal" != "yes"; then
    AC_MSG_ERROR([glib-genmarshal is required; make sure it is available in your path.])
 fi

But I would recommend also at least asking upstream to do the full fix and move glib's headers out of 'extern "C"' too as outlined in comment #2 here.

Forwarded to upstream open-vm-tools as https://github.com/vmware/open-vm-tools/issues/500
Uploaded a fix for Ubuntu in https://launchpad.net/ubuntu/+source/open-vm-tools/2:11.2.5-2ubuntu1

for wireshark the problem can be worked around with this:

diff -up wireshark-3.4.3/debian/rules.orig wireshark-3.4.3/debian/rules
--- wireshark-3.4.3/debian/rules.orig 2021-03-09 10:09:58.184967210 +0100
+++ wireshark-3.4.3/debian/rules 2021-03-09 09:58:39.497405512 +0100
@@ -31,7 +31,8 @@ override_dh_auto_configure-indep:

 override_dh_auto_configure-arch:
  echo "#define VCSVERSION \"$(GIT_VERSION)\"" > version.h
- dh_auto_configure
+ dh_auto_configure -- -DCMAKE_CXX_FLAGS="-DGLIB_VERSION_MIN_REQUIRED=0x024200" \
+ -DCMAKE_C_FLAGS="-DGLIB_VERSION_MIN_REQUIRED=0x024200"

 override_dh_auto_build-arch:
  # regenerate ASN.1 dissectors

Status changed to 'Confirmed' because the bug affects multiple users.

This bug was fixed in the package wireshark - 3.4.4-1ubuntu1

---------------
wireshark (3.4.4-1ubuntu1) hirsute; urgency=medium

  * Cherrypick upstream commit for SMCD(v2) support LP: #1887933
  * Ensure glib includes are outside extern "C" blocks. LP: #1916705

wireshark (3.4.4-1) unstable; urgency=medium

  * New upstream version 3.4.4
    - security fixes:
      - Wireshark could open unsafe URLs. (CVE-2021-22191)

 -- Dimitri John Ledkov <email address hidden> Mon, 15 Mar 2021 17:01:52 +0000

open-vm-tools fixed in

open-vm-tools (2:11.2.5-2ubuntu1) hirsute; urgency=medium

   * d/p/fix-FTFBS-glib2.0-2.66.3.patch: fix FTBFS with glib2.0 >=2.66.3

-- Christian Ehrhardt <email address hidden> Mon, 08 Mar 2021 12:12:35 +0100

This bug was fixed in the package ukui-control-center - 3.0.2-2ubuntu1

---------------
ukui-control-center (3.0.2-2ubuntu1) hirsute; urgency=medium

  * Build with -DGLIB_VERSION_MIN_REQUIRED=0x024200 to fix ftbfs with glib2.0.
    LP: #1916705.

 -- Matthias Klose <email address hidden> Thu, 08 Apr 2021 10:02:52 +0200