[SRU] Backport xrt 202020.2.8.743-0ubuntu1 to focal

Bug #1943564 reported by Alfonso Sanchez-Beato
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xrt (Ubuntu)
New
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

Some problems have been detected in the xrt package that need to be fixed: a missing configuration file (LP: #1939613) and a problem with reading the AIE counter that has been fixed upstream. Additionally, the packages for amd64 are not really tested and won't be, so it is preferable to remove from the build.

[Test Plan]

To test, install the xrt package on a ZCU or Kria platform. The command
$ sudo xbutil scan
should detect a valid card in the system.
Also, the file "/etc/OpenCL/vendor/xilinx.icd" should exist now.

[Where problems could occur]

There is some potential for regression, although the changes are minor. The package will disappear from amd64 arch, but anyway it was not really working and it is preferable to remove it rather than leaving people with a not working binary around.

[Other Info]

Xilinx expects to have their own package feed for xrt/amd64, so there will be an alternative for that arch quite soon.

Revision history for this message
Robie Basak (racb) wrote :

Please can you explain why you're backporting rather than cherry-picking specific fixes here? If the diff is otherwise equivalent, why aren't you still intending to individually verify the specific fixes you need, as would be normal SRU process?

If you don't intend to verify each fix individually, then please explain how the package complies with the requirements listed at https://wiki.ubuntu.com/StableReleaseUpdates#New_upstream_microreleases

> Additionally, the packages for amd64 are not really tested and won't be, so it is preferable to remove from the build.

This is not sufficient justification to remove a build from a stable Ubuntu release. Many packages in Ubuntu aren't specifically tested, and we don't routinely remove those.

> The package will disappear from amd64 arch, but anyway it was not really working and it is preferable to remove it rather than leaving people with a not working binary around.

Is it not working at all, or not "really" working but still effective for some user? In what way doesn't it work?

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The xrt package has been added quite recently to all series explicitly for the need of enabling the Xilinx platforms for Ubuntu, so it's use is explicitly limited to this usage. So there is no actual risk of regressing any users, or breaking user expectations.

The addition of the amd64 binaries was an accident in the first place and, as mentioned, there is no actual use case for having those around - not to mention the fact that upstream seemed very unhappy that the amd64 binaries have been published. So basically the amd64 binaries here are actually a bug that we should strive to fix, regardless if it means removing packages.

So I'm +1 on getting the amd64 arch removed. Also, since this is an HWE related update, I would consider this a rather special case for pulling in new upstream releases. It's not ideal, but since this is all for the enablement efforts, I would say we should consider taking the backport as-is.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Alfonso, or anyone else affected,

Accepted xrt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xrt/202020.2.8.743-0ubuntu1~20.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in xrt (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Tony McDowell (tmcdowe) wrote :

I verified this. I had a little bit of trouble getting focal-proposed working but once I did I was able to update xrt-embedded and I saw everything work properly from there. I saw the Xilinx platform ICD in the proper location and clinfo began showing the platform IDs properly.

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Tony could you please change the tag from verification-needed-focal to verification-done-focal? Also it would be good if you paste the output of "apt policy xrt" on your testing device, to make sure the version tested is the right one.

Revision history for this message
Tony McDowell (tmcdowe) wrote :

Hi @Alfonso - how do I change it? I don't see see/understand how. Let me know and I'll fix it.

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Search for "Tags:", it is right under the bug description.

Tony McDowell (tmcdowe)
tags: added: verification-done-focal
removed: verification-needed verification-needed-focal
tags: added: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xrt - 202020.2.8.743-0ubuntu1~20.04

---------------
xrt (202020.2.8.743-0ubuntu1~20.04) focal; urgency=medium

  * SRU to focal (LP: #1943564).

xrt (202020.2.8.743-0ubuntu1) impish; urgency=medium

  * Update to 202020.2.8.743 tag upstream (fixex issue with reading AIE
    counter)
  * Add OpenCL configuration file (LP: #1939613)
  * Fix FTBFS with latest impish gcc
  * Restrict build to arm64 only

 -- Łukasz 'sil2100' Zemczak <email address hidden> Tue, 14 Sep 2021 12:38:42 +0200

Changed in xrt (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for xrt has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

...and the old arm64 binaries have been now removed.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Of course I meant amd64, not arm64!

Revision history for this message
Terry ONeal (terryoneal3) wrote :

Hi Łukasz - Still see the amd64 packages here: https://packages.ubuntu.com/search?suite=hirsute&arch=amd64&searchon=names&keywords=xrt

Can these be removed as well?

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I suppose this would require someone preparing an arch-restricting SRU for xrt for hirsute! Could someone get that prepared and uploaded so that I can review+accept? I can then remove the amd64 binaries.
That being said, hirsute is a bit more tricky, because the hirsute *release* pocket has xrt built for amd64 - and this is immutable. Once we release an Ubuntu series, packages that are in the release pocket are set to stone and cannot be removed. So we can remove the amd64 binaries from hirsute-updates, which should mask the availability, but basically the release pocket (so hirsute without -updates) will always have these binaries...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.