Update to 1.21-0ubuntu1~18.04 FTBFSes libvirt in-release

Bug #1951438 reported by Christian Ehrhardt 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dwarves-dfsg (Ubuntu)
Invalid
Undecided
Unassigned
Bionic
Won't Fix
Undecided
Unassigned
libvirt (Ubuntu)
Invalid
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

SRU-Template for a libvirt upload to this bug

[Impact]

 * The SRU of the new dwarves made libvirt an FTBFS
   due to changed behavior of pdwtags

 * The change in libvirt will continue to ignore pdwtags
   as it did before to match former builds.

[Test Plan]

 * Has to build successfully again

 * This has no other impact as we really make
   it "as it was" before dwarves changed. Nevertheless we will
   do a general regression test once in -proposed

[Where problems could occur]

 * As I said this makes the changes in dwarves a no-op, thereby
   no changes are expected. Therefore I can't point to a specific
   area and will test generically.

[Other Info]

 * n/a

---

Hi,
I faced an regression-in-release breaking libvirt builds in Bionic.
I found this to be related to the recent release of https://launchpad.net/ubuntu/+source/dwarves-dfsg/1.21-0ubuntu1~18.04

It is locally reproducible in sbuild if you build it in bionic right now.
It will break checking some structs.

Example:
(bionic-amd64)root@Keschdeichel:/build/libvirt-OfdbiS/libvirt-4.0.0/debian/build/src# make V=1 check-local
...
 enum remote_auth_type {
- REMOTE_AUTH_NONE = 0,
- REMOTE_AUTH_SASL = 1,
+ REMOTE_AUTH_NONE = 0,
+ REMOTE_AUTH_SASL = 1,
         REMOTE_AUTH_POLKIT = 2,
 };

There are much more, but all of them just differ in whitespace.
As if some tool was updated now breaking all the tests while the content that
matters is actually fine.

One element of this comparison lives in the source
like src/remote_protocol-structs which has:
enum remote_auth_type {
        REMOTE_AUTH_NONE = 0,
        REMOTE_AUTH_SASL = 1,
        REMOTE_AUTH_POLKIT = 2,
};

But the generated content was changed to be aligned.

I found this to use pdwtags from dwarves which is

# apt-cache policy dwarves
dwarves:
  Installed: 1.21-0ubuntu1~18.04
  Candidate: 1.21-0ubuntu1~18.04
  Version table:
 *** 1.21-0ubuntu1~18.04 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     1.10-2.1build1 500
        500 http://archive.ubuntu.com/ubuntu bionic/universe amd64 Packages

Going back to the release version
$ apt install dwarves=1.10-2.1build1
=> fixes the FTBFS.

Formerly the too old pdwtags was detected as broken in libvirt.
But the new one is accepted and fails as the output mismatches.

Old:
(bionic-amd64)root@Keschdeichel:/build/libvirt-OfdbiS/libvirt-4.0.0/debian/build/src# /usr/bin/pdwtags.1.10-2.1build1 --verbose remote/.libs/libvirt_driver_remote_la-remote_protocol.o | grep -A5 '^enum remote_auth_type'
die__process_unit: DW_TAG_restrict_type (0x37) @ <0x228> not handled!

New:
(bionic-amd64)root@Keschdeichel:/build/libvirt-OfdbiS/libvirt-4.0.0/debian/build/src# /usr/bin/pdwtags.1.21-0ubuntu1~18.04 --verbose remote/.libs/libvirt_driver_remote_la-remote_protocol.o | grep -A5 '^enum remote_auth_type'
enum remote_auth_type {
 REMOTE_AUTH_NONE = 0,
 REMOTE_AUTH_SASL = 1,
 REMOTE_AUTH_POLKIT = 2,
}; /* size: 4 */

Other use cases had valid output before, but now ware aligned - they might face similar FTFBS issues now.

For libvirt I might fix the expected result or skip the test (as it always was skipped).

But this update of dwarves has the potential to break much more users of it since not
only the functionality but even the output style has changed by this update.

Related branches

Changed in libvirt (Ubuntu):
status: New → Invalid
Changed in libvirt (Ubuntu Bionic):
status: New → In Progress
tags: added: regression-update
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI - tested and uploaded the libvirt fix along the SRU upload for bug 1927519.
This bug will need an SRU template for that as well, adding it now.

description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Christian, or anyone else affected,

Accepted libvirt into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/4.0.0-1ubuntu8.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libvirt (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

https://launchpad.net/ubuntu/+source/libvirt/4.0.0-1ubuntu8.20 builds fine now, for this bug that is all the verification we planned, more in bug 1927519

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 4.0.0-1ubuntu8.20

---------------
libvirt (4.0.0-1ubuntu8.20) bionic; urgency=medium

  * d/p/u/lp-1927519-virt-aa-helper-Purge-profile-if-corrupted.patch:
    avoid issues due to corrupted apparmor profiles (LP: #1927519)
  * d/p/u/skip-new-pdwtags.patch: avoid issues with backported
    dwarves 1.21 (LP: #1951438)

 -- Christian Ehrhardt <email address hidden> Thu, 18 Nov 2021 10:24:01 +0100

Changed in libvirt (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for libvirt has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

thank you for embracing the future.

Changed in dwarves-dfsg (Ubuntu Bionic):
status: New → Won't Fix
Changed in dwarves-dfsg (Ubuntu):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.