r8168 dkms fails to build on kinetic 5.19 kernel

Bug #1982000 reported by Andrea Righi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
r8168 (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

r8168 dkms fails to build on the latest 5.19 kernel with the following error:

/var/lib/dkms/r8168/8.050.03/build/r8168_n.c: In function ‘rtl8168_init_one’:
/var/lib/dkms/r8168/8.050.03/build/r8168_n.c:26907:25: error: implicit declaration of function ‘netif_set_gso_max_size’; did you mean ‘netif_set_tso_max_size’? [-Werror=implicit-function-declaration]
26907 | netif_set_gso_max_size(dev, LSO_32K);
      | ^~~~~~~~~~~~~~~~~~~~~~
      | netif_set_tso_max_size

[Test case]

$ sudo apt install r816-dkms

[Fix]

Make netif_set_gso_max_size() available again to external modules (as a static inline func).

[Regression potential]

We may see regressions in this driver with kernels >= 5.19.

Revision history for this message
Andrea Righi (arighi) wrote :

Fix (debdiff) to support kernel 5.19 in attach.

description: updated
tags: added: patch
Changed in r8168 (Ubuntu Kinetic):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package r8168 - 8.050.03-1ubuntu1

---------------
r8168 (8.050.03-1ubuntu1) kinetic; urgency=medium

  * Support linux 5.19 (LP: #1982000):
    - debian/patches/linux-5.19.patch

 -- Andrea Righi <email address hidden> Mon, 18 Jul 2022 14:36:30 +0000

Changed in r8168 (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Andrea Righi (arighi) wrote :

debdiff in attach allows to support linux hwe 5.19 in jammy.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

changed the version to -1ubuntu1.1 instead to make it clear it's an SRU, but this is nitpick-category ;)

(and uploaded)

Changed in r8168 (Ubuntu Jammy):
status: New → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted r8168 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/r8168/8.049.02-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in r8168 (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Performed only build tests due to lack of hardware for better testing.

Build test with hwe-5.19 kernel:

=========================================================

Setting up r8168-dkms (8.049.02-1ubuntu1.1) ...
Loading new r8168-8.049.02 DKMS files...
Building for 5.19.0-32-generic
Building initial module for 5.19.0-32-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

=========================================================

Build test with generic 5.15 kernel:

=========================================================

Setting up r8168-dkms (8.049.02-1ubuntu1.1) ...
Loading new r8168-8.049.02 DKMS files...
Building for 5.15.0-60-generic 5.19.0-32-generic
Building initial module for 5.15.0-60-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

=========================================================

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package r8168 - 8.049.02-1ubuntu1.1

---------------
r8168 (8.049.02-1ubuntu1.1) jammy; urgency=medium

  * Support linux 5.19 (LP: #1982000):
    - d/p/linux-5.18.patch
    - d/p/linux-5.19.patch

 -- Andrea Righi <email address hidden> Wed, 18 Jan 2023 07:48:53 +0000

Changed in r8168 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for r8168 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.