FF exception request: update hal to git head

Bug #198295 reported by Martin Pitt
4
Affects Status Importance Assigned to Milestone
hal (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: hal

hal did not get a new upstream release for about half a year, so we piled up lots of patches and are missing 5 months worth of upstream fixes (who has been very active). Thus Debian and us started to package a git head snapshot.

Just today David Zeuthen (main upstream) confirmed that it is time for 0.5.11: http://lists.freedesktop.org/archives/hal/2008-March/010975.html, so if we get our git snapshot into Hardy now, then there is a good chance to get in 0.5.11 without much pain, since it will only be a couple of fixes.

I attach the relevant part of the upstream changelog, which has ~ 100 fixes, many of them highly relevant for Ubuntu. There is only three commits which we didn't have as patch yet and which can be considered features:

commit 3831b5b4076d0a1dcfa7bfec5e67b6e727d69c92
Author: Holger Macht <email address hidden>
Date: Thu Feb 7 18:54:17 2008 +0100

    new interface org.freedesktop.Hal.Device.DockStation

    Change the platform_add method to an add 'info.docked' property to all
    dock devices. Also add a platform_refresh method to update the status.

    New interface org.freedesktop.Hal.Device.DockStation interface
    with method
    'Undock' and add corresponding script hal-dockstation-undock(-linux).

    Update the specification for the interface
    org.freedesktop.Hal.Device.Dockstation with method 'Undock'.

    Add hal-dockstation.policy file with privilege
    org.freedesktop.hal.dockstation.undock

 doc/spec/hal-spec-interfaces.xml | 36
 ++++++++++++++++++++++++++++++
 fdi/policy/10osvendor/10-dockstation.fdi | 13 ++++++++++
 fdi/policy/10osvendor/Makefile.am | 3 +-
 hald/linux/device.c | 24 ++++++++++++++++++++
 policy/hal-dockstation.policy | 18 +++++++++++++++
 tools/Makefile.am | 1 +
 tools/hal-dockstation-undock | 6 +++++
 tools/linux/Makefile.am | 1 +
 tools/linux/hal-dockstation-undock-linux | 11 +++++++++
 9 files changed, 112 insertions(+), 1 deletions(-)

commit 322fd1e68a68c5de975e43672e14916f895ba87c
Author: Danny Kukawka <email address hidden>
Date: Thu Dec 6 09:59:01 2007 +0100

    linux: add drm subsystem

    Add the drm (Direct Rendering Manager devices) subsystem to HAL. This
    should allow to get the device file of the dri devices, which allows
    to set
    ACL permissions via HAL on them.

 doc/spec/hal-spec-properties.xml | 33 +++++++++++++++++++
 hald/linux/device.c | 64
 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 97 insertions(+), 0 deletions(-)

commit eb6d5b9c24e4eb42a8e9993a3936cf95aafacf12
Author: Holger Macht <email address hidden>
Date: Mon Oct 29 15:44:06 2007 -0400

    add support for Wake On LAN

    On Tue 28. Aug - 14:21:42, David Zeuthen wrote:
    >
    > On Tue, 2007-08-14 at 15:22 +0200, Holger Macht wrote:
    > > +wol_supported() {
    > > + UDI=$1
    > > +
    > > + IFACE=`hal-get-property --udi $UDI --key net.interface`
    > > + if [ -z "$IFACE" ]; then
    > > + echo "org.freedesktop.Hal.Device.WakeOnLAN.NotSupported"
    > > + return 1
    > > + fi
    >
    > Actually I think IFACE is the same as HAL_PROP_NET_INTERFACE;
    saves a
    > fork + some IPC. Ditto for getting other properties too.
    >
    > Btw, there should probably exist tools/hal-system-wol-* that
    looks sorta
    > like this (this is snipped from another script in tools/) to check
    > whether the caller is actually privileged to do this
    >
    > #!/bin/sh
    > . hal-functions
    >
    > hal_check_priv org.freedesktop.hal.wol.<the-action>
    > hal_exec_backend
    >
    > and you should define these PolicyKit actions in
    policy/hal-wol.policy

    Added PolicyKit support and included suggestions from Dan Nicholson.

    This time, everything is included in one single patch.

 doc/spec/hal-spec-interfaces.xml | 55
 +++++++++++++++++++++++++++++++++++++
 fdi/policy/10osvendor/30-wol.fdi | 28 +++++++++++++++++++
 fdi/policy/10osvendor/Makefile.am | 3 +-
 policy/Makefile.am | 3 +-
 policy/hal-wol.policy | 35 +++++++++++++++++++++++
 tools/Makefile.am | 3 ++
 tools/hal-system-wol-enable | 24 ++++++++++++++++
 tools/hal-system-wol-enabled | 20 +++++++++++++
 tools/hal-system-wol-supported | 20 +++++++++++++
 tools/linux/Makefile.am | 11 +++++++-
 10 files changed, 199 insertions(+), 3 deletions(-)

I prepared the new version and put it into my PPA: https://launchpad.net/~pitti/+archive. I tested it successfully on my desktop and laptop.

Related branches

Revision history for this message
Martin Pitt (pitti) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

I'm running the ppa version on my laptop and it works correctly there

Revision history for this message
Martin Pitt (pitti) wrote :

More success reports in bug 194052.

Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Working perfectly here - it's fixed a lot of my issues that I never got around to actually filing.

I'd approve, but we should wait for Steve to give the final ack.

Revision history for this message
Martin Pitt (pitti) wrote :

Even more success stories in bug 194719.

Revision history for this message
Steve Langasek (vorlon) wrote :

FFe ack. Please withhold uploading until alpha-6 is finalized.

Changed in hal:
status: New → Confirmed
Martin Pitt (pitti)
Changed in hal:
assignee: nobody → pitti
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.2 KiB)

This bug was fixed in the package hal - 0.5.10+git20080301-1ubuntu1

---------------
hal (0.5.10+git20080301-1ubuntu1) hardy; urgency=low

  * Merge with Debian to pull in a current snapshot from upstream git head
    (upstream neglects doing a long-overdue 0.5.11 release). This pulls in two
    tons of bug fixes and reduces our insane stack of patches to a
    maintainable level again. (LP: #198295)
    - Uses MMC profile reading for CDs/DVDs. (LP: #66254)
  * Remove the following patches which are upstream now:
    - 01_proc_sys_batteries.patch
    - 02_sysfs_battery_serial.patch
    - 92_gxx43.patch
    - 94_batter-model_name.patch
    - 97_fix_power_info_via_sysfs.patch
  * Drop 80_allow_vfat_usefree.patch; Using 'usefree' VFAT mount option is not
    necessary with the current Hardy kernel any more.
  * Drop debian/patches/82_ignore_fixed_nonmedia.patch: Obsolete, GVFS treats
    fixed partitions correctly.
  * Tag and forward the subset of our remaining patches which have some kind
    of documentation and justification. Rename them to clean up patch order
    prefixes a bit.
  * 96_uinput_device_support.patch: Adapt to new upstream version.
  * Remaining Ubuntu changes:
   - debian/hal.init: Remove stray gparted-disable-automount.fdi on startup.
     Needs to be kept until Gnome #324220 is fixed properly.
     (LP #134712)
   - debian/hal.init: Unconditionally chown the directory in the init script.
     (LP #175525)
   - Ubuntu udev world order:
     + debian/hal.links: Remove rules symlink, we install the rules file
       directly into rules/.
     + debian/rules: Install udev rules into /etc/udev/rules.d/.
     + debian/hal.{preinst,postinst,postrm}: Transition code for changing the
       udev rule priority (see 0.5.8.1-3ubuntu7, needs to be kept until after
       Hardy's release).
   - debian/hal.preinst, debian/libhal1.preinst: Clean up doc directory
     symlinking when upgrading from Gutsy. Needs to be kept until after
     Hardy's release.
   - debian/rules: Enable MacBook (Pro) support on i386 and amd64. Add
     pciutils-dev build dependency.
   - debian/rules: Do not run stop init.d script for levels 1 and 6
     (TearDown).
   - debian/preferences.fdi: Disable automounting for fixed disks. On session
     startup it is not done anyway (since that disables the gnome-mount UI
     which would ask for authentication) and it leads to confusion when
     restarting hal while a session is running. (LP #138537)
   - Various bug fixes, see their patch headers:
     + 02_allow_ufs_ufstype.patch
     + 03_virtual_net_devices.patch
     + 04_read_brightness_not_actual_brightness.patch
     + 96_uinput_device_support.patch
     + ubuntu_01_ignore_single_slash_label.patch
   - 83_ssb_bus_support.patch: Add support for devices on the SSB bus; patch
     by Matthew Garrett (not applied upstream yet, this needs to update the
     spec, too).
   - 84_memstick_bus_support.patch: Add support for devices on the "memstick"
     bus; patch by Matthew Garrett (not reported upstream yet, this needs to
     update the spec, too).
   - 88_change_pm_quirk_policy.patch: Patch by Matthew Garret, undocumented,
     non-obvious purpose.
   - Use Polic...

Read more...

Changed in hal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.