Show potential Ubuntu Pro updates and apt news messages

Bug #1990450 reported by Robert Ancell
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Status tracked in Noble
Xenial
Fix Committed
Medium
Nathan Teodosio
Bionic
Fix Released
Medium
Nathan Teodosio
Focal
Fix Released
Medium
Nathan Teodosio
Jammy
Fix Released
Medium
Nathan Teodosio
Kinetic
Fix Released
Low
Robert Ancell
Lunar
Won't Fix
Undecided
Nathan Teodosio
Mantic
Won't Fix
Undecided
Nathan Teodosio
Noble
Fix Released
Low
Nathan Teodosio

Bug Description

[Impact]
Show the Ubuntu Pro (aka Ubuntu Advantage) updates that would be enabled if you attached this machine. This information is not currently shown.

The new revision also update the reference to the Software Properties' Livepatch tab which doesn't exist anymore since bug #2003527 and was replaced by Ubuntu Pro.

There is also a new section 'News' showing the apt-news messages if there are any available and some layout changes to accommodate for the new section

[Test Case]
1. Do fresh install of Ubuntu with available updates
2. Check there are updates available by running:
$ pro security-status
Note that updates are only available for older LTS releases.
If there are no Pro specific updates available, install any package listed in https://esm.ubuntu.com/apps/ubuntu/dists/jammy-apps-security/main/binary-amd64/Packages (without attaching your machine!)
3. Open update-manager

-> There should be a 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list showing disabled and including under it the name of the packages that would be available if pro was enabled

4. start software-properties, go to the ubuntu pro tab and attach to a pro account
5. close software-properties and restart update-manager

-> There should be a 'Ubuntu Pro security updates' section at the bottom of the updates list showing enabled and including under it packages updated provided by pro that can be installed

6. Check the top of the update-manager dialog

If there is a message available on the server
$ curl https://motd.ubuntu.com/aptnews.json
with a timestamp older than one month

then a 'news' section should be displayed including the message

if there isn't a recent post on the server it can be tested locally with the steps from #31

[Regression Potential]
Possibility of introducing new bugs.

The new livepatch->ubuntu pro string change will not be translated until the next language pack refresh

Related branches

Revision history for this message
Dan Bungert (dbungert) wrote :
Changed in update-manager (Ubuntu Jammy):
status: New → Incomplete
Revision history for this message
Sebastien Bacher (seb128) wrote :

@Dan, the design is available on https://app.zeplin.io/project/6319abf25548b04abcee1b5f/dashboard

The Kinetic target is correct, even if the service isn't available on non LTS serie we need the code to be merged in the current serie before being backported by SRU rules

The corresponding PR is https://code.launchpad.net/~robert-ancell/update-manager/ua/+merge/430517 which Julian reviewed and merged now, thanks!

Changed in update-manager (Ubuntu Kinetic):
status: New → Fix Committed
importance: Undecided → Low
assignee: nobody → Robert Ancell (robert-ancell)
Changed in update-manager (Ubuntu Xenial):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in update-manager (Ubuntu Bionic):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in update-manager (Ubuntu Focal):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in update-manager (Ubuntu Jammy):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in update-manager (Ubuntu Xenial):
importance: Undecided → Medium
Changed in update-manager (Ubuntu Bionic):
importance: Undecided → Medium
Changed in update-manager (Ubuntu Focal):
importance: Undecided → Medium
Changed in update-manager (Ubuntu Jammy):
importance: Undecided → Medium
Changed in update-manager (Ubuntu Jammy):
status: Incomplete → In Progress
description: updated
description: updated
Changed in update-manager (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Changed in update-manager (Ubuntu):
status: Fix Committed → Fix Released
description: updated
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:18.04.11.15 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (update-manager/1:18.04.11.15)

All autopkgtests for the newly accepted update-manager (1:18.04.11.15) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:18.04.45 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Sebastien Bacher (seb128) wrote : Re: Show potential Ubuntu Pro updates

I tested 1:18.04.11.15 on a xubuntu bionic system where I downgraded ntfs3g to be able to see the 'update available' UI from update-manager

There is a cosmectic issue where the '>' sign is displayed over the checkbox but more important, the items associated to the few updates available in the esm-apps repository are displayed as empty lines and selecting one displays those exceptions

Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 289, in __getitem__
    return self._weakref[key]
  File "/usr/lib/python3.6/weakref.py", line 137, in __getitem__
    o = self.data[key]()
KeyError: ''

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 292, in __getitem__
    rawpkg = self._cache[key]
KeyError: ''

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py", line 371, in get_news_and_changelog
    self.get_changelog(name)
  File "/usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py", line 426, in get_changelog
    origins = self[name].candidate.origins
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 294, in __getitem__
    raise KeyError('The cache has no package named %r' % key)
KeyError: "The cache has no package named ''"

apt displays the right information

The following security updates require Ubuntu Pro with 'esm-apps' enabled:
  libopenjp2-7 libzmq5 libopenmpt0 libsoundtouch1 libmysofa0
Learn more about Ubuntu Pro at https://ubuntu.com/pro

I'm marking the SRU verification as failed at least on bionic

tags: added: verification-failed-bionic
removed: verification-needed-bionic
Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

The issue there was the 'pro' output changed, renaming 'name' to 'package'. I've uploaded updates fixing that now, going forward we should update the code to use https://github.com/canonical/ubuntu-advantage-client/blob/main/docs/references/api.md#upropackagesupdatesv1 instead

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
removed: verification-failed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:18.04.11.16 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Nathan Teodosio (nteodosio) wrote : Re: Show potential Ubuntu Pro updates

Trouble reproducing this in Bionic.

- Fresh install, "pro" was not installed.
- I install it.
- I run "pro security-status" and see no mention to available updates.

--->
1585 packages installed:
     1584 packages from Ubuntu Main/Restricted repository
     1 package from Ubuntu Universe/Multiverse repository

To get more information about the packages, run
    pro security-status --help
for a list of available options.

This machine is receiving security patching for Ubuntu Main/Restricted
repository until 2023.
This machine is NOT attached to an Ubuntu Pro subscription.

Ubuntu Pro with 'esm-infra' enabled provides security updates for
Main/Restricted packages until 2028.

Ubuntu Pro with 'esm-apps' enabled provides security updates for
Universe/Multiverse packages until 2028.

Try Ubuntu Pro with a free personal subscription on up to 5 machines.
Learn more at https://ubuntu.com/pro
<---

Can you please clarify the test case?

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Even after attaching with "pro attach", "pro security-status" says

--->
1585 packages installed:
     1584 packages from Ubuntu Main/Restricted repository
     1 package from Ubuntu Universe/Multiverse repository

To get more information about the packages, run
    pro security-status --help
for a list of available options.

This machine is attached to an Ubuntu Pro subscription.

Main/Restricted packages are receiving security updates from
Ubuntu Pro with 'esm-infra' enabled until 2028.

Universe/Multiverse packages are receiving security updates from
Ubuntu Pro with 'esm-apps' enabled until 2028.
<---

Revision history for this message
Sebastien Bacher (seb128) wrote :

Updated the description to include details about the follow-up upload fixing layout issues (checkbox and > sign colliding, sub section between indented differently from others)

description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.14 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:18.04.11.17 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (update-manager/1:22.04.13)

All autopkgtests for the newly accepted update-manager (1:22.04.13) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:22.04.13 (arm64, amd64, s390x, armhf, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (update-manager/1:18.04.11.17)

All autopkgtests for the newly accepted update-manager (1:18.04.11.17) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:18.04.11.17 (ppc64el, i386, amd64, s390x, arm64, armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (update-manager/1:20.04.10.14)

All autopkgtests for the newly accepted update-manager (1:20.04.10.14) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.14 (armhf, arm64, amd64, ppc64el, s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Brian Murray (brian-murray) wrote : [update-manager/bionic] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for bionic for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: Show potential Ubuntu Pro updates

Please remove the update from proposed. The product team asked us to do adjustments in the UI before considering moving it to updates

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Proposed package removed from archive

The version of update-manager in the proposed pocket of Bionic that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.

tags: removed: verification-needed-bionic
Changed in update-manager (Ubuntu Bionic):
status: Fix Committed → Won't Fix
5 comments hidden view all 110 comments
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: Show potential Ubuntu Pro updates

If we tried to restore those change we would need to include the fix from https://code.launchpad.net/~seb128/update-manager/pro-client-update/+merge/436368 to adapt to a pro client change

Changed in update-manager (Ubuntu Jammy):
status: Fix Committed → In Progress
Changed in update-manager (Ubuntu Focal):
status: Fix Committed → In Progress
Changed in update-manager (Ubuntu Bionic):
status: Won't Fix → In Progress
Changed in update-manager (Ubuntu Xenial):
status: New → In Progress
assignee: Robert Ancell (robert-ancell) → Nathan Teodosio (nteodosio)
Changed in update-manager (Ubuntu Bionic):
assignee: Robert Ancell (robert-ancell) → Nathan Teodosio (nteodosio)
Changed in update-manager (Ubuntu Focal):
assignee: Robert Ancell (robert-ancell) → Nathan Teodosio (nteodosio)
Changed in update-manager (Ubuntu Jammy):
assignee: Robert Ancell (robert-ancell) → Nathan Teodosio (nteodosio)
Revision history for this message
Sebastien Bacher (seb128) wrote (last edit ):

Sharing some tip to try the news feature if there isn't a news available on the server

$ sudo apt install nginx
$ sudo sed -i "s/gzip on;/gzip on;\n\tgzip_min_length 1;\n\tgzip_types application\/json;\n/" /etc/nginx/nginx.conf
$ sudo systemctl restart nginx
$ sudo pro config set apt_news_url=http://localhost:80/aptnews.json
$ sudo editor /var/www/html/aptnews.json

using the content

{
    "messages": [
        {
            "begin": "2023-09-03T00:00:00Z",
            "lines": [
                "You can verify the status of security fixes using the `pro fix` command.",
                "E.g., a recent Ruby vulnerability can be checked with: `pro fix USN-6219-1`",
                "For more detail see: https://ubuntu.com/security/notices/USN-6219-1"
            ]
        }
    ]
}

$ sudo pro refresh messages

description: updated
description: updated
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

The jammy version has been uploaded now

Changed in update-manager (Ubuntu Jammy):
status: In Progress → Fix Committed
Changed in update-manager (Ubuntu):
status: Fix Released → In Progress
assignee: Robert Ancell (robert-ancell) → Nathan Teodosio (nteodosio)
Changed in update-manager (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Uploading to mantic also now, there isn't going to be pro update available there but it's a prerequired for the SRU. The update still include the layout change and the news section so asking for a FFe from the release team. I will email documentation and translators with screenshot a bit later

summary: - Show potential Ubuntu Pro updates
+ SRU, FFe, UIFe: Show potential Ubuntu Pro updates and apt news messages
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: SRU, FFe, UIFe: Show potential Ubuntu Pro updates and apt news messages

Screenshot on mantic before the change

Revision history for this message
Sebastien Bacher (seb128) wrote :

Screenshot on mantic after the change (and with an apt news message available, which isn't the case on the server currently)

Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

changing back the status for mantic even if it's uploaded as requested on https://bugs.launchpad.net/ubuntu/+source/gnome-initial-setup/+bug/2036981/comments/7

Changed in update-manager (Ubuntu):
status: Fix Committed → New
Changed in update-manager (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in update-manager (Ubuntu Bionic):
status: In Progress → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Release team decided it was too late in the cycle for mantic and that we will SRU as well for mantic instead

summary: - SRU, FFe, UIFe: Show potential Ubuntu Pro updates and apt news messages
+ Show potential Ubuntu Pro updates and apt news messages
Changed in update-manager (Ubuntu):
status: New → Fix Committed
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.14 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.15 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
description: updated
tags: added: verification-done-jammy
removed: verification-needed-jammy
tags: added: verification-failed-bionic
removed: verification-needed-bionic
tags: added: verification-done-bionic
removed: verification-failed-bionic
tags: added: verification-done-focal
removed: verification-needed-focal
Changed in update-manager (Ubuntu Mantic):
assignee: nobody → Nathan Teodosio (nteodosio)
Changed in update-manager (Ubuntu Lunar):
assignee: nobody → Nathan Teodosio (nteodosio)
Changed in update-manager (Ubuntu Mantic):
status: New → In Progress
Changed in update-manager (Ubuntu Noble):
status: Fix Committed → New
Changed in update-manager (Ubuntu Lunar):
status: New → Won't Fix
Changed in update-manager (Ubuntu Mantic):
status: In Progress → Won't Fix
Changed in update-manager (Ubuntu Noble):
status: New → Fix Released
30 comments hidden view all 110 comments
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Cross that. Although it was merged to main branch[1], the archive still holds 23.10.1.

[1] https://git.launchpad.net/update-manager/log/

Changed in update-manager (Ubuntu Noble):
status: Fix Released → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

It has been uploaded to noble now but we got asked to now move the SRU to -updates without the fix for bug #2043425 so we are uploading another round of updates, sorry...

tags: added: verification-failed verification-failed-bionic verification-failed-focal verification-failed-jammy
removed: removal-candidate verification-done-bionic verification-done-focal verification-done-jammy verification-needed
Revision history for this message
Sebastien Bacher (seb128) wrote :

I'm changing the tags to verification-failed meanwhile

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sorry, I'm very much lost by now.

Let's use jammy as an example:

update-manager | 1:22.04.9 | jammy | source
update-manager | 1:22.04.10 | jammy-updates | source
update-manager | 1:22.04.16 | jammy-proposed | source
update-manager | 1:22.04.17 | jammy/unapproved/93d92bdd | source

We have 22.04.16 in jammy-proposed, which claims to have fixed this bug here: #1990450

We have 22.04.17 in jammy unapproved, which claims in its changes file to be fixing #1990450 again, and #2043425. It has no new changes about #1990450, though.

And #1990450 has verification-failed tags.

If we accept the package in jammy-unapproved, it will again try to fix this bug here, but with no new changes, it won't. So should the package in unapproved not claim to fix #1990450? Or what is going on?

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Andreas, sorry for the confusion, let me see if I can help making things a bit easier to understand

We are trying to land the Pro update feature for a while now. Bug #2043425 is a problem reported with the current implementation of the feature. Our PM asked us to not move the current version of the SRU to -updates but to fix 2043425 first, which is why we tagged the current bug as verification-failed (to avoid having it moved to updates).

We can't reuse the same revision with new content so we are adding a new changelog entry with a reference to the issue fixed but that new revision. Since the current version isn't in -updates we built the update with -v$current_updates_version since that's technically the content of what needs to be verified (and the bug here should be verified again to make sure we didn't introduce a regression since the fix was verified in the previous revision), I thought that was common practice?

Since 2043425 is a problem with the changeset of the current -proposed version we could probably have re-used the same bug number here rather than listing an extra reference...

Let me know if the explanations are enough to move forward or if you would prefer to see things changed somehow

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.17 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-jammy
removed: verification-failed verification-failed-jammy
tags: added: verification-needed-focal
removed: verification-failed-focal
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.18 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:16.04.18 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
removed: verification-failed-bionic
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:18.04.11.21 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Ran my 18.04.06 virtual machine.

Followed #31 to set up local apt-news as in the moment none was provided by the official server.

Opened udpate-manager and there was the news pane with the news I set up.

There was a 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list showing insenstive Pro updates.

Via settings button, attached machine, closed software-properties, update-manager recalculated the view and the software under the Pro section was now installable.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Ran my 22.04 virtual machine.

Followed #31 to set up local apt-news as in the moment none was provided by the official server.

Opened update-manager and there was the news pane with the news I set up.

There was a 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list showing insensitive Pro updates.

Via settings button, attached machine, closed software-properties, update-manager recalculated the view and the software under the Pro section was now installable.

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Ran my 16.04 virtual machine.

Followed #31 to set up local apt-news as in the moment none was provided by the official server.

Opened update-manager and there was there was no news pane. I'm putting this on hold though and talking with the advantage-tools maintainers because 'ua api u.apt_news.current_news.v1' is also returning nothing so maybe there is something misbehaving there.

There was a 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list showing insensitive Pro updates.

Via settings button, attached machine, closed software-properties, update-manager recalculated the view and the software under the Pro section was now installable.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Some non-ASCII characters made their way into the json when I copy/pasted. After fixing that the problem is solved and I can confirm the news pane shows up, so confirming #82 test succeeds for Xenial because the news pane shows.

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

Ran my 20.04 virtual machine.

Followed #31 to set up local apt-news as in the moment none was provided by the official server.

Opened update-manager and there was the news pane with the news I set up.

There was a 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list showing insensitive Pro updates.

Via settings button, attached machine, closed software-properties, update-manager recalculated the view and the software under the Pro section was now installable.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Chris Halse Rogers (raof) wrote :

This is marked as "Fix Committed" in Noble, but update-manager 1:24.04.1 in noble-proposed does not claim to fix this bug. Where is the fix committed to?

Otherwise, this looks good to release to Jammy and Focal.

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Chris, the 1:24.04.1 upload is stacked on top of 1:23.1.0.2 which closes this bug, see the .changes on https://launchpad.net/ubuntu/+source/update-manager/1:24.04.1 (the 1:23.1.0.2 was initially uploaded to mantic before release but it was decided that it was a risky change and the release team decided to not take that update in for mantic)

Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for update-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:22.04.17

---------------
update-manager (1:22.04.17) jammy; urgency=medium

  * Fix incorrect available version for Ubuntu Pro updates in unattached case
    (LP: #2043425).

update-manager (1:22.04.16) jammy; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - fix another linter error which was created while fixing a missing
      space in the previous upload...

update-manager (1:22.04.15) jammy; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - Address linter errors that cause autopkgtest to fail.

update-manager (1:22.04.14) jammy; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - Show Ubuntu Pro packages, whether the system is attached to Ubuntu Pro
      or not.
    - Replace Install now button by Enable Ubuntu Pro button when only Ubuntu
      Pro packages are available and the machine is not attached.
    - Fix checkbox and expander widget from overlapping.
    - Add News pane in a expander.
    - Replace notebook with Description and Changes tabs by a pane.

update-manager (1:22.04.13) jammy; urgency=medium

  * Fix Ubuntu Pro updates checkbox and expander widget from overlapping (LP: #1990450)

update-manager (1:22.04.12) jammy; urgency=medium

  * Update of the parsing for pro client changes (lp: #1990450)

update-manager (1:22.04.11) jammy; urgency=medium

  * Show pending Ubuntu pro packages (LP: #1990450)

 -- Nathan Pratta Teodosio <email address hidden> Thu, 16 Nov 2023 10:07:06 +0100

Changed in update-manager (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:24.04.2

---------------
update-manager (1:24.04.2) noble; urgency=medium

  * Fix linter warning that causes autopkgtest to fail.
  * Drop call to ua security-status --format=json.
    Use uaclient.api.u.pro.packages.updates.v1.updates instead.

 -- Nathan Pratta Teodosio <email address hidden> Wed, 22 Nov 2023 08:32:20 +0100

Changed in update-manager (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:20.04.10.18

---------------
update-manager (1:20.04.10.18) focal; urgency=medium

  * Fix incorrect available version for Ubuntu Pro updates in unattached case
    (LP: #2043425).

update-manager (1:20.04.10.17) focal; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - fix another linter error which was created while fixing a missing
      space in the previous upload...

update-manager (1:20.04.10.16) focal; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - Address linter errors that cause autopkgtest to fail.

update-manager (1:20.04.10.15) focal; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - Show Ubuntu Pro packages, whether the system is attached to Ubuntu Pro
      or not.
    - Replace Install now button by Enable Ubuntu Pro button when only Ubuntu
      Pro packages are available and the machine is not attached.
    - Fix checkbox and expander widget from overlapping.
    - Add News pane in a expander.
    - Replace notebook with Description and Changes tabs by a pane.

update-manager (1:20.04.10.14) focal; urgency=medium

  * Fix Ubuntu Pro updates checkbox and expander widget from overlapping
    (LP: #1990450)

update-manager (1:20.04.10.13) focal; urgency=medium

  * Update of the parsing for pro client changes (lp: #1990450)

update-manager (1:20.04.10.12) focal; urgency=medium

  * Show pending Ubuntu pro packages (LP: #1990450)

 -- Nathan Pratta Teodosio <email address hidden> Wed, 15 Nov 2023 11:28:54 +0100

Changed in update-manager (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

What's the state of this for xenial and bionic?

# Bionic

update-manager | 1:18.04.11 | bionic | source
update-manager | 1:18.04.11.13 | bionic-updates | source
update-manager | 1:18.04.11.21 | bionic-proposed | source
update-manager | 1:18.04.11.22 | bionic/unapproved/e6f5680e | source

The changes file for bionic-unapproved includes versions 18.04.11.16 up to 18.04.11.22, while the changes file for what was accepted into bionic-proposed is from 18.04.11.14 to 18.04.11.21.

You can see the range of versions does not match each other, not even in a continuation scheme. Should bionic-unapproved be rejected?

# xenial

update-manager | 1:16.04.3 | xenial | source
update-manager | 1:16.04.12 | xenial-security | source
update-manager | 1:16.04.17 | xenial-updates | source
update-manager | 1:16.04.18 | xenial-proposed | source
update-manager | 1:16.04.19 | xenial/unapproved/29f0ea91 | source

xenial-proposed has a changes file for just version 16.04.18, and xenial-unapproved's changes file is from 16.04.18 to 16.04.19.

in that form, xenial-unapproved would be ok to consider for sru review and acceptance on top of what is in xenial-proposed currently.

Please state your intentions wrt bionic and xenial considering the above.

Revision history for this message
Nathan Teodosio (nteodosio) wrote : Re: [Bug 1990450] Re: Show potential Ubuntu Pro updates and apt news messages

The source of the confusing situation was probably the proposal of
another SRU, LP:2045918, whence the versions in unapproved come.

In these processes I only go up to requesting sponsorship, so I am not
familiar with all that happens under the hood after that step, although
I could guess the ideal situation for SRU approvers would be that no two
SRUs would be "active" at the same time for the same package, right?

Would the cleanest solution for the reviewers be to close both bugs for
Xenial and Bionic and open a new SRU that combines both?

Revision history for this message
Sebastien Bacher (seb128) wrote :

Hey Andreas, thanks for the review

> The changes file for bionic-unapproved includes versions 18.04.11.16 up to 18.04.11.22, while the changes file for what was accepted into bionic-proposed is from 18.04.11.14 to 18.04.11.21.
>
> You can see the range of versions does not match each other, not even in a continuation scheme. Should bionic-unapproved be rejected?

the set selected here was to reflect the actual change of the SRU (the previous revision was a testfix which doesn't need to be verified again so was slightly confusing) but .15 should probably have been included, though in practice it cover the same content and bug reference than the entries included.

I personally wouldn't reject the upload over that but you are the SRU reviewer so up to you at the end, let us know what you want to see happening for the upload to be unblocked

> xenial-proposed has a changes file for just version 16.04.18, and xenial-unapproved's changes file is from 16.04.18 to 16.04.19.
>
> in that form, xenial-unapproved would be ok to consider for sru review and acceptance on top of what is in xenial-proposed currently.

I'm unsure to understand what you describe there, from the queue
https://launchpadlibrarian.net/702021083/update-manager_16.04.19_source.changes

so the change includes the entries from .18 and .19 which are the versions not yet in -updates. My understanding is that it matches the common practice of including the changelog entry from the previous upload when doing a follow-up fix for a version that didn't get verified yet? If so I would say the xenial upload is as intended and should be accepted

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.19 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Focal):
status: Fix Released → Fix Committed
tags: added: verification-needed verification-needed-focal
removed: verification-done verification-done-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:18.04.11.22 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
removed: verification-done-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:16.04.19 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-xenial
removed: verification-done-xenial
Revision history for this message
Chris Halse Rogers (raof) wrote :

What is the actual status of this bug? 1:20.04.10.19 (in focal-proposed) claims to fix this, but 1:20.04.10.18 in focal-updates *also* claims to fix this. There's also 1:20.04.10.20 in unapproved, which does *not* include this bug in its .changes file.

From what I can tell, this *should* be "Fix Released" for focal but still "Fix Committed" for bionic?

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Chris, you are right, the focal SRU including those changes moved to updates, Brian changed the status back to 'fix commited' in comment #94 probably because the .changes included more entries that it should have. I'm setting focal back to fix released and the new .changes from .20 is correct to not include a reference to this bug

Changed in update-manager (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:18.04.11.23 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Chris Halse Rogers (raof) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:16.04.20 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

In a Bionic virtual machine, installed update-manager from proposed (.23), confirmed there were updates available with pro security-status.

With unattached machine, opened update-manager and confirmed the 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list.

I attached the machine to Pro, restarted update-manager and verified that the section was now 'Ubuntu Pro security updates' with installable Pro packages.

The news were too old according to motd.ubuntu.com and therefore I did the Nginx procedure as in #31 and confirmed that a news section shows up with the set up message.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

In a Xenial virtual machine, installed update-manager from proposed (.20), confirmed there were updates available with pro security-status.

With unattached machine, opened update-manager and confirmed the 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list.

I attached the machine to Pro, restarted update-manager and verified that the section was now 'Ubuntu Pro security updates' with installable Pro packages.

The news were too old according to motd.ubuntu.com and therefore I did the Nginx procedure as in #31 and confirmed that a news section shows up with the set up message.

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

In a Focal virtual machine, installed update-manager from proposed (.20), confirmed there were updates available with pro security-status.

With unattached machine, opened update-manager and confirmed the 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list.

I attached the machine to Pro, restarted update-manager and verified that the section was now 'Ubuntu Pro security updates' with installable Pro packages.

The news were too old according to motd.ubuntu.com and therefore I did the Nginx procedure as in #31 and confirmed that a news section shows up with the set up message.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:18.04.11.23

---------------
update-manager (1:18.04.11.23) bionic; urgency=medium

  * d/control: Depend on ubuntu-advantage-tools >= 30~.
    Fixes edge case whereby the program crashes upon an incomplete
    response from ua security-status (LP: #2049785).
  * The New Release dialog should take precedence over a list of updates dialog
    if the latter would only show Ubuntu Pro updates in an unattached system.
    (LP: #2051115).

update-manager (1:18.04.11.22) bionic; urgency=medium

  * Add back removed widgets to UI file to fix crash when updating
    Upgrade Manager from inside itself (LP: #2045918).

update-manager (1:18.04.11.21) bionic; urgency=medium

  * Fix incorrect available version for Ubuntu Pro updates in unattached case
    (LP: #2043425).

update-manager (1:18.04.11.20) bionic; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - fix another linter error which was created while fixing a missing
      space in the previous upload...

update-manager (1:18.04.11.19) bionic; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - Address linter errors that cause autopkgtest to fail.

update-manager (1:18.04.11.18) bionic; urgency=medium

  * Ubuntu Pro (LP: #1990450):
    - Show Ubuntu Pro packages, whether the system is attached to Ubuntu Pro
      or not.
    - Replace Install now button by Enable Ubuntu Pro button when only Ubuntu
      Pro packages are available and the machine is not attached.
    - Fix checkbox and expander widget from overlapping.
    - Add News pane in a expander.
    - Replace notebook with Description and Changes tabs by a pane.

update-manager (1:18.04.11.17) bionic; urgency=medium

  * Fix Ubuntu Pro updates checkbox and expander widget from overlapping
    (LP: #1990450)

update-manager (1:18.04.11.16) bionic; urgency=medium

  * Update of the parsing for pro client changes (lp: #1990450)

update-manager (1:18.04.11.15) bionic; urgency=medium

  * Show pending Ubuntu pro packages (LP: #1990450)

update-manager (1:18.04.11.14) bionic; urgency=medium

  * tests/test_meta_release_core.py: switch a test from using lucid to bionic
    as precise was removed from the archive. (LP: #1929865)

 -- Nathan Pratta Teodosio <email address hidden> Mon, 22 Jan 2024 21:36:03 +0100

Changed in update-manager (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:16.04.20

---------------
update-manager (1:16.04.20) xenial; urgency=medium

  * d/control: Depend on ubuntu-advantage-tools >= 30~.
    Fixes edge case whereby the program crashes upon an incomplete
    response from ua security-status (LP: #2049785).
  * The New Release dialog should take precedence over a list of updates dialog
    if the latter would only show Ubuntu Pro updates in an unattached system.
    (LP: #2051115).

update-manager (1:16.04.19) xenial; urgency=medium

  * Add back removed widgets to UI file to fix crash when updating
    Upgrade Manager from inside itself (LP: #2045918).

update-manager (1:16.04.18) xenial; urgency=medium

  * Implement the new Ubuntu Pro design (lp: #1990450).
    - Fuse the description and changes tabs into a single view.
    - Add button to attach to enable Ubuntu Pro if it is the only action
      available.
    - Ubuntu base -> System components.
    - Fix Ubuntu Pro item not being a parent group of its corresponding
      packages.
    - Fix incorrect available version for Ubuntu Pro updates in unattached case
      (LP: #2043425).

 -- Nathan Pratta Teodosio <email address hidden> Mon, 22 Jan 2024 21:39:36 +0100

Changed in update-manager (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote :
Download full text (4.1 KiB)

I mistakenly released this for xenial without noticing there are DEP8 errors in that ubuntu release. For some reason, they were not added as a comment to this bug, I suppose it has something to do with xenial being very much out of standard support.

In any case, the errors are:
256s autopkgtest [13:46:29]: test nose-tests: [-----------------------
256s
256s ** (nosetests3:7312): WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
256s /tmp/autopkgtest.cAx6Rc/build.PMT/src/UpdateManager/Dialogs.py:25: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
256s from gi.repository import Gtk
261s ................................................./tmp/autopkgtest.cAx6Rc/build.PMT/src/tests/../UpdateManager/Dialogs.py:195:1: E302 expected 2 blank lines, found 1
261s /tmp/autopkgtest.cAx6Rc/build.PMT/src/tests/../UpdateManager/UpdateManager.py:234:80: E501 line too long (99 > 79 characters)
269s F......E...E.............................
269s ======================================================================
269s ERROR: test_no_stop_no_updates (test_stop_update.TestStopUpdate)
269s ----------------------------------------------------------------------
269s Traceback (most recent call last):
269s File "/tmp/autopkgtest.cAx6Rc/build.PMT/src/tests/test_stop_update.py", line 34, in test_no_stop_no_updates
269s cancelled_update=False)
269s File "/tmp/autopkgtest.cAx6Rc/build.PMT/src/UpdateManager/UpdateManager.py", line 279, in _make_available_pane
269s return HWEUpgradeDialog(self)
269s NameError: name 'HWEUpgradeDialog' is not defined
269s
269s ======================================================================
269s ERROR: test_error_no_updates (test_update_error.TestUpdateManagerError)
269s ----------------------------------------------------------------------
269s Traceback (most recent call last):
269s File "/tmp/autopkgtest.cAx6Rc/build.PMT/src/tests/test_update_error.py", line 31, in test_error_no_updates
269s error_occurred=True)
269s File "/tmp/autopkgtest.cAx6Rc/build.PMT/src/UpdateManager/UpdateManager.py", line 279, in _make_available_pane
269s return HWEUpgradeDialog(self)
269s NameError: name 'HWEUpgradeDialog' is not defined
269s
269s ======================================================================
269s FAIL: test_pep8_clean (test_pep8.TestPep8Clean)
269s ----------------------------------------------------------------------
269s Traceback (most recent call last):
269s File "/tmp/autopkgtest.cAx6Rc/build.PMT/src/tests/test_pep8.py", line 33, in test_pep8_clean
269s self.assertEqual(0, ret_code)
269s AssertionError: 0 != 1
269s
269s ----------------------------------------------------------------------
269s Ran 90 tests in 12.808s

The pep8 one doesn't concern me, but the missing HWEUpgradeDialog does. This was introduced in 16.04.18, and indeed is not defined anywhere else in the code.

It was also not seen in the verification, meaning some specific event or situation needs to ex...

Read more...

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I see 1:16.04.21 is in xenial unapproved, and it fixes the above crash.

Changed in update-manager (Ubuntu Xenial):
status: Fix Released → Fix Committed
tags: added: verification-needed-xenial
removed: verification-done-xenial
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello Robert, or anyone else affected,

Accepted update-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:16.04.21 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (update-manager/1:16.04.21)

All autopkgtests for the newly accepted update-manager (1:16.04.21) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

update-notifier/blacklisted (arm64, armhf, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Nathan Teodosio (nteodosio) wrote :

In a Xenial virtual machine, installed update-manager from proposed (.21), confirmed there were updates available with pro security-status.

With unattached machine, opened update-manager and confirmed the 'Ubuntu Pro security updates (Enable in Settings...)' section at the bottom of the updates list.

I attached the machine to Pro, restarted update-manager and verified that the section was now 'Ubuntu Pro security updates' with installable Pro packages.

The news were too old according to motd.ubuntu.com and therefore I did the Nginx procedure as in #31 and confirmed that a news section shows up with the set up message.

tags: added: verification-dne-xenial
removed: verification-needed-xenial
tags: added: verification-done verification-done-xenial
removed: verification-dne-xenial verification-needed
Displaying first 40 and last 40 comments. View all 110 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.