swapoff before swapon
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| partman-base (Ubuntu) |
Fix Released
|
Medium
|
Colin Watson | ||
| partman-partitioning (Ubuntu) |
Fix Released
|
Medium
|
Colin Watson | ||
Bug Description
Binary package hint: ubiquity
Ubiquity does a swapoff off the old swap before it does a swapon of the new swap. This makes sense when the old swap is on the device that is being repartitioned. But why do this if the two swap partitions are on different physical devices. Indeed, why do a swapoff at all?
I would expect ubiquity not to swap off the old swap before swapping on the new swap. This may make ubiquity perform better on low memory machines.
ProblemType: Bug
Architecture: i386
Date: Thu Mar 6 17:17:36 2008
DistroRelease: Ubuntu 7.10
NonfreeKernelMo
Package: ubiquity 1.6.8
PackageArchitec
SourcePackage: ubiquity
Uname: Linux ubuntu 2.6.22-14-generic #1 SMP Sun Oct 14 23:05:12 GMT 2007 i686 GNU/Linux
| John McCabe-Dansted (gmatht) wrote | #1 |
| Colin Watson (cjwatson) wrote | #2 |
| Changed in ubiquity: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Colin Watson (cjwatson) wrote | #3 |
| Changed in partman-partitioning: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in partman-base: | |
| assignee: | nobody → kamion |
| status: | Confirmed → In Progress |
| Changed in partman-partitioning: | |
| assignee: | nobody → kamion |
| status: | Confirmed → In Progress |
| Fred (eldmannen+launchpad) wrote | #4 |
| Colin Watson (cjwatson) wrote | #5 |
| Changed in partman-base: | |
| status: | In Progress → Fix Committed |
| Changed in partman-partitioning: | |
| status: | In Progress → Fix Committed |
| Launchpad Janitor (janitor) wrote | #6 |
| Changed in partman-base: | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #7 |
| Changed in partman-partitioning: | |
| status: | Fix Committed → Fix Released |
You have to disable swap on a device (and in general unmount everything on it) in order to convince the kernel to reload the partition table if you make any changes to it. If you don't do this, partitioning can get very confused.
I do agree that there is room for optimisation here. Swap only needs to be disabled on devices that have actually changed at the partition table level. This would allow the sort of multiple-disk case you're talking about, as well as installing onto a pre-partitioned disk with low memory.