[Impact]
This will impact all of users that want to run pro status and also any other tool that is depending on the status command through the CLI or through the code itself.
On pro status, users will see the following message:
Failed to parse architecture from output of lscpu
And update-manager will break as reported here.
[Test Case]
1. Launch a lunar container
2. Update the Pro Client to 27.13.6
3. Install the language-pack-fr-base package
4. Run update-locale LANG=fr_FR.UTF-8
5. Reboot
6. Run pro status and confirm the error message
7. Install the new version of the Pro Client
8. Confirm that pro status no longer breaks
[Regression Potential]
We are no longer relying on lscpu, but on dpkg --print-architecture now.
Since we have used this command for other architecture related flows, we believe the dpkg command is stable enough to not cause regressions.
We are also confident in that because the command is being replaced in two distinct functions:
* enabled_warning_status
This function is responsible for just saying a warning message if the user does not have a support livepatch kernel. The message is as follows:
The current kernel (KERNEL_VERSION, ARCH) is not supported by livepatch.
Since we are also introducing that message on this releases, changes from
x86_64 to amd64 will not matter that much to the user.
* on_supported_kernel
Here we check the Livepatch API to see that we are running on a supported kernel. However, before we send the architecture information to the API, we make the following normalization:
"x86_64" -> "amd64",
"i686" -> "i386",
"ppc64le" -> "ppc64el",
"aarch64" -> "arm64",
"armv7l" -> "armhf",
The name on the right is consistent with the output of dpkg --print-architecture. Therefore, we should not see any change there as well.
[Discussion]
The status function from the Pro Client is now relying in the output of lscpu to fetch architecture information for Livepatch. However, the user might be using a locale on their system that changes the output of
lscpu causing our code to fail and raise an Exception.
Our planned release will only fix that specific bug. We are fixing it by relying on dpkg --print-architecture. This command is already used in other parts of the package and is not affected by the user's locale.
[Changelog]
* status:
- always use dpkg instead of lscpu for fetching architecture
information (LP: #2012735)
[Proposed MP]
We are addressing this bug fix on this MP here:
https://code.launchpad.net/~lamoura/ubuntu/+source/ubuntu-advantage-tools/+git/ubuntu-advantage-tools/+merge/439855
[Original Description]
do nothing and crash
ProblemType: Crash
DistroRelease: Ubuntu 23.04
Package: update-manager 1:23.04.1
ProcVersionSignature: Ubuntu 6.2.0-18.18-generic 6.2.6
Uname: Linux 6.2.0-18-generic x86_64
ApportVersion: 2.26.0-0ubuntu2
Aptdaemon:
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudID: none
CloudName: none
CloudPlatform: none
CloudSubPlatform: config
CurrentDesktop: ubuntu:GNOME
Date: Fri Mar 24 15:15:28 2023
ExecutablePath: /usr/bin/update-manager
GsettingsChanges:
b'com.ubuntu.update-manager' b'launch-count' b'1'
b'com.ubuntu.update-manager' b'launch-time' b'int64 1679663727'
InstallationDate: Installed on 2023-03-24 (0 days ago)
InstallationMedia: Ubuntu 23.04 "Lunar Lobster" - Alpha amd64 (20230324)
InterpreterPath: /usr/bin/python3.11
JournalErrors: бер 24 15:15:33 hostname gnome-control-c[2657]: Extension <email address hidden> is not available or invalid (state 99)
PackageArchitecture: all
ProcCmdline: /usr/bin/python3 /usr/bin/update-manager --no-update --no-focus-on-map
ProcEnviron:
LANG=uk_UA.UTF-8
PATH=(custom, no user)
SHELL=/bin/bash
XDG_RUNTIME_DIR=<set>
Python3Details: /usr/bin/python3.11, Python 3.11.2, python3-minimal, 3.11.2-1
PythonArgs: ['/usr/bin/update-manager', '--no-update', '--no-focus-on-map']
PythonDetails: N/A
SourcePackage: update-manager
Title: update-manager crashed with uaclient.exceptions.UserFacingError in get_lscpu_arch()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sudo users
Reproduced on a fresh installation of Lunar. There were updates available, I clicked on the notification and got this crash.