Remove duplication of devm_pwmchip_add function definition
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Lunar |
Fix Released
|
Medium
|
Roxana Nicolescu | ||
linux-kvm (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
Lunar |
Fix Released
|
Undecided
|
Roxana Nicolescu |
Bug Description
SRU Justification:
[Impact]
* Upstream commit 88da4e8113110d5
* `git am` did not detect that the changes were applied, leading to the same function definition being duplicated.
* This was not caught when the main kernel was built because this code is under CONFIG_PWM=n. The main kernel and pretty much every kernel apart from linux-kvm, has CONFIG_PWM=y.
* The problem was caught when lunar:linux-kvm was cranked and build failed with the following error:
```
In file included from /build/
/build/
486 | static inline int devm_pwmchip_
| ^~~~~~~~~~~~~~~~
/build/
481 | static inline int devm_pwmchip_
| ^~~~~~~~~~~~~~~~
```
[Fix]
* Revert the commit.
* Because this affects only linux:kvm, it is necessary to apply this fix for lunar:linux-kvm for cycle 2023.10.02, but the main kernel can wait for the next cycle.
[Test plan]
* Since linux-kvm was the only kernel that had this issue, I applied the patch to kvm after I rebased the latest changes from the parent and did a build test.
* I also did a build test for linux:main just to make sure
[Where problems could occur]
* This change is pretty non-invasive, so nowhere
CVE References
- 2023-25775
- 2023-31083
- 2023-31085
- 2023-34319
- 2023-37453
- 2023-3772
- 2023-3863
- 2023-39189
- 2023-39192
- 2023-39193
- 2023-4132
- 2023-4244
- 2023-42572
- 2023-42752
- 2023-42753
- 2023-42754
- 2023-42755
- 2023-42756
- 2023-4563
- 2023-45871
- 2023-4622
- 2023-4623
- 2023-4881
- 2023-4921
- 2023-5090
- 2023-5158
- 2023-5178
- 2023-5197
- 2023-5345
- 2023-5717
Changed in linux (Ubuntu): | |
status: | New → Invalid |
Changed in linux-kvm (Ubuntu Lunar): | |
status: | New → Invalid |
Changed in linux (Ubuntu Lunar): | |
status: | New → In Progress |
Changed in linux-kvm (Ubuntu Lunar): | |
status: | Invalid → In Progress |
Changed in linux (Ubuntu Lunar): | |
assignee: | nobody → Roxana Nicolescu (roxanan) |
Changed in linux-kvm (Ubuntu Lunar): | |
assignee: | nobody → Roxana Nicolescu (roxanan) |
tags: | added: sru-20231002 |
description: | updated |
description: | updated |
Changed in linux (Ubuntu Lunar): | |
status: | In Progress → Fix Committed |
Changed in linux-kvm (Ubuntu Lunar): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done-lunar-linux removed: verification-needed-lunar-linux |
This bug is awaiting verification that the linux-kvm/ 6.2.0-1016. 16 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- lunar-linux- kvm' to 'verification- done-lunar- linux-kvm' . If the problem still exists, change the tag 'verification- needed- lunar-linux- kvm' to 'verification- failed- lunar-linux- kvm'.
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!