project-x fails to build from source in noble

Packaging has been redone to fix FTBFS (though just bumping the compat level to 7 was enough) and debdiff attached.

Unofficial review, here's some things I noticed:

1: debian/copyright: "License: GPL" should be "License: GPL-2+". "GPL" all by itself is more permissive than "GPL-2+". [1] While that ambiguity is cleared up in the actual license reference, the file is supposed to be machine readable, and this could cause the license to be misidentified by an automated tool.

2: debian/copyright: You should probably add yourself to the Debian stanza of the copyright file.

3: Lintian is showing me "W: project-x: bad-jar-name [usr/share/java/ProjectX.jar]". See https://www.debian.org/doc/packaging-manuals/java-policy/ch02.html#policy-libraries. Please investigate this. (You can lintian-override this if it turns out to not be an issue.) (edit: just realized this is a native Ubuntu package, not a Debian one)

4: Some documentation under /usr/share/doc/project-x/htmls isn't registered with doc-base, causing the Lintian tag "possible-documentation-but-no-doc-base-registration" to show up. Probably not a blocker, but might be worth considering fixing. See https://www.debian.org/doc/debian-policy/ch-opersys.html#registering-documents-using-doc-base

5: debian/control: It would be best if you could add "Rules-Requires-Root: no" to the end of the source package stanza. Also not a blocker, but it would silence a pedantic Lintian gripe.

A couple of very picky nitpicks:

1: debian/copyright: This is purely my own personal opinion, but "Portions" is a slightly confusing name for a custom license. You might consider using a name like "Custom-Permissive" or something along those lines instead, as that's slightly more descriptive. (This is not a big deal, you can ignore me here if you want.)

2: There's no upstream metadata file. This also can be left out entirely, the Lintian tag that informed me of it is experimental and can be ignored without issues. I just usually write one when I'm packaging.

Again, this is unofficial, I do not have the needed access rights to sponsor this. I'm just looking at it and gaining experience doing reviews since I hope to eventually gain those access rights.

[1]: According to the GNU General Public License (versions 1, 2, and 3), "GPL" all by itself means that any version of the GPL (including the virtually unused GPLv1!) can be used.

Just to be completely clear, I asked Aaron to review this to get some practice. I can take on the actual sponsorship for this, so I can both give Sudip feedback that Aaron may have missed, and give Aaron feedback about the review process.

Thank you both for your understanding!

From my assessment, Aaron missed one thing, which is that Ubuntu MOTU is no longer a valid maintainer.

I would also try to fix these upstream (not a blocker, you could always quilt patch too):

I: project-x: desktop-entry-contains-encoding-key Encoding [usr/share/applications/projectx.desktop:5]
I: project-x: desktop-entry-lacks-keywords-entry [usr/share/applications/projectx.desktop]

And perhaps override or address these:

X: project-x source: update-debian-copyright 2008 vs 2023 [debian/copyright:28]
X: project-x source: very-long-line-length-in-source-file 8448 > 512 [resources/ac3.bin:1]

Overall, I think this is a great start. I'm happy Aaron received experience with reviewing, and I'm glad you're getting experience with bugfixing!

Please provide an updated diff and re-subscribe sponsors, at your convenience.

Thank you!

Modified debdiff attached.

Latest patch uploaded with a slight change to debian/lintian-overrides. (The bad-jar-name override was changed to only override for the particular file in question, rather than overriding all bad-jar-name warnings.)

This bug was fixed in the package project-x - 0.90.4dfsg-0ubuntu6

---------------
project-x (0.90.4dfsg-0ubuntu6) noble; urgency=medium

  * Redo the packaging to fix FTBFS. (LP: #2045816)
    - remove cdbs dependency.
    - d/control: start using debhelper-compat 13.
    - d/control: fix whitespace errors.
    - d/control: Update to Standards-Version 4.6.2
    - d/control: Update maintainer.
    - d/control: Add Rules-Requires-Root section.
    - d/doc-base: Add doc-base for HTML docs.
    - d/copyright: redo copyright file according to dep-5.
    - d/rules: redo rules file with cdbs remove.
    - d/source/format: update to 3.0 quilt format.
    - d/lintian-overrides: Add override for jar name warning.

 -- Sudip Mukherjee <email address hidden> Mon, 08 Jan 2024 20:18:44 +0000