Thinklight doesn't blink because /proc/acpi/ibm/thinklight has wrong permissions

Bug #221531 reported by Shentey
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kopete-plugin-thinklight (Ubuntu)
Fix Released
Medium
Harald Sitter
Declined for Karmic by Harald Sitter
Hardy
Fix Released
Undecided
Unassigned
Jaunty
Invalid
Undecided
Unassigned

Bug Description

== SRU request for jaunty: ==

Symptom: The thinklight plugin is not able to let the thinklight blink. It gives an error message that the file /proc/acpi/ibm/light cannot be written to.

Reason: Upstream does not install with SUID bit enabled.

Solution: The build system has to be patched, so that cmake installs kopete_thinklight_fixpermissions with suid-bit.

Development version: Already fixed in karmic with the same patch as being proposed here.

Regression potential:
Insignificant. The patch only touches the kopete-plugin-thinklight specific code and it is actually not working.

Revision history for this message
Joao SANSAO (jsansao) wrote :

I executed the following command to fix it :

$ sudo chmod 4755 /usr/bin/kopete_thinklight_fixpermissions

The permissions are now : -rwsr-xr-x

How can we submit this change upstream ?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kopete-plugin-thinklight - 0.3-0ubuntu4

---------------
kopete-plugin-thinklight (0.3-0ubuntu4) intrepid; urgency=low

  * Fix permission of kopete_thinklight_fixpermissions (LP: #221531)
  * Updated Standards-Version
  * Updated package copyright

 -- Harald Sitter <email address hidden> Tue, 03 Jun 2008 12:04:57 +0200

Changed in kopete-plugin-thinklight:
status: New → Fix Released
Revision history for this message
Harald Sitter (apachelogger) wrote :
Changed in kopete-plugin-thinklight:
assignee: nobody → apachelogger
Revision history for this message
Harald Sitter (apachelogger) wrote :

Please activate the hardy-proposed repository and install kopete-plugin-thinklight to test the fixed version. Please also add a comment about the test here.
Thank you.

Revision history for this message
Joao SANSAO (jsansao) wrote :

Just tested it here, and it's working fine. Thanks for the fix !

showing now:
-rwsr-xr-x 1 root root 2868 2008-06-03 07:57 /usr/bin/kopete_thinklight_fixpermissions

Revision history for this message
Shentey (shentey) wrote :

Same for me. Thank you very much!

Revision history for this message
Martin Pitt (pitti) wrote :

So, this was accepted into hardy-proposed without proper SRU documentation, nor an ACK from MOTU-SRU. motu-sru, can you please retroactively ack this? Marking as verified, since it has been tested by two people. Once this is ack'ed, I'll move it to -updates.

Changed in kopete-plugin-thinklight:
status: New → Fix Committed
Revision history for this message
Stephan Rügamer (sruegamer) wrote :

Hi,

The fix is very simple and regarding the reports of Joao and Shentey, after-ACK from me....

Regards,

\sh

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in kopete-plugin-thinklight:
status: Fix Committed → Fix Released
Revision history for this message
Mark (mark-wege) wrote :

This bug has reappeared in Jaunty

Revision history for this message
Fabian Köster (maestro-alubia) wrote :

I can confirm that this bug has reappeared in Jaunty.

Revision history for this message
Harald Sitter (apachelogger) wrote :

For some reason upstream doesn't install with SUID bit enabled, so the old fix does not work here, instead we need to patch the build system into enabling suid.

Changed in kopete-plugin-thinklight (Ubuntu):
importance: Undecided → Medium
status: Fix Released → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kopete-plugin-thinklight - 0.5-0ubuntu2

---------------
kopete-plugin-thinklight (0.5-0ubuntu2) karmic; urgency=low

  * Bump Debhelper to 7
  * Bump Standards-Version to 3.8.2
  * Move from cdbs to pkg-kde-tools with cdbs
  * Update Homepage URLs
  * Patch to make cmake install kopete_thinklight_fixpermissions with suid-bit
    + Add quilt as build-dep
    + Include quilt in debian/rules
    + LP: #221531
  * Build-dep on libkopete-dev rather than kdenetwork-dev
  * Bump my packaging Copyright to 2007-2009

 -- Harald Sitter <email address hidden> Sat, 11 Jul 2009 13:14:51 +0200

Changed in kopete-plugin-thinklight (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Christian Mangold (neversfelde) wrote :
description: updated
Changed in kopete-plugin-thinklight (Ubuntu Jaunty):
status: New → Confirmed
Revision history for this message
Shentey (shentey) wrote :

Fixed in KDE SVN: Applied above patch to CMakeLists.txt.

Revision history for this message
JC Hulce (soaringsky) wrote :

Thank you for taking the time to report this bug. This issue has been fixed in newer versions of Ubuntu, and Jaunty is EOL. Thus, I am closing this bugtask.

Changed in kopete-plugin-thinklight (Ubuntu Jaunty):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.