[SRU] Option --net fails (other than for Class C)

Bug #232361 reported by Kevin_Traas
8
Affects Status Importance Assigned to Milestone
ubuntu-vm-builder (Ubuntu)
Fix Released
Low
Unassigned
Hardy
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: ubuntu-vm-builder

$ lsb_release -rd
Description: Ubuntu 8.04
Release: 8.04

$ dpkg --status ubuntu-vm-builder | grep -e Status -e Version
Status: install ok installed
Version: 0.4-0ubuntu0.1

Problem:
Specifying --net <value> on the command line is ignored by the script. Instead, the script auto-calculates a value based on an assumed Class C (24 bit) IP address. For instance, the command line options --ip 10.5.20.57 --mask 255.255.0.0 --net 10.5.0.0 --bcast 10.5.255.255 will produce a response of "setting network to 10.5.20.0" indicating that the --net option/value from the command line was not detected and the NET value was auto-calculated (incorrectly).

Cause:
Everywhere within the script, the Network address is referenced as $NET; however, line 287 sets the value of $NETWORK when the --net command line option is passed, not $NET (as it should).

Solution:
Remove the characters WORK from line 287 of the script.

Revision history for this message
Kevin_Traas (kevin-traas) wrote :
description: updated
Revision history for this message
Nick Barcet (nijaba) wrote :

Thanks for catching this. Will work on it shortly.

Changed in ubuntu-vm-builder:
assignee: nobody → nijaba
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Nick Barcet (nijaba) wrote :

ubuntu-vm-builder - 0.4ubuntu2~ppa8 in https://launchpad.net/~nijaba/+archive should fix this.

Thanks again.

Changed in ubuntu-vm-builder:
status: In Progress → Fix Committed
assignee: nijaba → nobody
Nick Barcet (nijaba)
Changed in ubuntu-vm-builder:
milestone: none → ubuntu-8.04.1
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-vm-builder - 0.6

---------------
ubuntu-vm-builder (0.6) intrepid; urgency=low

  * Release into Ubuntu proper.

ubuntu-vm-builder (0.5ubuntu1~ppa4) intrepid; urgency=low

  [Loic Minier]
  * Call sh -c "$EXEC_SCRIPT" instead of "$EXEC_SCRIPT"; allows to pass
    arguments to the script; also remove check that EXEC_SCRIPT exists.

  [Nick Barcet]
  * Adding an error handler to fix LP: #217950
  * Lots of sanitization to allow for error handler
  * Add an interrupt handler to cleanup if user interrupts script
  * Stop on error in user script to fix LP: #228675
  * --ssh-key adds key to root and --ssh-user-key adds key to user
  * Added --raw option to install on raw devices/files.
    WARNING: the variables used in template files for disk definition have been
    modified. Please insure that locally created templates are updated to
    reflect this change.
  * Add --firstboot and --firstlogin options
  * First login always execute "sudo dpkg-reconfigure console-setup" so
    that the local keyboard setting is taken into account.
  * Adding the --iso parameter to create image from an iso. This requires
    suite and kernel-flavour parameters to match what is available on the iso,
    obviously.
  * Include hostname in default destination directory if defined
  * Do not use a tmpfs by default anymore
  * Place the working directory in the same directory as dest if using --tmp -
  * Added --tmpfs option to specify usage of a tmpfs for the working directory
  * VM specific parameters do not need to be the last ones anymore
  * Unknown parameters now return an error and prints usage
  * Added --overwrite for overwriting of destination directory and libvirt
    domain
  * Added ~/.ubuntu-vm-builder config handling
  * Man page improvements and reorganization

  [Soren Hansen]
  * Fix for LP: #234062 ssh root login broken

ubuntu-vm-builder (0.4ubuntu2~ppa7) hardy; urgency=low

  [ Michael Vogt ]
  * patch the way do_avoid_starting_daemons() to write a policy-rc.d file in
    the same way as pbuilder does (LP: #228372)

  [ Nick Barcet ]
  * Lock the root account by default (LP: #230291)
  * Add ssh keys to the user account and not to root (LP: #230291)
  * Added function do_copy_settings to fix bug LP: #221231
  * Fix missing ipv6 entries in host file (LP: #230299)
  * Fix issue with template arguments fetching (LP: #228268)
  * Create the /etc/apt/sources.list properly (LP: #218195)
  * Use a tmpfs for $WORKINGDIR to avoid case when file system is mounted
    with no suid (LP: #228744)
  * Unproper letters variable initialization (LP: #230312)
  * Option --net failed other than for Class C (LP: #232361)

  [ Loic Minier ]
  * Fix v / --verbose getopt parsing. (LP: #230319)
  * Compute the default ARCH with dpkg --print-architecture. (LP: #230323)
  * Add support for lpia.
    - Allow lpia arch, lpia and lpiacompat kernel flavours.
    - Use http://ports.ubuntu.com/ubuntu-ports as default mirror for lpia.
    - Update help/documentation.
  * Check Release files against the archive keyring; depend on ubuntu-keyring.
    (LP: #230334)

 -- Soren Hansen <email address hidden> Wed, 28 May 2008 11:36:02 +0200

Changed in ubuntu-vm-builder:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here

Changed in ubuntu-vm-builder:
status: New → Fix Committed
Steve Langasek (vorlon)
Changed in ubuntu-vm-builder:
milestone: ubuntu-8.04.1 → none
Revision history for this message
Steve Beattie (sbeattie) wrote :

I have reproduced the problem of the --net option not being honored in non-class C networks in the version of ubuntu-vm-builder in hardy-updates, 0.4-0ubuntu0.1, and can confirm that the version in hardy-proposed, 0.4-0ubuntu0.4, fixes the issue.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in ubuntu-vm-builder (Ubuntu Hardy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.