Feature freeze exception for kio-bookmarks 0.2

Bug #262661 reported by Jonathan Thomas
2
Affects Status Importance Assigned to Milestone
kio-bookmarks (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: kio-bookmarks

Rationale:
-0.2 implements several nice features: http://www.kde-apps.org/content/show.php/kio_bookmarks?content=86516
-There isn't any documentation or translations for this package so there is nothing to break!
-It is a simple program, (Actually a kio slave that displays an HTML page full of your bookmarks in Konq) so there is little to break. My testing hasn't found any regressions.

Low risk + significant increase in functionality, imo.

...plus the current 0.1.2 has a .svn directory in the orig.tar.gz :P
0.2 doesn't.

Revision history for this message
Jonathan Thomas (echidnaman) wrote :
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Is this an arch: any package?
How come it builds only on i386 arches:

https://launchpad.net/ubuntu/+source/kio-bookmarks/0.1.2-0ubuntu1

?
Is this supposed to be a native package?
The actual diff.gz looks pretty empty:

https://launchpad.net/ubuntu/intrepid/+source/kio-bookmarks/0.1.2-0ubuntu1/+files/kio-bookmarks_0.1.2-0ubuntu1.diff.gz

Changed in kio-bookmarks:
status: New → Incomplete
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

It should compile on any arch, however a fault mysql release broke compilation of all KDE apps a few days ago for any arch but i386 when this was originally uploaded.

And whoa, something is messed up with that diff.gz. Don't know how that happened.

Revision history for this message
Jonathan Thomas (echidnaman) wrote :

Oh, when I regenerated the orig.tar.gz to include the COPYING file the debian/ dir accidentally snuck in there... Oops.

Changed in kio-bookmarks:
status: Incomplete → New
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

What do you mean, you have added the COPYING file to the tarball yourself? Are you upstream?

Changed in kio-bookmarks:
status: New → Incomplete
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

No, I am not upstream.
Originally, the orig.tar.gz upstream released lacked the COPYING file.
Naturally, I informed upstream of this issue and it was added to svn promptly.
Therefore, I added COPYING to the orig.tar.gz myself, but neglected to move out the debian folder beforehand.
This is all documented in debian/changelog, including the KDE svn revision where the file was added.

Changed in kio-bookmarks:
status: Incomplete → New
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Mentioning it in the changelog is OK (even though you have to explicitly say that it is added to the original tarball which is then repacked) but you forgot to mention it in the REQUIRED file, which is debian/copyright; also you should have marked the original tarball so that it was easily recognised as NOT the same as the one distributed from upstream.
Having said that, please attach here a copy of your current diff.gz (since there is none in the uploaded package, please also add a watch and/or get-orig-source rule in this new version).

Changed in kio-bookmarks:
status: New → Incomplete
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

Thank you. I'll be sure to remember that next time this sort of situation arises. :)

Here's the diff.gz, anyway.

Revision history for this message
Jonathan Thomas (echidnaman) wrote :
Revision history for this message
Jonathan Thomas (echidnaman) wrote :
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Small, self contained app, builds fine, solves above packaging problems, motu-release first ack.

SPONSORING comments:
1) since you have quilt don't make in line changes but use it.
2) As already requested, I would like to see a watch and/or get-orig-source rule.
3) Also, note that this requires cdbs (>= 0.4.52ubuntu2) since it requires /usr/share/cdbs/1/class/kde4.mk.
4) Finally, settings/kcm_bookmarks.desktop is not removed in your clean target (needed because you don't use quilt, doing 1) above will also solve this).

Changed in kio-bookmarks:
status: Incomplete → New
Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 262661] Re: Feature freeze exception for kio-bookmarks 0.2

I think that this is reasonable to upload. Noting that the person
requesting the exception is not yet a MOTU and the package will go through
a normal sponsorship review, I'd suggest we focus on the decision about
should it be included and let the sponsor sort out the packaging.

I give this a tentative plus 1. It should not be confirmed unless norsetto
agrees (since he has raised objections).

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Yes, sorry for not being overly clear in comment #11: I'm happy to confirm the FFe.
The SPONSORING comments should be tackled in the normal sponsoring process.

Changed in kio-bookmarks:
status: New → Confirmed
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

Hmm, don't know how that change slipped in to kcm_bookmarks.desktop actually...
Oh, and quilt is required for kde4.mk to work, so I must build-depend on it even if I don't use it.

I will make the other changes shortly.

Revision history for this message
Jonathan Thomas (echidnaman) wrote :
Revision history for this message
Jonathan Thomas (echidnaman) wrote :
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

This upload includes a get-orig-source target in debian/rules and a correct build-dependency on cdbs.
As already noted, quilt is necessary for the use of kde4.mk

Revision history for this message
Scott Kitterman (kitterman) wrote :

Unsubcribed motu-release since the FFe is approved. Please seek sponsorship through the normal process.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kio-bookmarks - 0.2.1-0ubuntu1

---------------
kio-bookmarks (0.2.1-0ubuntu1) intrepid; urgency=low

  * New upstream release (LP: #262661)

 -- Jonathan Thomas (The man) <email address hidden> Fri, 05 Sep 2008 09:20:02 -0400

Changed in kio-bookmarks:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.