grammar adjustment in dpkg

Bug #332068 reported by Allan Caeg
8
Affects Status Importance Assigned to Milestone
dpkg (Debian)
Fix Released
Unknown
dpkg (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Got this while installing blueman from a 3rd party repo:

dpkg: bluez-gnome: dependency problems, but removing anyway as you request:
 libmbca0 depends on bluez-gnome.

"as you request"

"as you requested" would be more appropriate

The Ubuntu version being used is Ubuntu 8.10, dpkg is probably 1.14.20ubuntu6.

Revision history for this message
Sense Egbert Hofstede (sense) wrote : Re: grammar mistake in dpkg

Thank you for reporting this bug. It's almost ready for confirming. However, we'd like to know the version of Ubuntu and dpkg you're using.

This can be obtained by the following commands:
apt-cache policy dpkg
and for the Ubuntu version:
lsb_release -a
or graphically
System->About Ubuntu

Thanks in advance.

Changed in dpkg:
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Josh Holland (jshholland) wrote :

I don't think this is an actual bug. "as you request" is perfectly good English, meaning that it could cause problems, but dpkg is going ahead with removing it because you told it to.

Revision history for this message
Brian Murray (brian-murray) wrote :

Perhaps the reporter was thinking that "as you requested" was more appropriate.

Revision history for this message
Allan Caeg (allancaeg) wrote :

Yes. That's what I was thinking. Anyway, I'm on a typical Intrepid install.

Revision history for this message
Sense Egbert Hofstede (sense) wrote :

According to packages.ubuntu.com the current version of dpkg in Intrepid is 1.14.20ubuntu6
If you're using a different version, please leave a reply.

The report now contains enough information to be confirmed.

Changed in dpkg:
status: Incomplete → Confirmed
description: updated
Revision history for this message
Allan Caeg (allancaeg) wrote :

That's what I'm using :)

Changed in dpkg (Ubuntu):
assignee: nobody → David Stansby (dstansby)
status: Confirmed → In Progress
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Here's a patch for it.

Changed in dpkg (Ubuntu):
assignee: David Stansby (dstansby) → nobody
status: In Progress → Confirmed
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks for your work on this.

Do you think you could forward the change to Debian? https://wiki.ubuntu.com/Bugs/Debian

Revision history for this message
Daniel Holbach (dholbach) wrote :

(and please link the upstream bug here)

Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Should I link the upstream bug using "Also affects project" or "Also affects distribution"?

(The report is here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533171)

Revision history for this message
Colin Watson (cjwatson) wrote :

Use "Also affects distribution".

Thanks for your patch. I'm going to take this off the sponsorship list, though; for small changes like this it usually isn't worth an upload on its own. Furthermore, this is a translated string in a package for which we don't use language packs, and so simply changing the string in an Ubuntu upload would result in significant translation regressions; it's much better for the change to be made in Debian.

FWIW, you missed several instances of the same text:

src/errors.c:99: fprintf(stderr, _("Package %s was on hold, processing it anyway as you request\n"),
src/remove.c:130: _("dpkg: %s: dependency problems, but removing anyway as you request:\n%s"),
src/processarc.c:158: fprintf(stderr, _("Verification on package %s failed,\nbut installing anyway as you request.\n"), filename);
src/configure.c:135: _("dpkg: %s: dependency problems, but configuring anyway as you request:\n%s"),
src/configure.c:219: "Installing new config file as you request.\n"),
src/archives.c:1047: " remove anyway as you request.\n"), fixbyrm->name);

summary: - grammar mistake in dpkg
+ grammar adjustment in dpkg
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Thanks for the reply Colin, I've added a bug watch. Sorry I missed all those other instances, I'll fix them later on today, or tomorrow morning.

Changed in dpkg (Ubuntu):
assignee: nobody → David Stansby (dstansby)
status: Confirmed → In Progress
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Here's the new patch. I'll send it off to the upstream report too.

Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Here's the new patch. I'll forward it to debian too.

Changed in dpkg (Ubuntu):
assignee: David Stansby (dstansby) → nobody
status: In Progress → Confirmed
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Just to keep you all informed I'm still working on this in debian.

Revision history for this message
Allan Caeg (allancaeg) wrote : Re: [Bug 332068] Re: grammar adjustment in dpkg

That's good :)

On Wed, 2009-06-17 at 16:59 +0000, David Stansby wrote:
> Just to keep you all informed I'm still working on this in debian.
>

Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

My patch has been accepted upstream now, and has been merged into the git repository. Should be making an appearance downstream soon.

Changed in dpkg (Debian):
importance: Unknown → Undecided
status: Unknown → New
status: New → Fix Committed
Revision history for this message
David Stansby (dstansby-deactivatedaccount) wrote :

Just a thought: Since I have provided a fix, and forwarded it upstream etc. should I remove the bitesize tag so other people don't think this bug isn't being worked on?

Changed in dpkg (Debian):
importance: Undecided → Unknown
status: Fix Committed → Unknown
Revision history for this message
Colin Watson (cjwatson) wrote :

I've just uploaded dpkg 1.15.3ubuntu1 to Karmic, including David's change which was applied in Debian. Thanks!

Changed in dpkg (Ubuntu):
status: Confirmed → Fix Released
Changed in dpkg (Debian):
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.