[REGRESSION] Latest patch on tools/misc.py breaks email_send

Bug #340387 reported by Radu - Eosif Mihăilescu
4
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Critical
Stephane Wirtel (OpenERP)

Bug Description

Versions used {
openobject-server: r1760
openobject-addons: r2235
(both trunk)
}

How to reproduce {
Attempt to trigger sending a mail from within the system, e.g. by opening a case in the CRM and clicking "Send Reminder" -- the attached crash and stack trace results.
}

How to fix {
Again, Python is not my mother tongue but by looking at the code of the tools.email_send(); method and using basic programming logic, I think the enumeration call on line 354 should be prefixed by an existence/setting test similar to the one on line 337.
}

Hope this helps,
@Dexter

Revision history for this message
Radu - Eosif Mihăilescu (csdexter) wrote :
Revision history for this message
Christophe CHAUVET (christophe-chauvet) wrote :

Hi

My original patch have x_header = {} in the method, but when my patch was apply in the branch, x_header was become x_header = None

That's the problem, I see with commiter to correct this

Thanks for the report,

Revision history for this message
Stephane Wirtel (OpenERP) (stephane-openerp) wrote :

Fixed in the last revision of the trunk.

Thank you

Changed in openobject-server:
assignee: nobody → stephane-openerp
importance: Undecided → Critical
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.