display properties notification area icon still fully coloured

Thank you for taking the time to report this bug and helping to make Ubuntu better.
Unfortunately, New panel greyscale icons cannot be added, as adding the greyscale icons will break apps.
The apps use the same icon for the panel notification area and the system menu.
So changing the icon to a greyscale icon will lead to the greyscale icon being displayed in the system menu.

Ideally we would like the app to be patched to use a different icon name for the notification area.
Until then fixing it in Humanity is not possible.

When this issue is resolved kindly mention the new icon name to be used.

Kindly, assign the affected app using the "also affects project". So that the issue is resolved in the app side first. Thanks

i added gnome control-center (which contains the display-properties) though i dont think it brings its own icons but uses the ones provided in the theme :)

The notification icon is displayed by gnome-settings-daemon

The icon is named gsd-xrandr and shipped by gnome-settings-daemon, it would be easy to make it use a gsd-xrandr-notification one and add an icon to the theme

On Tue, 2009-10-06 at 11:10 +0000, Sebastien Bacher wrote:
> The icon is named gsd-xrandr and shipped by gnome-settings-daemon, it
> would be easy to make it use a gsd-xrandr-notification one and add an
> icon to the theme
>
> ** Changed in: humanity-icon-theme (Ubuntu)
> Status: Incomplete => New
>

It would be better to use gsd-xrandr-systray
or *-tray .. since "notification" might be confused with the notify-osd
icons.

But first we need UX to confirm if this is needed. Do we really want to
do this for all icons?

How does the UX team want these icons , just desaturated versions or the
icons in the same style as the rest of the panel icons.

IMO , it is better to have them as desaturated icons than in the same
style as the rest of the greyscale icons

the -notification was not meant as a suggestion but as a -whatever to give the idea about the suggested change

Sorry we want both the code changes AND a new icon; reopening h-i-t task

I'm not convinced that gnome-settings-daemon needs a code change at all here. It isn't like the other examples where it has an application menu icon and a notification area icon. AFAICT, the icon "gsd-xrandr" is only used in the notification area, so it should just be a matter of the theme shipping this icon

Tested current status (humanity-icon-theme 0.4.1-0ubuntu1, gnome-settings-daemon 2.28.0-0ubuntu2).

$ dpkg -S gsd-xrandr.svg
humanity-icon-theme: /usr/share/icons/Humanity/apps/24/gsd-xrandr.svg
gnome-settings-daemon: /usr/share/icons/hicolor/scalable/apps/gsd-xrandr.svg
humanity-icon-theme: /usr/share/icons/Humanity/apps/48/gsd-xrandr.svg

The ones in humanity-icon-theme are currently symlinks to display-capplet.svg. Changing them confirms comment #8: gsd-xrandr.svg is only used in the tray, and the system menu won't be affected. Thus, a new icon seems to be all that is needed.

It's important for all indicator icons to be consistent, but we should only change this icon if it does not affect other places where the icon may already appear (like the preferences menu). So if the indicator icon is a separate icon, we can change it, but only after its design is approved.

Mat, as I wrote above, I tested this and the menu won't be affected. Any other places to check? If none, then gnome-settings-daemon can be removed from this bug and we can start waiting for the new icon design - right?

Fix committed in rev 402.

Loic , mpt has reviewed the icon.
I'v added the icons for both humanity and humanity-dark themes.
From what i'v tested, it doesnt get used in the menu as stated in comments 8 and 9. Should work fine

Loic , the icon was edited a bit again as requested by Mat.

This bug was fixed in the package humanity-icon-theme - 0.4.1ubuntu1

---------------
humanity-icon-theme (0.4.1ubuntu1) karmic; urgency=low

  * Switch to native packaging as I can't get the proper changes in the diff
    otherwise.
  * Update Humanity{,-Dark}/status/24/stock_volume-0.svg from
    lp:humanity@r398; adds a separate icon for non-muted volume applet at
    volume zero; LP: #444548.
  * Add Humanity{,-Dark}/actions/16/system-shutdown-panel.svg from
    lp:humanity@r402; adds new black and white shutdown menu icon for then new
    indicator-session shutdown icon; LP: #432635.
  * Update Humanity{,-Dark}/apps/{22,24,48}/gsd-xrandr.svg to icons from
    lp:humanity@r403; adds new black and white icons for display capplet and a
    Humanity-Dark symlink; LP: #443311.

 -- Loic Minier <email address hidden> Sat, 10 Oct 2009 00:05:49 +0200

Loic Minier , there seems to have been an error in the last update!

The gsd-xrandr icons *alone* must have been changed from symlinks to files gsd-xrandr.svg

But seems that the gnome-display-properties.svg was changed from a color version to a greyscale icon.
This will make the greyscale icon be displayed in the menu.
Was this a purposeful change?

Just to be clear:
/usr/share/icons/Humanity/apps/24/gnome-display-properties.svg --> should be a color icon
/usr/share/icons/Humanity/apps/24/gsd-xrandr.svg --> should be greyscale icon.

Only this change needs to be done correctly.

I think it happened due to the non-native packaging I was trying to keep using when preparing the update; I thought I had redone it properly when I switched to native, but it seems not, not sure why; uploading a fix.

This bug was fixed in the package humanity-icon-theme - 0.4.1ubuntu2

---------------
humanity-icon-theme (0.4.1ubuntu2) karmic; urgency=low

  * Fix Humanity/apps/24/gnome-display-properties.svg to be colourful instead
    of greyscale; not sure how this happened; LP: #443311.

 -- Loic Minier <email address hidden> Sat, 10 Oct 2009 10:11:09 +0200

Now both the icon in the menu and the one in the system tray are in colour again.

If comment #16 is correct, the current status is indeed wrong. At present gsd-xrandr.svg soft-links to display-capplet.svg, which soft-links to gnome-display-properties.svg, the latter being an actual file with the colourful icon. gsd-xrandr.svg should stop being a symlink.

So let me summarise how these icons are used and what we expect:
- gnome-display-properties: used in display-properties.desktop for the menu entry and the gnome-display-properties binary for the notification area, expected to be colourful when used in application lists,
- display-capplet: no idea where this is used
- gsd-xrandr: used in gnome-settings-daemon's libxrandr.so plugin for the notification bubble

So the expectations for each icon as I see them:
- gnome-display-properties: colourful when size 48, grey scales when size << 48
- display-capplet: no idea
- gsd-xrandr: I'd guess grey scales all the time

What's in lp:humanity right now:
- gnome-display-properties: always a real file, colourful at size 24 and 48, only in Humanity
- display-capplet: symlink to gnome-display-properties at size 24 and 48, only in Humanity
- gsd-xrandr: real file at size 22 and 24, and at size 48 in Humanity-Dark, symlink to display-capplet at size 48 in Humanity, colourful at size 48, grey scales at size 22 and 24
./Humanity/apps/48/gsd-xrandr.svg

Now in humanity-icon-theme 0.4.1ubuntu2:
- gnome-display-properties: same as lp:humanity
- display-capplet: same as lp:humanity
- gsd-xrandr: same as lp:humanity except for ./Humanity/apps/24/gsd-xrandr.svg which is a real file with grey scales in lp:humanity and a symlink to display-capplet.svg in the package

This bug was fixed in the package humanity-icon-theme - 0.4.1ubuntu3

---------------
humanity-icon-theme (0.4.1ubuntu3) karmic; urgency=low

  * Also update Humanity/apps/24/gsd-xrandr.svg to be a real file in grey
    scales instead of a symlink to display-capplet.svg; LP: #443311.

 -- Loic Minier <email address hidden> Sat, 10 Oct 2009 15:19:50 +0200

I uploaded a fix, I believe that ./Humanity-Dark/apps/48/gsd-xrandr.svg in lp:humanity should be fixed to be a symlink to ../../../Humanity/apps/48/display-capplet.svg. Could someone please fix this?

md5sum:
20117fc6f176c09a3ce89bf53f960ca3 ./Humanity-Dark/apps/48/gsd-xrandr.svg
20117fc6f176c09a3ce89bf53f960ca3 ./Humanity/apps/48/gnome-display-properties.svg

ls -i:
761585 ./Humanity/apps/48/gnome-display-properties.svg
764745 ./Humanity-Dark/apps/48/gsd-xrandr.svg

I fail to see why the icons should be different at different sizes.

They indeed are; I've tried resizing my top panel, and at 23 pixels the gnome-display-properties icon is monochrome [!] (this is with 0.4.1ubuntu2), at 24 and above it's coloured, and at 32 and above it's the gnome-power-manager icon that becomes coloured.

Moreover, there is only one icon in my top bar (that of nm-applet) that scales smoothly with panel size. Most of the others (launchers included) are merely re-centred until they jump in size at particular panel heights (24, 32, 48, etc), and the other two (those of indicator-applet and indicator-applet-session) are never resized.

Is this all really intended?

Loic as mentioned ,
We dont want to be adding symlinks from one theme to another since this would make it difficult to make the tar.gz that users use to install the -dark version separately .

pablomme ,
Only the 22,24 px icons are greyscale , the bigger 48px sizes in color is intended.
As the bigger icons are used in the apps. example the color battery status 48px icon is used in the power history window , so this is to maintain the consistency.