Shutdown icon should be displayed in disconnected state

On Fri, 2009-09-18 at 17:52 +0000, David Siegel wrote:
> The conflation of status icons and the shutdown icon is confusing, but
> if we do not display the shutdown icon at least some of the time, users
> may be unable to discover how to shut down their machines. Please revert
> to the Jaunty behavior of displaying the shutdown icon when the user's
> status is disconnected.

This needs a lot of specification, like when the icon is shown and when
it isn't.

  status incomplete
  milestone ubuntu-10.04-ui-freeze
  importance medium

Ted, I am recommending we use the same behavior used in Jaunty for Karmic, which I can describe only from observation -- perhaps mpt knows more:

 * When the session starts the icon displayed in the session menu is the Shut Down icon until I effect a status change by opening Empathy/Pidgin or by setting my status in the session menu.
 * Once I have connected, the status menu icon reflects my status (Available, Away, etc.) until I disconnect by setting my status to Offline in the session menu, or by quitting Empathy/Pidgin. Once offline, the session menu icon is set back to the Shut Down icon.

In other words, the session menu displays the Shut Down icon if and only if I am in a disconnected state; otherwise I am connected and the session menu icon should be a status icon determined by my current status.

The justification for a UIF exception for 9.10 is that, in informal user testing, we discovered that without the shut down icon being displayed in the session menu, ***users could not figure out how to shut down their machines***. This may be indicative of a deeper conceptual flaw in the design of the session menu, but for the time being, reverting to Jaunty's behavior with regard to the display of the Shut Down icon will make it more likely that users will be able to turn off, suspend, hibernate, restart their computers.

David Siegel tells me the code changes are ready (where?) and Daniel Fore, Humanity upstream, provided proposed icons which I'll attach here.

I've cleaned up the bug's state to reflect affected products and some of the proposed changes. What's missing from this bug are the proposed indicator-session code changes (patch/diff).

Next step is negotiating a freeze exception; I went ahead and subscribed release team for you folks. Please discuss the rationale for these changes with the release team in this bug.

So which revs? 50 included through 55? Is that final?

Code-wise I'm okay with the changes, but conceptually this seems a bit flawed to me. Now, the session indicator consistently displays the online status. With those changes, it will switch back and forth between "shutdown" and "online", and the original problem of not being able to figure out where to shutdown remains when the user is online.

If the proposed changes are considered a stopgap measure for Karmic, with a more consistent design being planned for Lucid, I'm fine with this. But I wouldn't treat it as a permanent solution.

Yes, this is a stopgap measure; for Lucid I'm examining how and whether to redistribute these menu items. In the meantime, with this change, the shutdown icon won't be visible all the time, but it will at least be visible until you have set up an IM account and connected for the first time. So you will have a much better chance to learn where it is.

Approved then.

The icons are not in lp:humanity; could someone please add them?

Should they go in /apps or /status? Do we need a Humanity-Dark version?

Thanks,

Also , the icon needs a new name. otherwise this greyscale shutdown icon will be used in the apps.

Loïc Minier [2009-10-07 11:51 -0000]:
> The icons are not in lp:humanity; could someone please add them?

One of the commits adds it, though?

@Martin: in lp:humanity? I pull-ed again and I don't see it. Looking for indicator we have:
./Humanity-Dark/status/22/indicator-messages.svg
./Humanity-Dark/status/22/indicator-messages-new.svg
./Humanity/apps/48/indicator-applet.svg
./Humanity/apps/16/indicator-applet.svg
./Humanity/apps/24/indicator-applet.svg
./Humanity/apps/32/indicator-applet.svg
./Humanity/apps/22/indicator-applet.svg
./Humanity/status/22/indicator-messages.svg
./Humanity/status/22/indicator-messages-new.svg

and for shutdown:
./Humanity/actions/48/system-shutdown.svg
./Humanity/actions/16/system-shutdown.svg
./Humanity/actions/24/system-shutdown.svg
./Humanity/actions/32/system-shutdown.svg
./Humanity/apps/48/gnome-shutdown.svg
./Humanity/apps/48/xfsm-shutdown.svg
./Humanity/apps/24/gnome-shutdown.svg
./Humanity/apps/24/xfsm-shutdown.svg

but no indicator-system-shutdown. Or perhaps lp:humanity points to something else now?

Oh ok, I see it in the indicator-session branch now.

I think the indicator-session package itself should ship a free (as in "not affected by trademark policy") icon in hicolor, which fits the other hicolor icons, i. e. the colourful ones we had in Jaunty. humanity can override that with a gray one.

Added icons in rev 399

On Wed, 2009-10-07 at 13:43 +0000, Martin Pitt wrote:
> I think the indicator-session package itself should ship a free (as in
> "not affected by trademark policy") icon in hicolor, which fits the
> other hicolor icons, i. e. the colourful ones we had in Jaunty. humanity
> can override that with a gray one.

Ofcourse :) That's what's in the branch. I was reading your mind ;)

On Wed, 2009-10-07 at 10:00 +0000, Loïc Minier wrote:
> So which revs? 50 included through 55? Is that final?

Honestly, I'm not sure. It's changed so much. I don't know who can say
if it's final or not. I wouldn't feel comfortable saying that.

Packaging pushed to lp:~ubuntu-desktop/indicator-session/ubuntu

This bug was fixed in the package indicator-session - 0.1.7-0ubuntu1

---------------
indicator-session (0.1.7-0ubuntu1) karmic; urgency=low

  * Upstream release 0.1.7
    * Changing the icon so that if you are disconnected it is
      'system-shutdown-panel' and making sure that we see it
      sometimes by not allocating the EmpathyAccountManager isn't
      allocated until status is set. (LP: #432635)
      * Also fixes by happenstance: (LP: #444170 and LP: #437065)
    * Handling the locking of the screensaver so that we ensure
      the screensaver is active before suspending. Also, we
      throttle it to ensure it doesn't start until after suspend.
      (LP: #444391)
    * Asynchronized the menu handling so that it's in the right
      order with async startup. (LP: #440484)
    * String change, "New Session" to "Switch User" (LP: #444494)
  * Removed debian/patches/switch_user_lp-444494.patch

 -- Ted Gould <email address hidden> Thu, 08 Oct 2009 11:12:07 -0400

This bug was fixed in the package humanity-icon-theme - 0.4.1ubuntu1

---------------
humanity-icon-theme (0.4.1ubuntu1) karmic; urgency=low

  * Switch to native packaging as I can't get the proper changes in the diff
    otherwise.
  * Update Humanity{,-Dark}/status/24/stock_volume-0.svg from
    lp:humanity@r398; adds a separate icon for non-muted volume applet at
    volume zero; LP: #444548.
  * Add Humanity{,-Dark}/actions/16/system-shutdown-panel.svg from
    lp:humanity@r402; adds new black and white shutdown menu icon for then new
    indicator-session shutdown icon; LP: #432635.
  * Update Humanity{,-Dark}/apps/{22,24,48}/gsd-xrandr.svg to icons from
    lp:humanity@r403; adds new black and white icons for display capplet and a
    Humanity-Dark symlink; LP: #443311.

 -- Loic Minier <email address hidden> Sat, 10 Oct 2009 00:05:49 +0200

 Humanity_0.4.2.1

This bug is still present in the Karmic release candidate. Why is it marked as "fix released"?

Andreas:

The current behaviour (in karmic RC) is to display the shutdown icon until your IM status has been set. Once empathy/pidgin connects and sets your status it will change to the status icon. I have confirmed this behaviour a clean install.

Works as described above in [comment25] upgrades too

Ken: Yes, this is the current behaviour. And according to the description of this bug, it is wrong. So again: Why is it marked as "fix released"?

Andreas: the report was describing a prior situation where we did not use the power button icon in the session menu anymore (not at all). We were only showing online status, and the Shutdown action was at the bottom of the online/offline menu. The proposed change which was tracked in this bug and is now implemented is to use the power icon for the session menu (online/offline/shutdown) until you first switch to being online. After this point, the icon is either online or offline. This allows user to discover the place to do the shutdown action.

Loic, thanks for the clarification.

After talking with Ken Vandine. He mentioned to bring this up in this bug for consideration in Lucid. It would make much more sense to have the power icon show for any time that there is NO IM service in use on the computer. Since IM clients can set an offline state, the offline status icon should only be used for that. This would be a definite difference between the two cases.

Scenarios:
1)
-Computer starts up and loads desktop with power icon
-user starts IM Client and status icon comes up with current status in IM client
-user sets offline state IN the IM client and status icon shows as offline to signify IM clients are running but user is shown as offline.

2)
-Computer starts up and loads desktop wtih power icon
-user starts IM Client and status icon comes up with current status in IM client
-user exits IM client and status icon changes to power icon to signify no IM clients are running

This is not an issue for Lucid, because it will have separate Me and session menus. The session menu will constantly have a power icon as its title.
<https://wiki.ubuntu.com/MeMenu>
<https://wiki.ubuntu.com/SessionMenu>