On startup Gnome Keyring asks for password in the background

Bug #447886 reported by Jamie Bennett
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ubuntu Netbook Remix Launcher
Fix Released
High
Neil J. Patel
gnome-keyring (Ubuntu)
Invalid
Wishlist
Unassigned
Karmic
Invalid
Wishlist
Unassigned
netbook-launcher (Ubuntu)
Fix Released
Medium
Neil J. Patel
Karmic
Fix Released
Medium
Neil J. Patel

Bug Description

Binary package hint: netbook-launcher

On starting the Netbook Remix, a grayed-out padlock is shown in the panel, This is because Network Manager is trying to access the internet but needs a password to proceed. There is no dialog box shown to enter the password until you click the padlock icon.

Expected:

Password dialog box is shown on startup allowing the user to enter their password to unlock Gnome Keyring and access the internet.

ProblemType: Bug
Architecture: i386
Date: Sat Oct 10 10:35:43 2009
DistroRelease: Ubuntu 9.10
GConfNonDefault:
 /apps/netbook-launcher/disable_single_instance=false
 /apps/netbook-launcher/force_low_graphics=false
MachineType: Dell Inc. Inspiron 1011
NonfreeKernelModules: wl
Package: netbook-launcher 2.1.10-0ubuntu1
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-11-generic root=UUID=c1fef63a-97b1-4733-b6ba-ed8d6a79380d ro quiet splash
ProcEnviron:
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-11.38-generic
RelatedPackageVersions:
 xserver-xorg 1:7.4+3ubuntu5
 libgl1-mesa-glx 7.6.0-1ubuntu2
 libdrm2 2.4.14-1ubuntu1
 xserver-xorg-video-intel 2:2.9.0-1ubuntu1
 xserver-xorg-video-ati 1:6.12.99+git20090825.fc74e119-0ubuntu3
SourcePackage: netbook-launcher
Tags: ubuntu-unr ubuntu-unr
Uname: Linux 2.6.31-11-generic i686
XorgConf: Error: [Errno 2] No such file or directory: '/etc/X11/xorg.conf'
dmi.bios.date: 07/29/2009
dmi.bios.vendor: Dell Inc.
dmi.bios.version: A06
dmi.board.name: CN0Y53
dmi.board.vendor: Dell Inc.
dmi.board.version: A06
dmi.chassis.type: 8
dmi.chassis.vendor: Dell Inc.
dmi.chassis.version: A06
dmi.modalias: dmi:bvnDellInc.:bvrA06:bd07/29/2009:svnDellInc.:pnInspiron1011:pvrA06:rvnDellInc.:rnCN0Y53:rvrA06:cvnDellInc.:ct8:cvrA06:
dmi.product.name: Inspiron 1011
dmi.product.version: A06
dmi.sys.vendor: Dell Inc.
fglrx: Not loaded
system:
 distro: Ubuntu
 architecture: i686kernel: 2.6.31-11-generic

Revision history for this message
Jamie Bennett (jamiebennett) wrote :
Revision history for this message
Paul Larson (pwlars) wrote :

suspect this might really be a gnome-keyring issue

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the bug report. This particular bug has already been reported, but feel free to report any other bugs you find.

Changed in gnome-keyring (Ubuntu):
importance: Undecided → Wishlist
status: New → Invalid
Revision history for this message
Sebastien Bacher (seb128) wrote :

the duplicate comment was a bit quick but that's not a keyring issue, either a dialog focus one or a client one rather

Revision history for this message
Jamie Bennett (jamiebennett) wrote :

The padlock icon allows a right click that offers the option to 'un-minimise' which could mean that its either started before the launcher or that its somehow started minimised?

Revision history for this message
Loïc Minier (lool) wrote :

Does someone reproduce the issue? It might a race on startup

Revision history for this message
Michael Terry (mterry) wrote :

I suspect to reproduce, you just need to enable autologin and then have a saved wifi connection that needs a password. Since your gnome keyring is still locked (isn't auto-unlocked when you autologin), NM needs to ask you to unlock it. (haven't tested myself to reproduce, just have seen this sort of thing before)

Revision history for this message
Loïc Minier (lool) wrote :

I'd like one other person to reproduce to see if it's a common issue; I think I understand what's going on, but it's the first report we ever got.

Changed in netbook-launcher (Ubuntu):
milestone: none → karmic-updates
Revision history for this message
Loïc Minier (lool) wrote :

Tracking for SRUs, seems too intrusive to fix in karmic

Revision history for this message
Jamie Bennett (jamiebennett) wrote :

Oliver Grawert saw the problem but here are the instructions to reproduce. Install with no net connection and select auto-login. When the new install comes up join a network and enter your credentials. From then on every boot results in a grey padlock appearing on the left hand side of the panel waiting for you to enter your password.

Revision history for this message
Paolo Sammicheli (xdatap1) wrote :

Hi,

I just installed Karmic Beta Netbook Remix in a Dell Mini 10v and I got this bug.

In the first session i saved my home network and then at first reboot I noticed that It was offline but i needed time to discover the window in background. I have autologin like reporter.

The lock in top right corner is a little clue (look screenshot) but it's an usability problem to fix, imho

Loïc Minier (lool)
Changed in netbook-launcher (Ubuntu Karmic):
status: New → Confirmed
Loïc Minier (lool)
Changed in netbook-launcher (Ubuntu Karmic):
milestone: karmic-updates → ubuntu-9.10
Revision history for this message
Paul Larson (pwlars) wrote :

I'm able to reproduce this also, the important pieces to make it happen are:
1. a saved wifi connection
2. you have to setup your gnome-keyring with a password, rather than leaving it blank
3. reboot the system

Workarounds are pretty simple and could probably be release noted if this can't be fixed for final image. Either no password can be provided for the keyring, and you will never be prompted for it. Or, if you do provide a password, you'll need to actually click the "lock icon" that comes up when the system boots to bring the password prompt to the foreground. However, it is correct that this is a fairly significant usability issue and many are likely to run into the problem.

Changed in netbook-launcher (Ubuntu Karmic):
importance: Undecided → Medium
Revision history for this message
Paul Larson (pwlars) wrote :

Forgot to mention one item in the above list - auto-login needs to be enabled too I believe

David Barth (dbarth)
Changed in netbook-remix-launcher:
assignee: nobody → Neil J. Patel (njpatel)
importance: Undecided → High
milestone: none → ubuntu-9.10
status: New → Triaged
Revision history for this message
David Barth (dbarth) wrote :

Ok, we'll try to fix this one in time for the last karmic upload window on Monday.

Some comments about a possible resolution so that interested parties can comment and exchange while a fix is being worked on:
 - the bug seems to be triggered by gnome-keyring being launched early in the session, and then being masked by netbook-launcher when it starts later
 - a possible fix could be to be less aggressive in the way netbook-launcher raises it's main window on startup. The call to gtk_window_present may be a bit too much
 - some wnck wizardry might help in placing netbook-launcher just below the gnome-keyring window.

Changed in netbook-remix-launcher:
assignee: Neil J. Patel (njpatel) → Jason Smith (jassmith)
Changed in netbook-launcher (Ubuntu Karmic):
assignee: nobody → Jason Smith (jassmith)
Revision history for this message
Loïc Minier (lool) wrote :

I've pushed a tentative fix to my PPA, but can not reproduce the problem to verify the fix.

I changed /etc/xdg/autostart/netbook-launcher.desktop to Exec=/usr/bin/netbook-launcher-wrapper which is a shell script with:
#/bin/sh
set -e
sleep 5
exec /usr/bin/netbook-launcher "$@"

But gnome-keyring appears on top of n-l when it loads, with or without my fix.

If someone with the issue could test the packages in my PPA that would be appreciated.

Revision history for this message
Jason Smith (jassmith) wrote :

This is somewhat confusing. After looking at the code for nl-window, it appears it doesn't actually call gtk_window_present on itself at all. It does that for transient windows assigned to itself but not on itself. I think the keyring is actually getting minimized(?) rather than being obstructed from view. I am looking into fixing that.

Revision history for this message
Jason Smith (jassmith) wrote :

Ok I have a more in depth break down of the bugs behavior.

1) Gnome Keyring window is opened (in the forground)
2) Netbook Remix Launcher is opened (in the background)
3) Window manager, for some reason performs a focus event on NL (netbook launcher)
4) In response, NL performs a wnck_screen_toggle_showing_desktop
5) Gnome Keyring window gets minimized

Resolving this issue is somewhat complex since the window manager behavior is not exactly defined. I hope that by setting the launcher as "keep below" it wont focus and thus wont be triggered. Though this is not reliable. We could try to delay the initialization of our wnck callbacks and try to work around that first triggering focus, however this will be a race condition. We could merely ignore the first focus, but again this behavior is undefined.

I think the best option (from NL's POV) is to merely get a wnckprop out of the gnome keyring, and use one of its properties to unminimize it if we find it. Kinda hacky really but I am not sure what else to do. I suppose we could implement our own form of show_desktop that ignores these kinds of windows, but that seems even more hacky.

A proper solution would be to make it so that gnome keyring windows simply refuse to minimize.

Revision history for this message
David Barth (dbarth) wrote :

I agree with the solution to target only g-keyring's wnckprops: this should limit potential regressions.

Revision history for this message
Jason Smith (jassmith) wrote :

I am still having significant issues duplicating this bug despite following instructions posted here. I do strongly believe this bug to be a race condition however. I have attached a branch that may help in this regard, if anyone can beta test it that is effected by the bug, please let me know.

Re: re-raising g-keyring windows. After playing around with it some more it is somewhat annoying to work with if you do not want to fill in the keyring request right away. Basically whenever one of those keyring windows is around you cannot in any way access the launcher. Is this acceptable?

Revision history for this message
Jamie Bennett (jamiebennett) wrote :

Jason,

I've just checked out your branch and unfortunately it still doesn't work. This time you get to see the gnome-keyring dialog box for around a second before the netbook UI is shown over the top of it. So it looks like the dialog box is being obscured somewhere later in the chain.

Revision history for this message
Jamie Bennett (jamiebennett) wrote :

Also, as the dialog box is in the background, it seems any subsequently launched apps don't grab the focus. Launch the Terminal app with gnome-keyring in the background and the cursor isn't active until you click the Terminal window.

Loïc Minier (lool)
Changed in netbook-launcher (Ubuntu Karmic):
assignee: Jason Smith (jassmith) → Neil J. Patel (njpatel)
status: Confirmed → In Progress
Changed in netbook-remix-launcher:
assignee: Jason Smith (jassmith) → Neil J. Patel (njpatel)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package netbook-launcher - 2.1.12-0ubuntu2

---------------
netbook-launcher (2.1.12-0ubuntu2) karmic; urgency=low

  * New patch, 60_unminise-gnome-keyring, unminimise gnome-keyring windows
    once on startup, in an idle handler, as the desktop toggling on
    netbook-launcher startup causes the window to be minimized; written by
    Neil Patel; LP: #447886.

 -- Loic Minier <email address hidden> Mon, 26 Oct 2009 11:32:32 +0000

Changed in netbook-launcher (Ubuntu Karmic):
status: In Progress → Fix Released
Revision history for this message
Jason Smith (jassmith) wrote :

Fixed it :)

Changed in netbook-remix-launcher:
status: Triaged → Fix Committed
Jason Smith (jassmith)
Changed in netbook-remix-launcher:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.