Desktop entries are not generated from .desktop.in files in auto mode

Bug #451175 reported by David Planella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-distutils-extra (Ubuntu)
Fix Released
High
Martin Pitt

Bug Description

Binary package hint: python-distutils-extra

While trying to fix bug 449411 in the onboard package, I noticed that using the auto module in setup.py translatable strings are extracted from .desktop.in files correctly, but:

* .desktop files are not generated
* the built package installs .desktop.in files in /usr/share/<projectname> (might need to report this as a separate bug, though)

According to Martin on IRC:

<pitti> dpm: right, I then just noticed that the patch was already applied
 dpm: it's a bit weird, if I do ./setup.py install --root=/tmp/x, the desktop.in files get installed automagically
 dpm: but with a .deb build they aren't

A workaround for .desktop files not being generated is to use a setup.cfg file and explicitly listing them there. As an example, here's what the onboard setup.cfg file looks like:

[build_i18n]
desktop_files=[ ('share/applications', ['data/onboard.desktop.in', 'data/onboard-settings.desktop.in']) ]

Revision history for this message
Martin Pitt (pitti) wrote :

Ah, it's because it gets confused because the .desktop.in files are in data/.

Changed in python-distutils-extra (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Martin Pitt (pitti) wrote :

r142

Changed in python-distutils-extra (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-distutils-extra - 2.12

---------------
python-distutils-extra (2.12) unstable; urgency=low

  * auto.py: Auto-install GtkBuilder files which have attributes in the
    <interface> tag.
  * auto.py: Extract translatable strings from GtkBuilder files which have
    attributes in the <interface> tag. (LP: #451170)
  * auto.py: Properly handle *.{desktop,notifyrc}.in files in data/.
    (LP: #451175)

 -- Martin Pitt <email address hidden> Wed, 14 Oct 2009 13:53:43 +0200

Changed in python-distutils-extra (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Éric Araujo (merwok) wrote :

In the diff,
+ not f.endswith('.desktop.in') and not f.endswith('*.notifyrc.in'):
looks like a bug (because of “*”).

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Eric! Fixed in bzr.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.