Partition type 0x12 could be hidden

Patch sent upstream for review and inclusion.

This bug was fixed in the package devicekit-disks - 009-1ubuntu2

---------------
devicekit-disks (009-1ubuntu2) lucid; urgency=low

  Resynchronize to Debian git head, no remaining Ubuntu changes.

  [ Michael Biebl ]
  * debian/patches/09-reiserfs-support.patch
    - Add support for ReiserFS.

  [ Martin Pitt ]
  * Add debian/local/ubuntu.pkla: Allow passwordless file system operations
    for local foreground admin user sessions on Ubuntu. Install it in
    debian/rules. (LP: #465054)
  * Add 02-allow-simulated-smart.patch: Allow simulated SMART data on
    non-SMART devices. This is both useful for testing DK-disks itself, as
    well as recreating bugs with SMART handling. (fd.o #24772)
  * Add 03-hide-configuration-partition-12.patch: Hide Compaq recovery
    partition type 0x12. (fd.o #24999, LP: #451304)
  * Add 04-hide-wd-smartware-partition.patch: Ignore Western Digital SmartWare
    partitions. (fd.o #25009, LP: #474790)
  * Add 06-guid-partition-flags.patch: Fix setting flags for GUID partitions.
    (fd.o #25034)
 -- Martin Pitt <email address hidden> Wed, 11 Nov 2009 17:42:19 +0100

Impact:
A regression in the hal-->devicekit-disks transition resulted in hidden recovery partitions appearing after an upgrade to 9.10. Some ACER systems use a hidden recovery partition of type 0x12 (label 'PQSERVICE'). These hidden partitions were hidden from the user in 9.04, but are not properly hidden in 9.10 with devicekit-disks 007-2ubuntu3. In 9.10 it is possible for the user to mount these hidden partitions and modify the files on them, inadvertently breaking the system recovery feature.

Fix:
The patch 03-hide-configuration-partition-12.patch fixes this behavior on 9.10.

TEST CASE:
On a system that contains a hidden partition of type 0x12, install 9.04. Notice that the partition cannot be accessed from the file manager or the Places menu. Upgrade to 9.10; the hidden partition will now be visible in the file manager. Update to a patched version of devicekit-disks. The hidden partition should not be accessible from the file manager or Places menu.

Regression potential:
Users who rely on access to a hidden partition of type 0x12 will no longer have access to the partition. I expect this is a very small set of users.

This looks good; I also want to fold the fix for bug 419663 into the next SRU, once I get a confirmation that my PPA package works.

I'll sponsor this in due course.

Uploaded to karmic-proposed queue. Needs to be processed by an SRU team member now.

Accepted devicekit-disks into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Confirmed that devicekit-disks_007-2ubuntu4 from karmic-proposed hides partitions of type 0x12. I haven't noticed any side effects.

This bug was fixed in the package devicekit-disks - 007-2ubuntu4

---------------
devicekit-disks (007-2ubuntu4) karmic-proposed; urgency=low

  [ Martin Pitt ]
  * Add 09-fix-atasmart-crash.patch: Fix common crash when
    devkit-disks-helper-ata-smart-collect succeeds, but returns invalid base64
    data on stdout. (fd.o #25043, LP: #419663)

  [ Steve Magoun ]
  * Backport 03-hide-configuration-partition-12.patch from Lucid to fix
    regression that caused Acer and other hidden partitions to appear
    after upgrading to Karmic (LP: #451304)
 -- Martin Pitt <email address hidden> Wed, 11 Nov 2009 23:29:29 +0100