[Ubuntu] [hardy] OpenOffice should use Launchpad integration library instead of hardcoded URLs

it doesn't work on amd64, opens the openoffice.org-amd64 page by default

On Fri, Sep 22, 2006 at 09:27:36AM -0000, Matthias Klose wrote:
> it doesn't work on amd64, opens the openoffice.org-amd64 page by default

The -P option to launchpad-integration should address this issue easily.

--
 - mdz

It doesn't look like a launchpad-integration bug, does it?

Agreed; this problem is only with openoffice.org

I'm not sure I understand the problem but I thought I'd chip in anyway. If I open OOo 2.2 in Feisty and select 'Help > Report a Bug' I get sent to the following URL: https://launchpad.net/ubuntu/+source/openoffice.org/+filebug

The current implementation is in ooo-build/patches/src680/ubuntu-lpi.diff.

16:16 < cjwatson> you should just need to call 'launchpad-integration -P
                  openoffice.org -i' etc. rather than hardcoding the URLs

I changed the code to run the program like you mentioned and it doesn't work it gives this as output (I run oowriter then select one of the menu items for LP):

ccheney@desktop-c2d:~$ oowriter --help
ccheney@desktop-c2d:~$ Traceback (most recent call last):
  File "<string>", line 5, in <module>
  File "/usr/share/launchpad-integration/launchpadintegration/main.py", line 48, in main
    pkginfo = PackageInfo.fromPackageName(options.package, logger)
  File "/usr/share/launchpad-integration/launchpadintegration/packageinfo.py", line 216, in fromPackageName
    '"%s"' % package)
launchpadintegration.packageinfo.PackageNotFoundError: Could not look up package info for " openoffice.org -i"
Traceback (most recent call last):
  File "<string>", line 5, in <module>
  File "/usr/share/launchpad-integration/launchpadintegration/main.py", line 48, in main
    pkginfo = PackageInfo.fromPackageName(options.package, logger)
  File "/usr/share/launchpad-integration/launchpadintegration/packageinfo.py", line 216, in fromPackageName
    '"%s"' % package)
launchpadintegration.packageinfo.PackageNotFoundError: Could not look up package info for " openoffice.org -t"
Traceback (most recent call last):
  File "<string>", line 5, in <module>
  File "/usr/share/launchpad-integration/launchpadintegration/main.py", line 48, in main
    pkginfo = PackageInfo.fromPackageName(options.package, logger)
  File "/usr/share/launchpad-integration/launchpadintegration/packageinfo.py", line 216, in fromPackageName
    '"%s"' % package)
launchpadintegration.packageinfo.PackageNotFoundError: Could not look up package info for " openoffice.org -b"

Any ideas?

Chris

It appears the bug is due to my call somehow causing all the parameters to be treated as one. Adding debugging to the launchpad-integration call shows it all being stuck in $1 instead of $1 $2 $3 like it should be.

Using the binary is blocked by a bug causing all parameters to be treated as one parameter, which causes launchpad-integration to barf.

I filed the bug in the upstream tracker and created a LP bug #213052 to track it.

Also, I created a work-around shell script:

ccheney@laptop-c2d:~$ cat ooo87965.execute.sh
#!/bin/sh
program=$1
shift
$program $@

This appears to work.

Actually the above works but not the way I had wanted it to:

This works good enough:

#!/bin/sh
$1

Just got the test debs built and it works now, yipee!

This bug was fixed in the package openoffice.org - 1:2.4.0-3ubuntu2

---------------
openoffice.org (1:2.4.0-3ubuntu2) hardy; urgency=low

  * debian/rules:
    - Reenable java on powerpc. Closes LP: #205923
  * ubuntu/ooo87965.execute.sh:
    - Added to work around bug executing launchpad-integration script.
  * Resynchronise with ooo-build (r12125).
    - ooo-build/patches/src680/human-icons-add.diff:
      . Fallback properly to human icon theme.
        Closes LP: #106186, #138360, #153598, #178455
    - ooo-build/patches/src680/ooo85931.inconsistent.getentrypos.diff:
      . Added to correct add templates issue on amd64. Closes LP: #62591
    - ooo-build/patches/src680/ubuntu-lpi.diff:
      . Changed to use launchpad-integration script. Closes LP: #46546

 -- Chris Cheney <email address hidden> Mon, 07 Apr 2008 20:05:52 -0500