Files missing VIM mode lines

Bug #524279 reported by Numérigraphe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Undecided
Unassigned
Nominated for 5.0 by Numérigraphe
Nominated for Trunk by Numérigraphe

Bug Description

The convention for the moment is to end each python file with a vim mode line. There are offending files in the current codebase, which you can find out with GNU grep:
    grep -R --files-without-match "^# vim:" . |grep ".py$"
and fix with bash and GNU grep:
    for i in $(grep -R --files-without-match "^# vim:" . |grep ".py$" ); do echo -e "\n# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:" >>$i ; done
Lionel.

Tags: long-term

Related branches

Revision history for this message
Numérigraphe (numerigraphe) wrote :
Revision history for this message
Numérigraphe (numerigraphe) wrote :
description: updated
Revision history for this message
Numérigraphe (numerigraphe) wrote :
Changed in openobject-server:
status: New → Won't Fix
Revision history for this message
Numérigraphe (numerigraphe) wrote :

I know you want to lower the bug count, but this one can be fixed with 3 lines of BASH an has absolutely NO IMPACT on the code.
At least can you please mark it "opinion"? So that eventually you can chose between enforcing the convention (this bug), or changing the convention (Bug #522708)

Revision history for this message
Cristian Salamea (ovnicraft) wrote :

IHMO this is not a bug, what happens with emacs users, project must be open with editors, and i suggest remove from all files.

my 2c,

tags: added: long-term
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

This has now been fixed after merging Lionel's merge proposals, however this is still not seen technically as a bug, and I'd prefer people not to spend time on this in the future.
Thanks!

Changed in openobject-server:
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.