please merge git-buildpackage 0.4.65 from Debian unstable (full patch included)

Bug #525116 reported by Rolf Leggewie
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-buildpackage (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: git-buildpackage

!"(/()/$"§ Launchpad ate my carefully crafted previous bug report and decided to oops on me again today, so I have to type it once more GRR!

git-buildpackage has only recently in 0.4.64 gained proper support for dpkg v3. I'm sure a minimal patch could be backported, but upstream fixed a couple of other bugs as well, so at this point I think it makes more sense to merge. I therefor request an FFe for git-buildpackage.

Full patch for current lucid version included (and don't you dare oopsing on me again, LP!)

+git-buildpackage (0.4.65ubuntu1) lucid; urgency=low
+
+ * merge from Debian unstable. delta unchanged from 0.4.63ubuntu1
+
+ -- Rolf Leggewie <email address hidden> Sun, 21 Feb 2010 02:03:39 +0100
+
+git-buildpackage (0.4.65) unstable; urgency=low
+
+ [ Guido Günther ]
+ * [07d54ef] gbp-add-patch: Strip path from patchname and handle missing
+ files gracefully.
+ * [a7fe7c4] Add basic bash completion for git-buildpackage (Closes: #567313)
+ - thanks to Siegfried-Angel Gevatter
+ * [aec185f] Add gbp-{clone,pull,pq} to description
+ * [24ac91c] bash-completion: Add git-dch, git-import-{orig,dsc} and tab
+ completion for branch names.
+ * [cbc0577] Add GitRepository.get_remotes() to easily query remote branches
+ * [4654425] gbp-clone: Add --all to track all remote branches
+
+ [ Matthijs Kooijman ]
+ * [2874c23] Make the commit message for upstream imports configurable.
+ This adds the import-msg commandline and configuration file option
+ to change the commit message. (Closes: #474457)
+
+ [ Jon Bernard ]
+ * [ad9b7f5] Prevent git-add-patch from being gzip'd
+
+ -- Guido Günther <email address hidden> Sat, 13 Feb 2010 12:37:41 +0100
+
+git-buildpackage (0.4.64) unstable; urgency=low
+
+ * [ab40623] Add gbp-add-patch to easily commit patches from debian/patches
+ * [34c1c43] Allow to skip imports of same version Based on a patch by
+ Christoph Göhre.
+ * [ea6311e] DscFile: Parse name of debian.tar.gz
+ * [237a547] Import version 3 source format (Closes: #552771)
+
+ -- Guido Günther <email address hidden> Mon, 25 Jan 2010 22:08:26 +0100

Tags: lucid
Revision history for this message
Rolf Leggewie (r0lf) wrote :
description: updated
description: updated
description: updated
Revision history for this message
Ilya Barygin (randomaction) wrote :

Rolf, I think the changelog should describe the delta rather than state that it's unchanged, so that it's not necessary to look for the older entries. Please also close this bug in the changelog (LP: #525116).

It looks like you intended to subscribe motu-release, I'm doing it now. I'm also unsubscribing u-u-s, please resubscribe again when the exception has been granted.

Revision history for this message
Iulian Udrea (iulian) wrote :

Looks good to me. Ack #1.

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Ilya, thank you for your comment. The changelog points to the version and it should be easy enough to look that up in the Changelog itself. I understand why you want the delta explained. OTOH, I find the way I described things here have more information (when was the delta introduced and last described in full detail?) while being more concise at the same time. I'd prefer it to go in like I proposed here unless that is absolutely impossible.

Second, closing the ticket. I agree that would be nice. But you end up in a chicken-and-egg situation. I want to attach the patch when I report the issue and not go back and forth between LP and my patch environment (my build host is not my desktop, so it involves a few more steps). I don't have a good solution here.

Revision history for this message
StefanPotyra (sistpoty) wrote :

Ack #2, confirming the FFe. Please go ahead with uploading.

Changed in git-buildpackage (Ubuntu):
status: New → Confirmed
Rolf Leggewie (r0lf)
Changed in git-buildpackage (Ubuntu):
importance: Undecided → Medium
Changed in git-buildpackage (Ubuntu):
assignee: nobody → Ilya Barygin (randomaction)
status: Confirmed → In Progress
Revision history for this message
Ilya Barygin (randomaction) wrote :

Rolf, the delta between 0.4.65 and 0.4.65ubuntu1 contains some unexpected changes, namely, to gbp/deb.py, gbp/gbp_version.py and git-dch. Some of them were introduced in your patch. Was that intentional?

Changed in git-buildpackage (Ubuntu):
assignee: Ilya Barygin (randomaction) → nobody
status: In Progress → Incomplete
Revision history for this message
Martin Pitt (pitti) wrote :

Unsubscribing SRU team, no SRU here.

Revision history for this message
StefanPotyra (sistpoty) wrote :

ping, any news? Ilya, could you finish this merge? I'd like to get it in rather sooner than later, so that we still have some time to react in case of errors.

Revision history for this message
Ilya Barygin (randomaction) wrote :

I'm taking it.

Changed in git-buildpackage (Ubuntu):
assignee: nobody → Ilya Barygin (randomaction)
status: Incomplete → In Progress
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Sorry for the delay in responding. I'm already working on it. The patch is ready for upload in just a few minutes.

Revision history for this message
Ilya Barygin (randomaction) wrote :

OK, Rolf, I also noticed that Debian added bash-completion to build dependencies, we should do the same.

Changed in git-buildpackage (Ubuntu):
assignee: Ilya Barygin (randomaction) → nobody
status: In Progress → Incomplete
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Here is the updated debdiff (and against the debian unstable version which should is smaller and thus easier to inspect for errors)

I hope it's error-free this time.

Changed in git-buildpackage (Ubuntu):
status: Incomplete → In Progress
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Here is the updated debdiff (and against the debian unstable version which is smaller and thus should be easier to inspect for errors)

I hope it's error-free this time.

Revision history for this message
Ilya Barygin (randomaction) wrote :

Thank you! Uploaded with two small changes:
- syntax for closing this bug is "LP: #525116" not "LP #525116"
- ran update-maintainer

Changed in git-buildpackage (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package git-buildpackage - 0.4.65ubuntu1

---------------
git-buildpackage (0.4.65ubuntu1) lucid; urgency=low

  * merge from Debian unstable. delta unchanged from 0.4.63ubuntu1. LP: #525116

git-buildpackage (0.4.65) unstable; urgency=low

  [ Guido Günther ]
  * [07d54ef] gbp-add-patch: Strip path from patchname and handle missing
    files gracefully.
  * [a7fe7c4] Add basic bash completion for git-buildpackage (Closes: #567313)
    - thanks to Siegfried-Angel Gevatter
  * [aec185f] Add gbp-{clone,pull,pq} to description
  * [24ac91c] bash-completion: Add git-dch, git-import-{orig,dsc} and tab
    completion for branch names.
  * [cbc0577] Add GitRepository.get_remotes() to easily query remote branches
  * [4654425] gbp-clone: Add --all to track all remote branches

  [ Matthijs Kooijman ]
  * [2874c23] Make the commit message for upstream imports configurable.
    This adds the import-msg commandline and configuration file option
    to change the commit message. (Closes: #474457)

  [ Jon Bernard ]
  * [ad9b7f5] Prevent git-add-patch from being gzip'd

git-buildpackage (0.4.64) unstable; urgency=low

  * [ab40623] Add gbp-add-patch to easily commit patches from debian/patches
  * [34c1c43] Allow to skip imports of same version Based on a patch by
    Christoph Göhre.
  * [ea6311e] DscFile: Parse name of debian.tar.gz
  * [237a547] Import version 3 source format (Closes: #552771)
 -- Rolf Leggewie <email address hidden> Sun, 21 Feb 2010 02:03:39 +0100

Changed in git-buildpackage (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.