building icons in menu are shown without correct playercolor

Setting to incomplete for bug sweeping.

This would be a neat addition, and it looks rather odd that we can apply the player color in some places but not all.

Currently if you look at the building statistics for instance the list of all buildings have the small images which use white in place of player color, but the large image of the selected building will have properly applied player color. It also affect the build dialog which opens when you click on the ground. Rather visible with the barbarian mines.

I had the impression this could be some "low hanging fruit", and had a rather long look into it.

Problem here is that the whole infrastructure around a tribe is not player sensitive, and the building types (class BuildingDescr) is part of this infrastructure.
There is no easy way to get this done. I don't say there is no way ;-)

It could be done rather hackish style if there would be a static way to get a current Player, but I guess there could be implications with spectator mode which I do not want to pursue ;-)

This topic applies not only to statistics window, but also to the editor and the encyclopedia..

This bug is related to Bug #978160

I may have found a way... ;-)
Unfortunately there are currently no playercolor masks for the menu images, and the menu images are at a different size/aspect ratio, but this would only mean some graphics work.

fwiw, this branch https://code.launchpad.net/~widelands-dev/widelands/spritemaps should contain most of the code to make this simple. It should probably be merged as the C++ code is complete, just the animation transitions have not been done since the script is not working properly.

This topic is not incomplete anymore, but in progress ;-)

The branch is merged --> this is committed.

Fixed in build19-rc1.