ooo-thumbnailer (abandoned)

ooo-thumbnailer doesn't work in directories with spaces

Bug #583136 reported by Koichi Akabe on 2010-05-20

This bug affects 3 people

	Status	Importance	Assigned to
ooo-thumbnailer (abandoned)	Fix Released	Undecided	Unassigned
ooo-thumbnailer (Debian)	Confirmed	Unknown	debbugs #597296
ooo-thumbnailer (Ubuntu)	Fix Released	Low	Luke Faraone
Lucid	Fix Released	Low	Luke Faraone

Bug Description

ooo-thumbnailer doesn't work in any directories with spaces in their names.
Thumbnails of pictures, PDFs, movies are not shown in this directory.

== SRU INFO ==

The bug has been addressed through the addition of quotes around the relevant sections of code that handle pathnames.

== TEST CASE ==
1. Create a ODT or other OO.O document in a folder with a space in the name.
2. Open the folder containingthe document in
Expected behavior:
A thumbnail is generated.

Actual behavior:
No thumbnail is generated.

This patch has no realistic regression potential. I've tested it on Lucid and Maverick

See original description

Tags:

Related branches

lp:ubuntu/maverick/ooo-thumbnailer

lp:ubuntu/lucid-proposed/ooo-thumbnailer

Koichi Akabe (vbkaisetsu) on 2010-05-20

affects:

bindwood → ubuntuone-client

Revision history for this message

Roman Yepishev (rye) wrote on 2010-05-21:

This is bug in ooo-thumbnailer - cannot handle paths with spaces:

/usr/bin/ooo-thumbnailer: line 34: [: too many arguments

affects:	ubuntuone-client → ooo-thumbnailer
Changed in ooo-thumbnailer:
status:	New → Confirmed

Revision history for this message

David D Lowe (flimm) wrote on 2010-05-21:

This bug has been fixed in an upstream release of ooo-thumbnailer, which you can get in this PPA:
https://launchpad.net/~flimm/+archive/ooo-thumbnailer

The new upstream version contains quite a few new features, so I'll only submit a patch for this bug in Lucid. The new version should be in Maverick hopefully.

summary:	- ooo-thumbnailer don't work in ~/Ubuntu One directory + ooo-thumbnailer doesn't work in directories with spaces
Changed in ooo-thumbnailer:
status:	Confirmed → Triaged
description:	updated

David D Lowe (flimm) on 2010-05-21

Changed in ooo-thumbnailer:
status:	Triaged → Fix Released

Revision history for this message

David D Lowe (flimm) wrote on 2010-05-21:

fix_directories_with_spaces.debdiff Edit (2.1 KiB, text/plain)

The attached Ubuntu debdiff fixes this bug.

Changed in ooo-thumbnailer (Ubuntu):
assignee:	nobody → David D Lowe (flimm)
status:	New → In Progress

Revision history for this message

Luke Faraone (lfaraone) wrote on 2010-05-28:

David,

You marked the bug as "in progress". Are you still working on the patch, or are you looking for a sponsor?

Revision history for this message

David D Lowe (flimm) wrote on 2010-05-28:

Luke, the patch should fix the bug, and yes, I'm looking for a sponsor. I'm not sure what the bug should be marked as at this point.

Revision history for this message

Luke Faraone (lfaraone) wrote on 2010-05-29:

FYI, oer https://wiki.ubuntu.com/SponsorshipProcess , a bug should be "new" or "confirmed" if you're seeking a sponsor, and "assigned to" nobody.

Changed in ooo-thumbnailer (Ubuntu):
assignee:	David D Lowe (flimm) → Luke Faraone (lfaraone)

Revision history for this message

Luke Faraone (lfaraone) wrote on 2010-05-29:

Just for confirmation, has this been fixed in Maverick? If so, please do steps 1-3 of https://wiki.ubuntu.com/StableReleaseUpdates#Procedure.

Revision history for this message

David D Lowe (flimm) wrote on 2010-05-29:

No, this bug has not been fixed in Maverick. I'm waiting for sponsorship for the new upstream version of ooo-thumbnailer in Debian, once I get that, it should me merged to Maverick.

Revision history for this message

Luke Faraone (lfaraone) wrote on 2010-05-31:

Okay. If it's fine with you, we can wait for it to auto-sync and then SRU it to Lucid. Otherwise, we can create an ubuntu delta and drop it later, but that's more work.

Changed in ooo-thumbnailer (Ubuntu):
assignee:	Luke Faraone (lfaraone) → nobody
status:	In Progress → Triaged

Revision history for this message

Koichi Akabe (vbkaisetsu) wrote on 2010-05-31:

#10

I added a PPA for ooo-thumbnailer and it fixed. Thank you David.

Revision history for this message

Stefano Rivera (stefanor) wrote on 2010-07-11:

#11

Unsubscribed sponsors. Subscribe us when you need sponsorship

Changed in ooo-thumbnailer (Ubuntu):
importance:	Undecided → Low

Brian Murray (brian-murray) on 2010-07-11

tags:

added: patch

Revision history for this message

Mahendra Tallur (mahen) wrote on 2010-09-22:

#12

This issue actually still occurs in Maverick, as the ooo-thumbnailer version is still 0.2.

Koichi Akabe (vbkaisetsu) on 2010-09-23

description:	updated
description:	updated

Luke Faraone (lfaraone) on 2010-09-23

Changed in ooo-thumbnailer (Ubuntu):
assignee:	nobody → Luke Faraone (lfaraone)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-09-23:

#13

This bug was fixed in the package ooo-thumbnailer - 0.2-5ubuntu1

---------------
ooo-thumbnailer (0.2-5ubuntu1) maverick; urgency=low

* Added debian/source/format and set it to 3.0 (quilt).
* Added debian/patches/fix_directories_with_spaces to allow successful thumbnailing of files in directories with spaces (LP: #583136)
-- David D Lowe <email address hidden> Fri, 21 May 2010 18:53:27 +0100

Changed in ooo-thumbnailer (Ubuntu):
status:	Triaged → Fix Released

Luke Faraone (lfaraone) on 2010-09-23

Changed in ooo-thumbnailer (Ubuntu Lucid):
status:	New → In Progress
assignee:	nobody → Luke Faraone (lfaraone)
importance:	Undecided → Low

Luke Faraone (lfaraone) on 2010-09-23

description:

updated

Luke Faraone (lfaraone) on 2010-09-25

Changed in ooo-thumbnailer (Ubuntu Lucid):
status:	In Progress → Fix Committed

Revision history for this message

Martin Pitt (pitti) wrote on 2010-09-27: Please test proposed package

#14

Accepted ooo-thumbnailer into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Jean-Baptiste Lallement (jibel) wrote on 2010-10-05:

#15

SRU verification for Lucid:
I have reproduced the problem with ooo-thumbnailer 0.2-5 in lucid and have verified that the version of ooo-thumbnailer 0.2-5ubuntu0.10.04.1 in -proposed fixes the issue.

Marking as verification-done

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-10-06:

#16

This bug was fixed in the package ooo-thumbnailer - 0.2-5ubuntu0.10.04.1

---------------
ooo-thumbnailer (0.2-5ubuntu0.10.04.1) lucid-proposed; urgency=low

* Patch ooo-thumbnailer to allow successful thumbnailing of files in
directories with spaces. (LP: #583136) Thanks to David Lowe.
-- Luke Faraone <email address hidden> Sat, 25 Sep 2010 17:58:30 -0400