Bazaar Explorer

Crash when show log of file

Bug #585280 reported by David Roth
46
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Fix Released
High
Unassigned
QBzr
Status tracked in Trunk
0.18
Confirmed
Undecided
Unassigned
Trunk
Fix Released
High
Gary van der Merwe
QBzr 0.19b2 "Pomegranate"

Bug Description

When i want to show the log of a file in the right pane, bazaar crashes with the following error:

bzr: ERROR: bzrlib.errors.ObjectNotLocked: <bzrlib.groupcompress._GCGraphIndex object at 0xaf65eec> is not locked

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/loggraphprovider.py", line 789, in load_filter_file_id
    if tree.kind(fileid) in ('directory', 'tree-reference'):
  File "/usr/lib/python2.6/dist-packages/bzrlib/revisiontree.py", line 151, in kind
    return self._inventory[file_id].kind
  File "/usr/lib/python2.6/dist-packages/bzrlib/inventory.py", line 2016, in __getitem__
    self.id_to_entry.iteritems([StaticTuple(file_id,)]).next()[1])
  File "/usr/lib/python2.6/dist-packages/bzrlib/chk_map.py", line 515, in iteritems
    self._ensure_root()
  File "/usr/lib/python2.6/dist-packages/bzrlib/chk_map.py", line 164, in _ensure_root
    self._root_node = self._get_node(self._root_node)
  File "/usr/lib/python2.6/dist-packages/bzrlib/chk_map.py", line 177, in _get_node
    bytes = self._read_bytes(node)
  File "/usr/lib/python2.6/dist-packages/bzrlib/chk_map.py", line 188, in _read_bytes
    bytes = stream.next().get_bytes_as('fulltext')
  File "/usr/lib/python2.6/dist-packages/bzrlib/groupcompress.py", line 1413, in get_record_stream
    orig_keys, ordering, include_delta_closure):
  File "/usr/lib/python2.6/dist-packages/bzrlib/groupcompress.py", line 1518, in _get_remaining_record_stream
    locations = self._index.get_build_details(keys)
  File "/usr/lib/python2.6/dist-packages/bzrlib/groupcompress.py", line 2003, in get_build_details
    self._check_read()
  File "/usr/lib/python2.6/dist-packages/bzrlib/groupcompress.py", line 1923, in _check_read
    raise errors.ObjectNotLocked(self)
ObjectNotLocked: <bzrlib.groupcompress._GCGraphIndex object at 0xaf65eec> is not locked

bzr 2.1.1 on python 2.6.5 (linux2)
arguments: ['/usr/bin/bzr', 'explorer']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bzrtools /usr/lib/python2.6/dist-packages/bzrlib/plugins/bzrtools [2.1.0]
  dbus /usr/lib/python2.6/dist-packages/bzrlib/plugins/dbus [0.1.0dev]
  explorer /usr/lib/python2.6/dist-packages/bzrlib/plugins/explorer [1.0.1]
  gtk /usr/lib/python2.6/dist-packages/bzrlib/plugins/gtk [0.98.0.final.1]
  launchpad /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad [2.1.1]
  netrc_credential_store /usr/lib/python2.6/dist-packages/bzrlib/plugins/netrc_credential_store [2.1.1]
  news_merge /usr/lib/python2.6/dist-packages/bzrlib/plugins/news_merge [2.1.1]
  qbzr /usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr [0.18.5]
  svn /usr/lib/python2.6/dist-packages/bzrlib/plugins/svn [1.0.2]

Tags: qlog qbrowse
Revision history for this message
David Roth (davrot) wrote :

The crash occurs with a checkout from a remote branch.
Logging the complete branch does work, but it crashes when executing on a single file.
bzr log filename in console does work.

Bzr-Explorer-Version: 1.0.1
Ubuntu Lucid

Revision history for this message
Alexander Belchenko (bialix) wrote :

OK, with trunk versions of both explorer and qbzr I've got different exception on trying see log of the file via treewidget context menu:

bzr: ERROR: exceptions.AttributeError: 'BzrBranch6' object has no attribute 'startswith'

Traceback (most recent call last):
  File "C:\work\Bazaar\plugins\qbzr\lib\trace.py", line 300, in reports_exception_decorate
  File "C:\work\Bazaar\plugins\qbzr\lib\log.py", line 223, in load
  File "C:\work\Bazaar\plugins\qbzr\lib\log.py", line 390, in _locations_for_title
  File "bzrlib\directory_service.pyo", line 54, in dereference
  File "bzrlib\registry.pyo", line 183, in get_prefix
AttributeError: 'BzrBranch6' object has no attribute 'startswith'

bzr 2.1.1 on python 2.5.4 (win32)
arguments: ['C:\\Program Files\\Bazaar\\bzr.EXE', 'explore', '.']
encoding: 'cp1251', fsenc: 'mbcs', lang: None
plugins:
  acad C:\work\Bazaar\plugins\acad [0.8.0]
  bookmarks C:\work\Bazaar\plugins\bookmarks [unknown]
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.1.0]
  colo C:\work\Bazaar\plugins\colo [0.2.0dev]
  explorer C:\work\Bazaar\plugins\explorer [1.1.0dev]
  fastimport C:\work\Bazaar\plugins\fastimport [0.9.0dev]
  format1 C:\work\Bazaar\plugins\format1 [unknown]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.1.1]
  qbzr C:\work\Bazaar\plugins\qbzr [0.19.0dev1]
  rebase C:\Program Files\Bazaar\plugins\rebase [0.5.5]
  scmproj C:\work\Bazaar\plugins\scmproj [0.6.1]
  svn C:\Program Files\Bazaar\plugins\svn [1.0.2]
  x_bit C:\work\Bazaar\plugins\x_bit [1.0.0]

Changed in qbzr:
status: New → Confirmed
importance: Undecided → High
Changed in bzr-explorer:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Alexander Belchenko (bialix) wrote :

The last traceback is clearly qbzr-specific and can be reproduced via qbrowse -> log on file.

Alexander Belchenko (bialix)
tags: added: qbrowse qlog
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

I cant reproduce this. I did:

~ $ bzr checkout qbzr/trunk/ bug585280 --lightweight
~ $ bzr explorer bug585280
Right click on NEWS.txt in wt plane => Show Log
Works fine.

I also tried a whole bunch of other things.

Please give more detailed steps to reproduce.

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 585280] Re: Crash when show log of file

Gary van der Merwe пишет:
> I cant reproduce this. I did:
>
> ~ $ bzr checkout qbzr/trunk/ bug585280 --lightweight
> ~ $ bzr explorer bug585280
> Right click on NEWS.txt in wt plane => Show Log
> Works fine.
>
> I also tried a whole bunch of other things.
>
> Please give more detailed steps to reproduce.

It crashed for me every time on Windows with bzr 2.1.

Gary van der Merwe (garyvdm)
Changed in bzr-explorer:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.