Bazaar Explorer

Put the locale in the typical folder on Linux

Bug #585942 reported by Julian Aloofi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Fix Released
Medium
Martin Pool
Bazaar Explorer 1.0.2

Bug Description

On Linux, locale files generally reside in /usr/share/locale according to the FHS: http://www.pathname.com/fhs/pub/fhs-2.3.html#SPECIFICOPTIONS15
bzr-explorer puts it into another folder by default on Linux. It would be nice to have it in the "typical" folder.
That makes packaging easier for distributors.
Attached is a patch that works against the 1.0.1 codebase.

qbzr used the same code, see https://bugs.launchpad.net/qbzr/+bug/542429 , it's already merged.

Related branches

lp:~mbp/bzr-explorer/585942-locale-dir
Bazaar Explorer Developers: Pending requested
Diff: 16 lines (+5/-1)
1 file modified
lib/i18n.py (+5/-1)
Revision history for this message
Julian Aloofi (nailuj24) wrote :
Revision history for this message
Martin Pool (mbp) wrote :

I'll merge this in on the grounds that it's the same as was taken for qbzr.

Changed in bzr-explorer:
status: New → Fix Committed
Revision history for this message
Alexander Belchenko (bialix) wrote :

Merged into both explorer 1.0 and trunk. Thanks!

Changed in bzr-explorer:
status: Fix Committed → Fix Released
importance: Undecided → Medium
assignee: nobody → Martin Pool (mbp)
milestone: none → 1.0.2
Revision history for this message
Julian Aloofi (nailuj24) wrote :

That's cool, but I think there still is a problem. I just looked at version 1.0.2, and while the code is looking in the right folder now, it won't find anything, because the setup.py still installs the locales to the bzrlib directory.
That means, users would have to manually move the locales from bzrlib/locale to /usr/share/locale (what I'm doing right now in the Fedora package).
Probably not what you wanted!

Changed in bzr-explorer:
status: Fix Released → Confirmed
Revision history for this message
Alexander Belchenko (bialix) wrote :

I was under impression that packages don't use setup.py.

Revision history for this message
Julian Aloofi (nailuj24) wrote :

Sorry, I posted too quickly I think. I just had the impression that users manually installing bzr-explorer by just putting the extracted tarball as an explorer/ directory into either ...bzrlib/plugins/ or ~/.bazaar/plugins/ would not see any translations (as it's looking in /usr/share/locale/ now).
Looks like I was wrong, totally forgot that the translations get generated by setup.py in the first place, and looks like it still looks in the other directories for locale files.

Changed in bzr-explorer:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.