logprof doesn't handle log messages without denied or requested masks correctly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
AppArmor |
Fix Released
|
Undecided
|
Unassigned | ||
2.5 |
Fix Released
|
Medium
|
Unassigned | ||
apparmor (Ubuntu) |
Fix Released
|
Medium
|
Jamie Strandboge | ||
Lucid |
Fix Released
|
Medium
|
Jamie Strandboge | ||
Maverick |
Fix Released
|
Medium
|
Jamie Strandboge | ||
Natty |
Fix Released
|
Medium
|
Jamie Strandboge |
Bug Description
SRU
1. when loading, unloading and replacing policy, AppArmor leaves a message in kern.log. When aa-logprof encounters this, it will spew many confusing warning messages.
2. The bug has not been addressed in the development branch (natty is not open yet)
3. Patch is from r1440 of 2.5 branch (linked to this bug)
4. TEST CASE:
$ echo 'Oct 14 07:14:13 bug652674 kernel: [ 5.429706] type=1400 audit(128705845
$ sudo aa-logprof -f /tmp/log # may be prompted to enable the repository. Choose 'Ask later'
5. The regression potential is considered low. The fix does not affect the boot or shutdown process.
Binary package hint: apparmor
When aa-logprof runs into log messages that don't have denied or requested masks, like the following status message, it ends up trying to perform a string operation on an undefined variable which causes warnings to be printed to the console.
[ 9.633452] type=1400 audit(128589911
I'm attaching a patch to fix this.
ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: apparmor 2.5.1~rc1-0ubuntu2
ProcVersionSign
Uname: Linux 2.6.35-22-generic x86_64
NonfreeKernelMo
Architecture: amd64
Date: Thu Sep 30 21:16:25 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release Candidate amd64 (20100928)
ProcEnviron:
PATH=(custom, user)
LANG=en_US.utf8
SHELL=/bin/bash
SourcePackage: apparmor
tags: | added: patch |
Changed in apparmor (Ubuntu Maverick): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Jamie Strandboge (jdstrand) |
Changed in apparmor (Ubuntu Natty): | |
assignee: | nobody → Jamie Strandboge (jdstrand) |
Changed in apparmor (Ubuntu Lucid): | |
assignee: | nobody → Jamie Strandboge (jdstrand) |
importance: | Undecided → Medium |
milestone: | none → lucid-updates |
status: | New → In Progress |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
tags: |
added: verification-done removed: verification-needed |
tags: | added: testcase |
This is a regression from lucid. I just upgraded one machine to maverick and now aa-logprof spits out thousands of warnings.
Jesse's patch looks fine.