pg_createcluster silently deletes existing cluster

Thanks! This has already been fixed in version 111, which is in maverick and natty:

postgresql-common (111) unstable; urgency=high

  * Urgency high since this fixes two RC bugs.
  * t/030_errors.t: Check that pg_createcluster leaves the original one intact
    if the cluster already exists, also when the original one is not running.
    This reproduces #597097.
  * pg_createcluster: Be more careful with cleaning up the created cluster if
    an error occurs: Do not start the cleanup until we actually passed our
    sanity checks and created files for the new cluster. Before, it would
    erroneously remove an already existing cluster on a sanity check fail, if
    that cluster happened to not be running at the time. (Closes: #597097)
  * debian/supported-versions: Be more robust against lsb_release failing, e.
    g. in the case where it is not fully configured yet. (Closes: #597561)
  * debian/supported-versions: Drop check for /etc/debian_version if
    lsb_release is not working/existing. Derivatives have debian_version as
    well, and we don't actually evaluate it, so just print a meaningful error
    message and go with the default versions.
  * debian/rules: Put init script priority back to S19/K21 to match the
    previous postgresql-8.4 init script. Fix the priorities on upgrade in
    debian/postgresql-common.preinst. (Closes: #597654)

 -- Martin Pitt <email address hidden> Wed, 22 Sep 2010 12:04:00 +0200

For lucid I propose to SRU the patch; it contains a test case and is pretty straightforward:

  http://bazaar.launchpad.net/~pitti/postgresql/common/revision/1024

I backported the fix to lucid and uploaded to lucid-proposed, this now needs review/ack from the ubuntu-sru team.

The new test case reproduces the erroneous removal of preexisting cluster, and with the fixed pg_createcluster it now runs fine. I also confirm that with a locally built 106ubuntu1 the entire test suite still succeeds.

I backported the fix to hardy and uploaded to hardy-proposed, this now needs review/ack from the ubuntu-sru team.

Accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Accepted into hardy-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Tested on Lucid x86_64 desktop. pg_createcluster now does not delete an existing cluster, regardless of whether it is online or down, pg_lscluster, pg_dropcluster, pg_ctlcluster still seem.

 ... correction of #7:

Otherwise, pg_createcluster, pg_lsclusters, pg_dropcluster, pg_ctlcluster seem to work as before.

Thanks Thomas! I also tested the same on maverick with the package in -proposed, and it doesn't kill the cluster now. Test suites still run fine.

This bug was fixed in the package postgresql-common - 106ubuntu1

---------------
postgresql-common (106ubuntu1) lucid-proposed; urgency=low

  * t/030_errors.t: Check that pg_createcluster leaves the original one
    intact if the cluster already exists, also when the original one is not
    running. This reproduces LP #661061/Debian #597097.
  * pg_createcluster: Be more careful with cleaning up the created cluster if
    an error occurs: Do not start the cleanup until we actually passed our
    sanity checks and created files for the new cluster. Before, it would
    erroneously remove an already existing cluster on a sanity check fail, if
    that cluster happened to not be running at the time. (LP: #661061)
    Patches cherrypicked from trunk r1024.
  * debian/control: Set Vcs-Bzr to lucid branch.
 -- Martin Pitt <email address hidden> Mon, 18 Oct 2010 11:04:24 +0200

This bug was fixed in the package postgresql-common - 87ubuntu3

---------------
postgresql-common (87ubuntu3) hardy-proposed; urgency=low

  * t/030_errors.t: Check that pg_createcluster leaves the original one
    intact if the cluster already exists, also when the original one is not
    running. This reproduces LP #661061/Debian #597097.
  * pg_createcluster: Be more careful with cleaning up the created cluster if
    an error occurs: Do not start the cleanup until we actually passed our
    sanity checks and created files for the new cluster. Before, it would
    erroneously remove an already existing cluster on a sanity check fail, if
    that cluster happened to not be running at the time. (LP: #661061)
    Patches cherrypicked from trunk r1024.
 -- Martin Pitt <email address hidden> Mon, 18 Oct 2010 11:09:35 +0200