loading images doesn't use proxy credentials

This patch is a backport of the upstream patch.

To test, configure evolution to use a proxy which requires a username/password to gain access, then while viewing an e-mail that has image URL references, try to force the images to load with a ctrl-i. If the images load and you have the patch from LP 664167, you should see

Didier may you have a look to it? Thanks.

Will this be making it into an updated evolution package for Maverick any time soon?

Attaching the same test case test message as from bug 664167.

The attached debdiff applies the patch and appears to fix the problem.

This also applies the fix for bug 665330.

Great. So will this go into a new release for evolution for Maverick or has interest in maintaining evolution in Maverick waned?

the issue is fixed in the current version

sru sponsorized now

Accepted evolution into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

On Mon, 2010-12-20 at 08:47 +0000, Martin Pitt wrote:
> Accepted evolution into maverick-proposed, the package will build now
> and be available in a few hours. Please test and give feedback here.

This seems to be working in the -proposed version. Thanx much!

This bug was fixed in the package evolution - 2.30.3-1ubuntu7.2

---------------
evolution (2.30.3-1ubuntu7.2) maverick-proposed; urgency=low

  * debian/patches/93_git_hide_junk_messages_in_search_folders.patch:
    - do not show Junk messages in Search folders (LP: #665330)
  * debian/patches/93_git_use_proxy_cred_for_images.patch:
    - use proxy credentials when loading images from the web (LP: #664169)
 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 23 Nov 2010 11:55:35 -0500

On Mon, 2011-01-03 at 09:02 +0000, Launchpad Bug Tracker wrote:
> This bug was fixed in the package evolution - 2.30.3-1ubuntu7.2

Great!

> ---------------
> evolution (2.30.3-1ubuntu7.2) maverick-proposed; urgency=low
>
> * debian/patches/93_git_hide_junk_messages_in_search_folders.patch:
> - do not show Junk messages in Search folders (LP: #665330)
> * debian/patches/93_git_use_proxy_cred_for_images.patch:
> - use proxy credentials when loading images from the web (LP: #664169)
> -- Mathieu Trudel-Lapierre <email address hidden> Tue, 23 Nov 2010 11:55:35 -0500

Will these changes ever get migrated/merged back to the maverick
evolution bzr repo or will they forever only live in the
maverick-proposed repo?

the fix have left -proposed and is now in maverick-updates

On Mon, Jan 3, 2011 at 5:05 PM, Brian J. Murrell <email address hidden>wrote:

> On Mon, 2011-01-03 at 09:02 +0000, Launchpad Bug Tracker wrote:
> > This bug was fixed in the package evolution - 2.30.3-1ubuntu7.2
>
> Great!
>
> > ---------------
> > evolution (2.30.3-1ubuntu7.2) maverick-proposed; urgency=low
> >
> > * debian/patches/93_git_hide_junk_messages_in_search_folders.patch:
> > - do not show Junk messages in Search folders (LP: #665330)
> > * debian/patches/93_git_use_proxy_cred_for_images.patch:
> > - use proxy credentials when loading images from the web (LP:
> #664169)
> > -- Mathieu Trudel-Lapierre <email address hidden> Tue, 23 Nov 2010
> 11:55:35 -0500
>
> Will these changes ever get migrated/merged back to the maverick
> evolution bzr repo or will they forever only live in the
> maverick-proposed repo?
>
> --
> You received this bug notification because you are subscribed to
> evolution in ubuntu.
> https://bugs.launchpad.net/bugs/664169
>
> Title:
> loading images doesn't use proxy credentials
>
> Status in The Evolution Mail & Calendaring Tool:
> Fix Released
> Status in “evolution” package in Ubuntu:
> Fix Released
> Status in “evolution” source package in Maverick:
> Fix Released
>
> Bug description:
> Binary package hint: evolution
>
> SRU JUSTIFICATION:
> Small patch to use along with patch in bug 664167 to use proxy credentials
> to load images.
> This is a big issue for corporate users wishing to have access to rich
> email content (embedded images) from behind a secured proxy (as it is the
> case in many large enterprises).
>
> There is minimal impact since this only affects users behind a proxy, and
> only if they use a secured proxy (requiring authentication).
>
> TEST CASES:
> - Requires a proxy with authentication turned on. This can be easily
> achieved using squid using the pam_auth provider, for example.
>
> 1) Configure the proxy settings in Gnome (System->Preferences->Network
> Proxy) or Evolution (Edit->Preferences->Network Preferences), including
> authentication username and password.
> 2) Load a message which contains embedded images from the Internet in a URL
> document (see attached example: lp_664169_test_case.mbox -- this test case
> can be loaded in Evolution by double-clicking it)
> 3) Force loading the images from the Internet by pressing Ctrl-I.
>
> For a successful test cases, you will see embedded images being loaded from
> the Internet and displayed in the message.
> For a failed test cases, the images will not load.
>
> ---
>
> We need the patch from upstream bug 631526 to land so that proxy
> credentials are used properly when loading images.
>
>
>
>
>

On Mon, 2011-01-03 at 12:12 +0000, Omer Akram wrote:
> the fix have left -proposed and is now in maverick-updates

Ahhh. Perhaps the bzr branch I have here is "maverick" and not
"maveric-updates". Is there any way to switch from "maverick" to
"maverick-updates" in my tree here? I'm a total bzr newb, so I'm not
really sure if it's possible and if it is, how it's done. Thanx.

bzr branch lp:ubuntu/maverick-proposed/evolution ;)

On Mon, Jan 3, 2011 at 5:24 PM, Brian J. Murrell <email address hidden>wrote:

> On Mon, 2011-01-03 at 12:12 +0000, Omer Akram wrote:
> > the fix have left -proposed and is now in maverick-updates
>
> Ahhh. Perhaps the bzr branch I have here is "maverick" and not
> "maveric-updates". Is there any way to switch from "maverick" to
> "maverick-updates" in my tree here? I'm a total bzr newb, so I'm not
> really sure if it's possible and if it is, how it's done. Thanx.
>
> --
> You received this bug notification because you are subscribed to
> evolution in ubuntu.
> https://bugs.launchpad.net/bugs/664169
>
> Title:
> loading images doesn't use proxy credentials
>
> Status in The Evolution Mail & Calendaring Tool:
> Fix Released
> Status in “evolution” package in Ubuntu:
> Fix Released
> Status in “evolution” source package in Maverick:
> Fix Released
>
> Bug description:
> Binary package hint: evolution
>
> SRU JUSTIFICATION:
> Small patch to use along with patch in bug 664167 to use proxy credentials
> to load images.
> This is a big issue for corporate users wishing to have access to rich
> email content (embedded images) from behind a secured proxy (as it is the
> case in many large enterprises).
>
> There is minimal impact since this only affects users behind a proxy, and
> only if they use a secured proxy (requiring authentication).
>
> TEST CASES:
> - Requires a proxy with authentication turned on. This can be easily
> achieved using squid using the pam_auth provider, for example.
>
> 1) Configure the proxy settings in Gnome (System->Preferences->Network
> Proxy) or Evolution (Edit->Preferences->Network Preferences), including
> authentication username and password.
> 2) Load a message which contains embedded images from the Internet in a URL
> document (see attached example: lp_664169_test_case.mbox -- this test case
> can be loaded in Evolution by double-clicking it)
> 3) Force loading the images from the Internet by pressing Ctrl-I.
>
> For a successful test cases, you will see embedded images being loaded from
> the Internet and displayed in the message.
> For a failed test cases, the images will not load.
>
> ---
>
> We need the patch from upstream bug 631526 to land so that proxy
> credentials are used properly when loading images.
>
>
>
>
>

On Mon, 2011-01-03 at 12:38 +0000, Omer Akram wrote:
> bzr branch lp:ubuntu/maverick-proposed/evolution ;)
                                ^^^^^^^^
Do/should I have to use proposed here or can/should I use "udpates"?
i.e.

bzr branch lp:ubuntu/maverick-updates/evolution