[upgrade] New upstream release 0.141

Bug #671358 reported by Cesare Falco
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mame (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: mame

A new upstream release is available at http://mamedev.org

Tags: patch upgrade

Related branches

tags: added: needs-packaging
Changed in mame (Ubuntu):
status: New → Confirmed
Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

summary: - [upgrade] New upstream release 0.140
+ [needs-packaging] [upgrade] New upstream release 0.140
Changed in mame (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Cesare Falco (c.falco) wrote : Re: [needs-packaging] [upgrade] New upstream release 0.140

This is the debian.tar.gz for the new release.

A build for natty is available on PPA:
https://edge.launchpad.net/~c.falco/+archive/mame

Please revise and upload it, thanks!

Benjamin Drung (bdrung)
tags: added: upgrade
removed: needs-packaging
summary: - [needs-packaging] [upgrade] New upstream release 0.140
+ [upgrade] New upstream release 0.140
Revision history for this message
Micah Gersten (micahg) wrote : Re: [upgrade] New upstream release 0.140

Thank you for taking the time to prepare this update. There is actually another release available at the moment, would you be able to prepare that instead?

Changed in mame (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Cesare Falco (c.falco) wrote :

Those marked with "u" are unstable releases, sometimes buggy, seldom breaking minor functionalities.

I resolved and recommend not to officially package them, and to stick with "major" releases.

Changed in mame (Ubuntu):
status: Incomplete → Confirmed
Micah Gersten (micahg)
Changed in mame (Ubuntu):
assignee: nobody → Micah Gersten (micahg)
status: Confirmed → In Progress
Revision history for this message
Micah Gersten (micahg) wrote :

Cesare, would you be able to fix this, please? It seems the location of the downloads have changed.

 ./debian/rules get-orig-source
wget -U ubuntu -P . "http://mamedev.org/downloader.php?&file=mame0140s.zip"
--2010-11-14 01:07:51-- http://mamedev.org/downloader.php?&file=mame0140s.zip
Resolving mamedev.org... 67.210.100.31
Connecting to mamedev.org|67.210.100.31|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://www.aarongiles.com/mirror/releases/mame0140s.zip [following]
--2010-11-14 01:07:52-- http://www.aarongiles.com/mirror/releases/mame0140s.zip
Resolving www.aarongiles.com... 216.97.235.25
Connecting to www.aarongiles.com|216.97.235.25|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 16971731 (16M) [application/zip]
Saving to: `./downloader.php?&file=mame0140s.zip'

100%[======================================>] 16,971,731 400K/s in 60s

2010-11-14 01:08:53 (275 KB/s) - `./downloader.php?&file=mame0140s.zip' saved [16971731/16971731]

echo "806f5ba295601728fd3412329a592661 *mame0140s.zip" | md5sum -c -
md5sum: mame0140s.zip: No such file or directory
mame0140s.zip: FAILED open or read
md5sum: WARNING: 1 of 1 listed file could not be read
make: *** [get-orig-source] Error 1

mame-0.140$ ls
debian downloader.php?&file=mame0140s.zip

Changed in mame (Ubuntu):
assignee: Micah Gersten (micahg) → Cesare Falco (c.falco)
status: In Progress → Incomplete
Revision history for this message
Evan Broder (broder) wrote :

I'm unsubscribing sponsors for now. Please feel free to re-subscribe when you've had an opportunity to address Micah's concern.

tags: added: patch
Revision history for this message
Cesare Falco (c.falco) wrote :

Download location was not changed, just the file had a bad name once downloaded (downloader.php?&file=mame0140s.zip instead of mame0140s.zip).

Looks like wget changed default behaviour on redirections. Adding the --trust-server-names option fixed it. Weird.
I didn't bother to rebuild the package on ppa as I only changed the get-orig-source target in debian/rules.

Thanks for pointing this out. It completely slipped through.

Cesare.

Changed in mame (Ubuntu):
status: Incomplete → Confirmed
assignee: Cesare Falco (c.falco) → nobody
Revision history for this message
Micah Gersten (micahg) wrote :

Thank you for the update. --trust-server-names is not a secure in maintainer scripts as explained here:
http://www.openwall.com/lists/oss-security/2010/05/18/13
and
http://www.ubuntu.com/usn/usn-982-1
Could you please use -O instead since we know what the filename should be?

Changed in mame (Ubuntu):
assignee: nobody → Cesare Falco (c.falco)
status: Confirmed → Incomplete
Revision history for this message
Cesare Falco (c.falco) wrote :

Done, mainly for the sake of backporting process:
wget issue has been fixed in maverick package.

Changed in mame (Ubuntu):
status: Incomplete → Confirmed
assignee: Cesare Falco (c.falco) → nobody
Revision history for this message
Alessio Treglia (quadrispro) wrote :

Micah,

how's the progress here?

Revision history for this message
Micah Gersten (micahg) wrote :

mame-0.140$ debuild -S -sa
 dpkg-buildpackage -rfakeroot -d -us -uc -S -sa
dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor):
dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions
dpkg-buildpackage: source package mame
dpkg-buildpackage: source version 0.140-0ubuntu1
dpkg-buildpackage: source changed by Cesare Falco <email address hidden>
 dpkg-source --before-build mame-0.140
 fakeroot debian/rules clean
dh clean
   dh_testdir
   debian/rules override_dh_auto_clean
make[1]: Entering directory `/opt/source/natty/mame-0.140'
/usr/bin/make OPT_FLAGS="-D'INI_PATH=\"/etc/mame\"'" FULLNAME=mame TARGET=mame SUBTARGET=mame OSD=sdl CROSS_BUILD_OSD= TARGETOS=unix PREFIX= SUFFIX= DEBUG= PROFILER= NOWERROR= MACOSX_USE_LIBSDL= BUILD_EXPAT= BUILD_ZLIB= SYMBOLS= SYMLEVEL= DUMPSYM= PROFILE= MAP= VERBOSE= OPTIMIZE=3 DISTRO=gcc44-generic ARCHOPTS=-march=athlon64 FORCE_DRC_C_BACKEND= PTR64=1 BIGENDIAN= clean
make[2]: Entering directory `/opt/source/natty/mame-0.140'
make[2]: *** No rule to make target `clean'. Stop.
make[2]: Leaving directory `/opt/source/natty/mame-0.140'
make[1]: *** [override_dh_auto_clean] Error 2
make[1]: Leaving directory `/opt/source/natty/mame-0.140'
make: *** [clean] Error 2
dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit status 2
debuild: fatal error at line 1337:
dpkg-buildpackage -rfakeroot -d -us -uc -S -sa failed

Did this work for you locally?

Changed in mame (Ubuntu):
status: Confirmed → Incomplete
assignee: nobody → Cesare Falco (c.falco)
Revision history for this message
Cesare Falco (c.falco) wrote :
Download full text (4.1 KiB)

Yes, that's exactly how i built the source package. ;)

I tried it again however (some messages are in italian, sorry):

------------------------------------------------------------------------------------
cesare@beltade:~/tmp/mame140/mame-0.140$ ls -l
totale 81
drwxr-xr-x 4 cesare cesare 760 2010-11-16 21:28 debian
drwxr-xr-x 2 cesare cesare 200 2010-11-18 18:08 docs
-rw-r--r-- 1 cesare cesare 17410 2010-11-18 18:08 makefile
drwxr-xr-x 9 cesare cesare 248 2010-11-18 18:08 src
-rw-r--r-- 1 cesare cesare 61400 2010-11-18 18:08 whatsnew.txt
cesare@beltade:~/tmp/mame140/mame-0.140$ debuild -S -sa
 dpkg-buildpackage -rfakeroot -d -us -uc -S -sa
dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor):
dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2
dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions
dpkg-buildpackage: source package mame
dpkg-buildpackage: source version 0.140-0ubuntu1
dpkg-buildpackage: source changed by Cesare Falco <email address hidden>
 dpkg-source --before-build mame-0.140
 fakeroot debian/rules clean
dh clean
   dh_testdir
   debian/rules override_dh_auto_clean
make[1]: ingresso nella directory «/home/cesare/tmp/mame140/mame-0.140»
/usr/bin/make OPT_FLAGS="-D'INI_PATH=\"/etc/mame\"'" FULLNAME=mame TARGET=mame SUBTARGET=mame OSD=sdl CROSS_BUILD_OSD= TARGETOS=unix PREFIX= SUFFIX= DEBUG= PROFILER= NOWERROR= MACOSX_USE_LIBSDL= BUILD_EXPAT= BUILD_ZLIB= SYMBOLS= SYMLEVEL= DUMPSYM= PROFILE= MAP= VERBOSE= OPTIMIZE=3 DISTRO=gcc44-generic ARCHOPTS=-march=athlon64 FORCE_DRC_C_BACKEND= PTR64=1 BIGENDIAN= clean
make[2]: ingresso nella directory «/home/cesare/tmp/mame140/mame-0.140»
Deleting object tree obj/sdl/mame...
Deleting mame...
Deleting testkeys romcmp chdman jedutil unidasm ldresample ldverify regrep srcclean src2html split ...
make[2]: uscita dalla directory «/home/cesare/tmp/mame140/mame-0.140»
/usr/bin/make OPT_FLAGS="-D'INI_PATH=\"/etc/mame\"'" FULLNAME=mame TARGET=mame SUBTARGET=mame OSD=sdl CROSS_BUILD_OSD= TARGETOS=unix PREFIX= SUFFIX= DEBUG= PROFILER= NOWERROR= MACOSX_USE_LIBSDL= BUILD_EXPAT= BUILD_ZLIB= SYMBOLS= SYMLEVEL= DUMPSYM= PROFILE= MAP= VERBOSE= OPTIMIZE=3 DISTRO=gcc44-generic ARCHOPTS=-march=athlon64 FORCE_DRC_C_BACKEND= PTR64=1 BIGENDIAN= TARGET=ldplayer \
                             FULLNAME=ldplayer \
                             SUBTARGET=ldplayer \
                             clean
make[2]: ingresso nella directory «/home/cesare/tmp/mame140/mame-0.140»
Deleting object tree obj/sdl/ldplayer...
Deleting ldplayer...
Deleting testkeys romcmp chdman jedutil unidasm ldresample ldverify regrep srcclean src2html split ...
make[2]: uscita dalla directory «/home/cesare/tmp/mame140/mame-0.140»
rm -rf obj/
make[1]: uscita dalla directory «/home/cesare/tmp/mame140/mame-0.140»
   dh_clean
 dpkg-source -b mame-0.140
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building mame using existing ./mame_0.140.orig.tar.bz2
dpkg-source: info: ...

Read more...

Changed in mame (Ubuntu):
status: Incomplete → Confirmed
assignee: Cesare Falco (c.falco) → nobody
Revision history for this message
Michael Casadevall (mcasadevall) wrote :

This looks sane. I'm currently doing test building, and rechecking everything, but unless I find something, I plan to upload this to the archive later tonight/tomorrow.

Revision history for this message
Luke Yelavich (themuso) wrote :

Cesare, thank you very much for your contribution to Ubuntu. I am now taking a look at this package, and if there are no issues, I will upload your changes to Ubuntu.

Thanks again.

Changed in mame (Ubuntu):
assignee: nobody → Luke Yelavich (themuso)
status: Confirmed → In Progress
Revision history for this message
Luke Yelavich (themuso) wrote :

Unfortunately, this fails to build for me, build log attached. If you could have a look to see what the problem is, that would be great.

Thanks again for your work.

Changed in mame (Ubuntu):
assignee: Luke Yelavich (themuso) → Cesare Falco (c.falco)
status: In Progress → Incomplete
Revision history for this message
Luke Yelavich (themuso) wrote :

I have unsubscribed ubuntu-sponsors for now, please re-subscribe ubuntu-sponsors once you have updated the bug, and it is ready to be reviewed again.

Thanks.

Revision history for this message
Cesare Falco (c.falco) wrote :

Bug was gcc related, looks like gcc 4.4 can no longer be invoked with the same set of packages and in natty default compiler is gcc 4.5.

I had to wait the new upstream release, which fixes a couple of bugs in variable handling that were revealed with the default optimizations of gcc 4.5.

This is the updated debian.tar.gz, a recent build is available on my ppa, the only difference being the release version in debian/changelog:
https://edge.launchpad.net/~c.falco/+archive/ppa/+packages

Thanks,
Cesare.

summary: - [upgrade] New upstream release 0.140
+ [upgrade] New upstream release 0.141
Changed in mame (Ubuntu):
status: Incomplete → Confirmed
assignee: Cesare Falco (c.falco) → nobody
Revision history for this message
Stefano Rivera (stefanor) wrote :

get-orig-source doesn't appear to work, looks like the URL scheme changed:

wget -U ubuntu -P . -O mame0141s.zip \
        "http://mamedev.org/downloader.php?&file=mame0141s.zip"
--2011-01-04 16:20:35-- http://mamedev.org/downloader.php?&file=mame0141s.zip
Resolving mamedev.org... 67.210.100.31
Connecting to mamedev.org|67.210.100.31|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://mamedev.mameworld.info/mame0141s.zip [following]
--2011-01-04 16:20:36-- http://mamedev.mameworld.info/mame0141s.zip
Resolving mamedev.mameworld.info... 173.248.191.29
Connecting to mamedev.mameworld.info|173.248.191.29|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2011-01-04 16:20:36 ERROR 404: Not Found.

make: *** [mame0141s.zip] Error 8

Revision history for this message
Cesare Falco (c.falco) wrote :

Fixed and updated debian/changelog.

Thanks,
Cesare.

Changed in mame (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mame - 0.141-0ubuntu1

---------------
mame (0.141-0ubuntu1) natty; urgency=low

  * New upstream release (LP: #671358)
  * contrib/mame.ini: improved user settings management (LP: #657102)
  * removed debian/patch/delete_obj_dir_on_make_clean.patch,
    delete obj/ dir in debian/rules instead
  * debian/control:
    - bump Standards-version to 3.9.1
    - added dependence on libsdl-ttf (required upstream)
  * debian/rules:
    - fixed wget options, updated url in mame$(subst .,,$(VER))s.zip target
    - removed dependence on gcc 4.4, use default compiler
  * debian/watch: updated filenamemangle option
  * mame-tools: reintroduced ldplayer
 -- Cesare Falco <email address hidden> Sat, 01 Jan 2011 23:30:51 +0100

Changed in mame (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.