ampache does not configure webserver correctly

The patch uploaded to maverick-proposed looks backwards:

         for webserver in $webservers; do
             webserver=${webserver%,}
- if [ "$webserver" = "lighttpd" ] ; then
+ if [ "$webservers" = "lighttpd" ] ; then

Since this is a loop, the original version definitively looks correct.

Bah, I created the debdiff backwards the package was correct :(

Reuploaded ampache-3.5.4-7ubuntu2.2 and added a new debdiff.

Best regards
Charlie Smotherman

I fixed this with a

sudo ln -s /etc/ampache/ampache.conf /etc/apache2/conf.d/

Will this cause problems when the real fix is deployed?

No, I wasn't looking at the attached debdiff, but the uploaded debdiff. Also, please reuse the original 3.5.4-7ubuntu2.1 version number and changelog, uploading a changelog that just says "No change rebuild." without any bug reference is invalid for an SRU.

Reuploaded ampache-3.5.4-7ubuntu2.1

Hopefully this will help explain things, "webservers" is set in the line above that is not included in the diff

db_get ampache/webserver_type || true
webservers="$RET"

So using $webservers is correct, unless there is a better way of correcting this?

Best regards
Charlie

If the debconf result is supposed to be a list, the original code was correct. If it's only a single value, then the "for" loop doesn't make sense, but the original code would still be correct. But the uploaded SRU change just doesn't make sense this way:

         for webserver in $webservers; do
             webserver=${webserver%,}
- if [ "$webserver" = "lighttpd" ] ; then
+ if [ "$webservers" = "lighttpd" ] ; then

Also, the source package was built in a strange way (not using the Ubuntu dpkg?), it's missing the Launchpad-Bugs-Fixed: line in the source.changes.

pitti,

I have removed the "for" loop in ampache.postrm and ampache.postinst. Once I started looking at the code closer I said to myself "yea know he's right you really don't need that "for" loop". The code looks simpler, easier to read, cleaner, thanks for the suggestion :) I will also be making these changes in debian thx again.

Charlie

Sitting in maverick-proposed unapproved queue. ubuntu-sru subcribed, needs approval

Charlie, was the fixed "for" loop done in natty as well?

Accepted ampache into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Any testers?

Pitti,

Sorry for taking so long I got caught up in another project I'm working on and actually forgot about this. The upgrade from 7ubuntu1 => 7ubuntu2.1 succeeds and you can get to the web install pages, however 7ubuntu2.1 fails when doing a fresh install. I have prepared 7ubuntu2.2 and attached a diff of the changes. I have changed natty to use a Virtualhost and a2ensite in the postinst and a2dissite in postrm.

Accepted ampache into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I will test this evening (16th) and reply with notes about my success.

Works like a charm using the instructions Charlie linked to: https://wiki.ubuntu.com/Testing/EnableProposed . firefox localhost/ampache picked up the configuration page. Going through the rest of the configuration now.

Continuing from my message above - rest of the configuration works smoothly. Great! Thanks.

This bug was fixed in the package ampache - 3.5.4-7ubuntu2.2

---------------
ampache (3.5.4-7ubuntu2.2) maverick-proposed; urgency=low

  * Removed second test in the conditional statememt in ampache_install().
    (LP: #676234)
 -- Charlie Smotherman <email address hidden> Mon, 31 Jan 2011 19:40:15 -0500