No log output when launching iceccd

Bug #697788 reported by Aloisio Almeida Jr
24
This bug affects 1 person
Affects Status Importance Assigned to Milestone
icecc (Debian)
Fix Released
Unknown
icecc (Ubuntu)
Fix Released
Undecided
Unassigned
Hardy
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: icecc

1)
~$ lsb_release -rd
Description: Ubuntu 10.10
Release: 10.10

2)
~$ apt-cache policy icecc
icecc:
  Installed: 0.9.5-2
  Candidate: 0.9.5-2
  Version table:
 *** 0.9.5-2 0
        500 http://br.archive.ubuntu.com/ubuntu/ maverick/universe amd64 Packages
        100 /var/lib/dpkg/status

3) What is expected:
The log output at /var/log/iceccd.log file when iceccd is launched

4) What happened instead?
There is no log file

5) Probing:

In the /etc/init.d/icecc we have:

start-stop-daemon --start --quiet --exec $DAEMON -- \
-d "$logfile" $nice $scheduler $netname -u icecc $basedir $maxjobs

and $logfile is "-l /var/log/iceccd.log". Note that there is a "" around $logfile variable. When stracing the init script execution, we got the following relevant output:

[pid 30944] execve("/sbin/start-stop-daemon", ["start-stop-daemon", "--start", "--quiet", "--exec", "/usr/sbin/iceccd", "--", "-vvv", "-d", "-l /var/log/iceccd.log", "--nice", "5", "-n", "openbossa", "-u", "icecc", "-b", ...], [/* 17 vars */]) = 0
(...)
[pid 30944] execve("/usr/sbin/iceccd", ["/usr/sbin/iceccd", "-vvv", "-d", "-l /var/log/iceccd.log", "--nice", "5", "-n", "openbossa", "-u", "icecc", "-b", "/var/cache/icecc"], [/* 17 vars */]) = 0
(...)
[pid 30944] open(" /var/log/iceccd.log", O_WRONLY|O_CREAT|O_APPEND, 0666) = -1 ENOENT (No such file or directory)

6) Solution:
Removing the "" around $logfile solves the issue. I just don't know why only $logfile variable is embraced by quotes. If there is a reason, other solution must be applied.

Revision history for this message
Aloisio Almeida Jr (aloisiojr) wrote :

Proposed patch

tags: added: patch
Daniel T Chen (crimsun)
tags: added: patch-forwarded-debian
removed: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package icecc - 0.9.6-1ubuntu1

---------------
icecc (0.9.6-1ubuntu1) oneiric; urgency=low

  * Apply patch from Aloisio Almeida to resolve broken logging
    when iceccd is launched from its initscript. (LP: #697788)
 -- Daniel T Chen <email address hidden> Tue, 26 Jul 2011 20:17:39 -0400

Changed in icecc (Ubuntu):
status: New → Fix Released
Daniel T Chen (crimsun)
tags: added: patch-accepted-debian
removed: patch-forwarded-debian
Revision history for this message
Rolf Leggewie (r0lf) wrote :

I'd like to see the patch backported to lucid and maybe even hardy. Here is the Lucid debdiff. It works as advertised on my lucid machine.

Revision history for this message
Rolf Leggewie (r0lf) wrote :
Revision history for this message
Rolf Leggewie (r0lf) wrote :

And here is the tested-for-compilation-only debdiff for hardy

Changed in icecc (Debian):
status: Unknown → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Why do patches like this get ignored for three months? :-((

Revision history for this message
Martin Pitt (pitti) wrote :

Sorry, sponsors were not subscribed. I'll do the sponsoring now.

Changed in icecc (Ubuntu Hardy):
status: New → Fix Committed
Changed in icecc (Ubuntu Lucid):
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Aloisio, or anyone else affected,

Accepted icecc into hardy-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello Aloisio, or anyone else affected,

Accepted icecc into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Thanks, Martin. I'll test when the packages are available for lucid.

Rolf Leggewie (r0lf)
tags: added: verification-done-lucid
removed: verification-needed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

I was able to confirm that the log files are correctly created in lucid. I had nothing to compile, so they're still empty, but I guess that's to be expected.

setting to verification-done-lucid

Revision history for this message
Rolf Leggewie (r0lf) wrote :

Since I had a pbuilder-dist chroot for hardy lying around I did the verification for hardy as well. And indeed, I can confirm the problem as well as the fix. Please release.

tags: added: verification-done-hardy
Rolf Leggewie (r0lf)
tags: added: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package icecc - 0.8.0-2ubuntu1

---------------
icecc (0.8.0-2ubuntu1) hardy-proposed; urgency=low

  * backport patch from Aloisio Almeida Jr to fix logging. LP: #697788
 -- Rolf Leggewie <email address hidden> Fri, 29 Jul 2011 22:25:11 +0900

Changed in icecc (Ubuntu Hardy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package icecc - 0.9.4-2ubuntu1

---------------
icecc (0.9.4-2ubuntu1) lucid-proposed; urgency=low

  * backport patch from Aloisio Almeida Jr to fix logging. LP: #697788
 -- Rolf Leggewie <email address hidden> Fri, 29 Jul 2011 21:41:23 +0900

Changed in icecc (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.